From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8531C433DF for ; Thu, 20 Aug 2020 06:09:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1DFB2078D for ; Thu, 20 Aug 2020 06:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725916AbgHTGJA (ORCPT ); Thu, 20 Aug 2020 02:09:00 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:40515 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgHTGJA (ORCPT ); Thu, 20 Aug 2020 02:09:00 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 07K68hSw021529; Thu, 20 Aug 2020 08:08:43 +0200 Date: Thu, 20 Aug 2020 08:08:43 +0200 From: Willy Tarreau To: Sedat Dilek Cc: Eric Dumazet , George Spelvin , Linus Torvalds , Amit Klein , "Jason A. Donenfeld" , Andy Lutomirski , Kees Cook , Thomas Gleixner , Peter Zijlstra , netdev@vger.kernel.org Subject: Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable Message-ID: <20200820060843.GA21526@1wt.eu> References: <20200813080646.GB10907@1wt.eu> <20200814160551.GA11657@1wt.eu> <20200816150133.GA17475@1wt.eu> <20200820043323.GA21461@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 20, 2020 at 06:42:23AM +0200, Sedat Dilek wrote: > On Thu, Aug 20, 2020 at 6:33 AM Willy Tarreau wrote: > > > > On Thu, Aug 20, 2020 at 05:05:49AM +0200, Sedat Dilek wrote: > > > We have the same defines for K0 and K1 in include/linux/prandom.h and > > > lib/random32.c? > > > More room for simplifications? > > > > Definitely, I'm not surprized at all. As I said, the purpose was to > > discuss around the proposal, not much more. If we think it's the way > > to go, some major lifting is required. I just don't want to invest > > significant time on this if nobody cares. > > > > OK. > > Right now, I will try with the attached diff. No, don't waste your time this way, it's not the right way to address it, you're still facing competition between defines. I'll do another one if you want to go further in the tests. > Unclear to me where this modpost "net_rand_noise" undefined! comes from. > Any hints? Sure, the symbol is not exported. I'll address it as well for you. Willy