From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Thu, 20 Aug 2020 06:23:01 +0000 Subject: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-Id: <20200820062301.GD3248864@dell> List-Id: References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> In-Reply-To: <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: dinghao.liu@zju.edu.cn Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Markus Elfring , Jingoo Han , Kangjie Lu , Daniel Thompson On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > When of_property_read_u32_array() returns an error code, > > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > > > Can another imperative wording be helpful for the change description? > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id445bf405cb331117bc98427b1ba6f12418ad17#n151 > > > > > > Would an other commit message be a bit nicer? > > > > > > > > > … > > > > +++ b/drivers/video/backlight/sky81452-backlight.c > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > > > > num_entry); > > > > if (ret < 0) { > > > > dev_err(dev, "led-sources node is invalid.\n"); > > > > + of_node_put(np); > > > > return ERR_PTR(-EINVAL); > > > > } > > > > > > I propose to add the jump target “put_node” so that a bit of common exception > > > handling code can be better reused at the end of this function implementation. > > > > > > Regards, > > > Markus > > > > You can safely ignore any review comments from Markus! > > > > However, this patch doesn't appear to be in my inbox. > > > > Any ideas as to why? > > > > Thank you for your advice. My outbox shows that this patch > has reached your email server successfully. Maybe this > ended up in your junk mail file? This has happened recently, so I was sure to check. Not there either unfortunately. Would you be kind enough to bounce/resend please? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62FEBC433E1 for ; Thu, 20 Aug 2020 06:23:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30F462075E for ; Thu, 20 Aug 2020 06:23:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HiW1tz0R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30F462075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AAAC6E8A8; Thu, 20 Aug 2020 06:23:07 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id C60E66E8A8 for ; Thu, 20 Aug 2020 06:23:06 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id z18so874302wrm.12 for ; Wed, 19 Aug 2020 23:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Rfe5cf8ONeOtyLL1u7/RmPWIu+jJLpGbwRQ//wGFeDM=; b=HiW1tz0Re0iY3P915VZVsLzjSN7j7y5asxapsRDp7fVIOb5J7C5nLkBOeRcy6/JJWO xarF8bqLYq3w6ERx3p2kDYIik/29V6DZuGZFbqbD5Lg+FXbhz2mHa1YMfX0w+jR8rkWO iY0pyjp8BQL06RTpY8f2toCrB39wuV/Km9oeZE6fA14hiKCo/jtH4a/0KPCO7r1qhWRU FNAOnALWdwnBpDjDXJ0Be/jxzmHL7udncEIr+KW82c4+7cIdVG/nvqcHm4Io6Wnqmi6X s9pknqLptsmCuiGKZ+/gnKAYSR5v+OYRENLKCsp47kxlDJ8MR5JGEw5rgYU26AzZeeiJ glnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Rfe5cf8ONeOtyLL1u7/RmPWIu+jJLpGbwRQ//wGFeDM=; b=BciQ0j1O+MRUr4LZ2gg4udZIv5EL5jOm7hRAGR1JQKZxPuTD9iwWovGTetGjzleH9f +yMZ/aqR3Ku8brnL6EHsU8TSIOVJC7pDIqtyZ27Rdnu55UdL9wtyWtXN4nJM7cR3Yf4U YCD3gsbpuZ4WesySu6RdxZEqzBFDvZbx3iStzWZmWw1EhXreDP5tOiOJAZVZWBPQWgix bC+YMyHu1RMLZzHlj+Mv6Qyo1o6xou+WFG69kgybt8GCox2+EtA6Q0UI9Ik9ln8VrCXR nxneYUJxO+KMZyMrEsBmtqvBb5qzoVW0/TPbXOHRJ4ATtXjk50ZUO5PV7GzFG7d6SxxP y/Bw== X-Gm-Message-State: AOAM532lrhDJtSBnoSGjoRTDIYpNm7pRq6gfFt+wBvzdjBWA093IlxGo yzkB/2AhRaFkaoj47d4z6S9QYg== X-Google-Smtp-Source: ABdhPJzrNMIAs3RWwn1qW6NmluXvS0ZXgMLj8VZFmRCLMLi1HODyj9WHOhedRDqWOEublp+0scrmyQ== X-Received: by 2002:adf:e506:: with SMTP id j6mr1495836wrm.287.1597904585322; Wed, 19 Aug 2020 23:23:05 -0700 (PDT) Received: from dell ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id t189sm2308285wmf.47.2020.08.19.23.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 23:23:04 -0700 (PDT) Date: Thu, 20 Aug 2020 07:23:01 +0100 From: Lee Jones To: dinghao.liu@zju.edu.cn Subject: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-ID: <20200820062301.GD3248864@dell> References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Markus Elfring , Jingoo Han , Kangjie Lu , Daniel Thompson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAyMCBBdWcgMjAyMCwgZGluZ2hhby5saXVAemp1LmVkdS5jbiB3cm90ZToKCj4gPiBP biBXZWQsIDE5IEF1ZyAyMDIwLCBNYXJrdXMgRWxmcmluZyB3cm90ZToKPiA+IAo+ID4gPiA+IFdo ZW4gb2ZfcHJvcGVydHlfcmVhZF91MzJfYXJyYXkoKSByZXR1cm5zIGFuIGVycm9yIGNvZGUsCj4g PiA+ID4gYSBwYWlyaW5nIHJlZmNvdW50IGRlY3JlbWVudCBpcyBuZWVkZWQgdG8ga2VlcCBucCdz IHJlZmNvdW50IGJhbGFuY2VkLgo+ID4gPiAKPiA+ID4gQ2FuIGFub3RoZXIgaW1wZXJhdGl2ZSB3 b3JkaW5nIGJlIGhlbHBmdWwgZm9yIHRoZSBjaGFuZ2UgZGVzY3JpcHRpb24/Cj4gPiA+IGh0dHBz Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4 LmdpdC90cmVlL0RvY3VtZW50YXRpb24vcHJvY2Vzcy9zdWJtaXR0aW5nLXBhdGNoZXMucnN0P2lk PTE4NDQ1YmY0MDVjYjMzMTExN2JjOTg0MjdiMWJhNmYxMjQxOGFkMTcjbjE1MQo+ID4gPiAKPiA+ ID4gV291bGQgYW4gb3RoZXIgY29tbWl0IG1lc3NhZ2UgYmUgYSBiaXQgbmljZXI/Cj4gPiA+IAo+ ID4gPiAKPiA+ID4g4oCmCj4gPiA+ID4gKysrIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvc2t5 ODE0NTItYmFja2xpZ2h0LmMKPiA+ID4gPiBAQCAtMjE3LDYgKzIxNyw3IEBAIHN0YXRpYyBzdHJ1 Y3Qgc2t5ODE0NTJfYmxfcGxhdGZvcm1fZGF0YSAqc2t5ODE0NTJfYmxfcGFyc2VfZHQoCj4gPiA+ ID4gIAkJCQkJbnVtX2VudHJ5KTsKPiA+ID4gPiAgCQlpZiAocmV0IDwgMCkgewo+ID4gPiA+ICAJ CQlkZXZfZXJyKGRldiwgImxlZC1zb3VyY2VzIG5vZGUgaXMgaW52YWxpZC5cbiIpOwo+ID4gPiA+ ICsJCQlvZl9ub2RlX3B1dChucCk7Cj4gPiA+ID4gIAkJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwp Owo+ID4gPiA+ICAJCX0KPiA+ID4gCj4gPiA+IEkgcHJvcG9zZSB0byBhZGQgdGhlIGp1bXAgdGFy Z2V0IOKAnHB1dF9ub2Rl4oCdIHNvIHRoYXQgYSBiaXQgb2YgY29tbW9uIGV4Y2VwdGlvbgo+ID4g PiBoYW5kbGluZyBjb2RlIGNhbiBiZSBiZXR0ZXIgcmV1c2VkIGF0IHRoZSBlbmQgb2YgdGhpcyBm dW5jdGlvbiBpbXBsZW1lbnRhdGlvbi4KPiA+ID4gCj4gPiA+IFJlZ2FyZHMsCj4gPiA+IE1hcmt1 cwo+ID4gCj4gPiBZb3UgY2FuIHNhZmVseSBpZ25vcmUgYW55IHJldmlldyBjb21tZW50cyBmcm9t IE1hcmt1cyEKPiA+IAo+ID4gSG93ZXZlciwgdGhpcyBwYXRjaCBkb2Vzbid0IGFwcGVhciB0byBi ZSBpbiBteSBpbmJveC4KPiA+IAo+ID4gQW55IGlkZWFzIGFzIHRvIHdoeT8KPiA+IAo+IAo+IFRo YW5rIHlvdSBmb3IgeW91ciBhZHZpY2UuIE15IG91dGJveCBzaG93cyB0aGF0IHRoaXMgcGF0Y2gK PiBoYXMgcmVhY2hlZCB5b3VyIGVtYWlsIHNlcnZlciBzdWNjZXNzZnVsbHkuIE1heWJlIHRoaXMK PiBlbmRlZCB1cCBpbiB5b3VyIGp1bmsgbWFpbCBmaWxlPwoKVGhpcyBoYXMgaGFwcGVuZWQgcmVj ZW50bHksIHNvIEkgd2FzIHN1cmUgdG8gY2hlY2suCgpOb3QgdGhlcmUgZWl0aGVyIHVuZm9ydHVu YXRlbHkuCgpXb3VsZCB5b3UgYmUga2luZCBlbm91Z2ggdG8gYm91bmNlL3Jlc2VuZCBwbGVhc2U/ CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVs b3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJt IFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1571DC433E3 for ; Thu, 20 Aug 2020 06:23:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E72A62075E for ; Thu, 20 Aug 2020 06:23:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HiW1tz0R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbgHTGXI (ORCPT ); Thu, 20 Aug 2020 02:23:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbgHTGXH (ORCPT ); Thu, 20 Aug 2020 02:23:07 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AF97C061757 for ; Wed, 19 Aug 2020 23:23:06 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f7so935883wrw.1 for ; Wed, 19 Aug 2020 23:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Rfe5cf8ONeOtyLL1u7/RmPWIu+jJLpGbwRQ//wGFeDM=; b=HiW1tz0Re0iY3P915VZVsLzjSN7j7y5asxapsRDp7fVIOb5J7C5nLkBOeRcy6/JJWO xarF8bqLYq3w6ERx3p2kDYIik/29V6DZuGZFbqbD5Lg+FXbhz2mHa1YMfX0w+jR8rkWO iY0pyjp8BQL06RTpY8f2toCrB39wuV/Km9oeZE6fA14hiKCo/jtH4a/0KPCO7r1qhWRU FNAOnALWdwnBpDjDXJ0Be/jxzmHL7udncEIr+KW82c4+7cIdVG/nvqcHm4Io6Wnqmi6X s9pknqLptsmCuiGKZ+/gnKAYSR5v+OYRENLKCsp47kxlDJ8MR5JGEw5rgYU26AzZeeiJ glnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Rfe5cf8ONeOtyLL1u7/RmPWIu+jJLpGbwRQ//wGFeDM=; b=Lydz5rLbR9RqmuKJXZfytHym/Glgb6QJwGxeXcOFyngSk2bsFwFWX+bbhfL2yEXxvp PHsBNgBe7JOZPdkpya4rzrDMoAD+xvtIZJLvBWc7MSFMwEhIgcA85B6uVsXXa8i7JzdI FespBTBCOYkDRx2fUEFq6xcBkH60Jc9tq+u5ZFnB1p0t6ewSGPv4KSmlXSXYAF4G/4Vd 0ScBs3xVqdP8JALVURrOgBoVkL9Bzsw+KuLz6PFG+73JOIQSB3GPzwlsAazqXVGZdUSe OS5gZp4zCWuWwKAddN6go41tVNYPcqPyp5MozsbAxEK4fOq5TN8udr2NIfw/6C0fWHhR ZX6w== X-Gm-Message-State: AOAM531Q9k2Nd90X+8TrXHrRRlGCr7NNpURpB8IukuiHKuQlWlxNhGEr 9M9L8KR/zFWZSJT9byVCoEbsNg== X-Google-Smtp-Source: ABdhPJzrNMIAs3RWwn1qW6NmluXvS0ZXgMLj8VZFmRCLMLi1HODyj9WHOhedRDqWOEublp+0scrmyQ== X-Received: by 2002:adf:e506:: with SMTP id j6mr1495836wrm.287.1597904585322; Wed, 19 Aug 2020 23:23:05 -0700 (PDT) Received: from dell ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id t189sm2308285wmf.47.2020.08.19.23.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 23:23:04 -0700 (PDT) Date: Thu, 20 Aug 2020 07:23:01 +0100 From: Lee Jones To: dinghao.liu@zju.edu.cn Cc: Markus Elfring , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bartlomiej Zolnierkiewicz , Bryan Wu , Daniel Thompson , Gyungoh Yoo , Jingoo Han , Kangjie Lu Subject: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-ID: <20200820062301.GD3248864@dell> References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > When of_property_read_u32_array() returns an error code, > > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > > > Can another imperative wording be helpful for the change description? > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151 > > > > > > Would an other commit message be a bit nicer? > > > > > > > > > … > > > > +++ b/drivers/video/backlight/sky81452-backlight.c > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > > > > num_entry); > > > > if (ret < 0) { > > > > dev_err(dev, "led-sources node is invalid.\n"); > > > > + of_node_put(np); > > > > return ERR_PTR(-EINVAL); > > > > } > > > > > > I propose to add the jump target “put_node” so that a bit of common exception > > > handling code can be better reused at the end of this function implementation. > > > > > > Regards, > > > Markus > > > > You can safely ignore any review comments from Markus! > > > > However, this patch doesn't appear to be in my inbox. > > > > Any ideas as to why? > > > > Thank you for your advice. My outbox shows that this patch > has reached your email server successfully. Maybe this > ended up in your junk mail file? This has happened recently, so I was sure to check. Not there either unfortunately. Would you be kind enough to bounce/resend please? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog