From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa@kernel.org>
Cc: linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH] mmc: test: remove ambiguity in test description
Date: Thu, 20 Aug 2020 08:56:20 +0200 [thread overview]
Message-ID: <20200820065620.GA39265@wyvern> (raw)
In-Reply-To: <20200817115838.2981-1-wsa@kernel.org>
Hi Wolfram,
Thanks for your work.
On 2020-08-17 13:58:38 +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> When reading the test description, I thought a correction of the
> xfer_size was tested, which is not the case. It is tested that the
> xfer_size is correct. Use 'proper xfer_size' to remove this ambiguity.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
For what it's worth,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>
> This may be bike-shedding and I am not offended if you think it is
> minor. However, I ended up looking at the source wondering where is what
> automatically corrected.
>
> drivers/mmc/core/mmc_test.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index c21b3cb71775..152e7525ed33 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = {
> },
>
> {
> - .name = "Correct xfer_size at write (start failure)",
> + .name = "Proper xfer_size at write (start failure)",
> .run = mmc_test_xfersize_write,
> },
>
> {
> - .name = "Correct xfer_size at read (start failure)",
> + .name = "Proper xfer_size at read (start failure)",
> .run = mmc_test_xfersize_read,
> },
>
> {
> - .name = "Correct xfer_size at write (midway failure)",
> + .name = "Proper xfer_size at write (midway failure)",
> .run = mmc_test_multi_xfersize_write,
> },
>
> {
> - .name = "Correct xfer_size at read (midway failure)",
> + .name = "Proper xfer_size at read (midway failure)",
> .run = mmc_test_multi_xfersize_read,
> },
>
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2020-08-20 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 11:58 [PATCH] mmc: test: remove ambiguity in test description Wolfram Sang
2020-08-20 6:56 ` Niklas Söderlund [this message]
2020-08-24 9:50 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820065620.GA39265@wyvern \
--to=niklas.soderlund@ragnatech.se \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.