From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Thu, 20 Aug 2020 07:49:16 +0000 Subject: Re: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-Id: <20200820074916.GE3248864@dell> List-Id: References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> <20200820062301.GD3248864@dell> <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> In-Reply-To: <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: dinghao.liu@zju.edu.cn Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Markus Elfring , Jingoo Han , Kangjie Lu , Daniel Thompson On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > > > > > When of_property_read_u32_array() returns an error code, > > > > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > > > > > > > Can another imperative wording be helpful for the change description? > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id445bf405cb331117bc98427b1ba6f12418ad17#n151 > > > > > > > > > > Would an other commit message be a bit nicer? > > > > > > > > > > > > > > > … > > > > > > +++ b/drivers/video/backlight/sky81452-backlight.c > > > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > > > > > > num_entry); > > > > > > if (ret < 0) { > > > > > > dev_err(dev, "led-sources node is invalid.\n"); > > > > > > + of_node_put(np); > > > > > > return ERR_PTR(-EINVAL); > > > > > > } > > > > > > > > > > I propose to add the jump target “put_node” so that a bit of common exception > > > > > handling code can be better reused at the end of this function implementation. > > > > > > > > > > Regards, > > > > > Markus > > > > > > > > You can safely ignore any review comments from Markus! > > > > > > > > However, this patch doesn't appear to be in my inbox. > > > > > > > > Any ideas as to why? > > > > > > > > > > Thank you for your advice. My outbox shows that this patch > > > has reached your email server successfully. Maybe this > > > ended up in your junk mail file? > > > > This has happened recently, so I was sure to check. > > > > Not there either unfortunately. > > > > Would you be kind enough to bounce/resend please? > > Sure. Looks like you sent it *only* to me. Please keep everyone else in Cc when doing that, or I can't respond to everyone. Anyway, besides the subject line (which I can fix easily), the patch looks good to me, but Daniel T must review. Reviewed-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D26C433E1 for ; Thu, 20 Aug 2020 07:49:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECCEF2076E for ; Thu, 20 Aug 2020 07:49:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XlaONjDn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECCEF2076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C8A56E90B; Thu, 20 Aug 2020 07:49:24 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C7596E90B for ; Thu, 20 Aug 2020 07:49:23 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id a5so1057251wrm.6 for ; Thu, 20 Aug 2020 00:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XgD7oAraMYDOqNsfZffx0IqUVAmFZfcgzGRKvwI8mIc=; b=XlaONjDnEdsYg/6xqFFyWyTH0yWrgNaxkmvE+JWcDVZbLe+f/V7HKdjYROy7dyRpgD 0dP7O6uThUl2ocYIR33bisbTsV7PY13WDhwdzpoG+1juP2BKSoKiEUd4Vt3PTFRroRgA CKWIaTIqQLz/3rnEaEMJlfnH2LOTDEFgtejdx0YcZnIibXmUIW8mrTOAvdg1MlPqsu01 n4D3DHqkiUh/PUQcvUhn/MDFi/qLIJr1VljuscrpP3WooR3pcPufopgFHfsC1aJqsMPG YS204VOVM7RsVE5k9miArRNcssfkXrf1ORtWY/QTAhKAThyjJpNspv/DCPSgCLSS8wMB aMUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XgD7oAraMYDOqNsfZffx0IqUVAmFZfcgzGRKvwI8mIc=; b=ARANXqgl0U7MFqtV1IJgt2+mstHVGbdHp+PpxCcrqJAYKEfVNXWfqPmLvnMnGQ1Hel R/mqAWrrUYiQ/30/XlWKSpoqDCeilb1pDVwYcZDgvXLTBiyE+UCRSAQnllJztlyvis2x br9FI44OcDzfbfO5IiSZ7ZN8cuEPShcM685JFej0b9xDOvtyum53y7gaOR+L250raY5a 2CmQukHJUhRaMdugMDIuiDd652tFsFG3iH0BxvEEMGMAX4ByMT5Hl+4RE86R8FJOlbDt XX1hNKCzkgzAbPOyjK4goquPhBTSL3nOuxMAEv02OmYWA1brzqT0AnwGKVd13ks2KQys s7uA== X-Gm-Message-State: AOAM530zUoSd1k+tHgGkUpUz2Cbiy+a+Iv1ga2iP6U9igHQYWORbL4RS +EzXh+64VvCbDKTCPga7qh7Dww== X-Google-Smtp-Source: ABdhPJyboEGZAaF6RXm5GpaE/mKR6TYvk3Fye/goK+ikDC5z1N0gxsGJDDrfdepMKqxed6kq885b0w== X-Received: by 2002:a5d:60cb:: with SMTP id x11mr1737733wrt.281.1597909761789; Thu, 20 Aug 2020 00:49:21 -0700 (PDT) Received: from dell ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id s2sm2438068wrr.55.2020.08.20.00.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 00:49:21 -0700 (PDT) Date: Thu, 20 Aug 2020 08:49:16 +0100 From: Lee Jones To: dinghao.liu@zju.edu.cn Subject: Re: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-ID: <20200820074916.GE3248864@dell> References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> <20200820062301.GD3248864@dell> <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Markus Elfring , Jingoo Han , Kangjie Lu , Daniel Thompson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAyMCBBdWcgMjAyMCwgZGluZ2hhby5saXVAemp1LmVkdS5jbiB3cm90ZToKCj4gPiBP biBUaHUsIDIwIEF1ZyAyMDIwLCBkaW5naGFvLmxpdUB6anUuZWR1LmNuIHdyb3RlOgo+ID4gCj4g PiA+ID4gT24gV2VkLCAxOSBBdWcgMjAyMCwgTWFya3VzIEVsZnJpbmcgd3JvdGU6Cj4gPiA+ID4g Cj4gPiA+ID4gPiA+IFdoZW4gb2ZfcHJvcGVydHlfcmVhZF91MzJfYXJyYXkoKSByZXR1cm5zIGFu IGVycm9yIGNvZGUsCj4gPiA+ID4gPiA+IGEgcGFpcmluZyByZWZjb3VudCBkZWNyZW1lbnQgaXMg bmVlZGVkIHRvIGtlZXAgbnAncyByZWZjb3VudCBiYWxhbmNlZC4KPiA+ID4gPiA+IAo+ID4gPiA+ ID4gQ2FuIGFub3RoZXIgaW1wZXJhdGl2ZSB3b3JkaW5nIGJlIGhlbHBmdWwgZm9yIHRoZSBjaGFu Z2UgZGVzY3JpcHRpb24/Cj4gPiA+ID4gPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20v bGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJlZS9Eb2N1bWVudGF0aW9uL3By b2Nlc3Mvc3VibWl0dGluZy1wYXRjaGVzLnJzdD9pZD0xODQ0NWJmNDA1Y2IzMzExMTdiYzk4NDI3 YjFiYTZmMTI0MThhZDE3I24xNTEKPiA+ID4gPiA+IAo+ID4gPiA+ID4gV291bGQgYW4gb3RoZXIg Y29tbWl0IG1lc3NhZ2UgYmUgYSBiaXQgbmljZXI/Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4g PiA+ID4g4oCmCj4gPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3NreTgx NDUyLWJhY2tsaWdodC5jCj4gPiA+ID4gPiA+IEBAIC0yMTcsNiArMjE3LDcgQEAgc3RhdGljIHN0 cnVjdCBza3k4MTQ1Ml9ibF9wbGF0Zm9ybV9kYXRhICpza3k4MTQ1Ml9ibF9wYXJzZV9kdCgKPiA+ ID4gPiA+ID4gIAkJCQkJbnVtX2VudHJ5KTsKPiA+ID4gPiA+ID4gIAkJaWYgKHJldCA8IDApIHsK PiA+ID4gPiA+ID4gIAkJCWRldl9lcnIoZGV2LCAibGVkLXNvdXJjZXMgbm9kZSBpcyBpbnZhbGlk LlxuIik7Cj4gPiA+ID4gPiA+ICsJCQlvZl9ub2RlX3B1dChucCk7Cj4gPiA+ID4gPiA+ICAJCQly ZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+ID4gPiA+ID4gIAkJfQo+ID4gPiA+ID4gCj4gPiA+ ID4gPiBJIHByb3Bvc2UgdG8gYWRkIHRoZSBqdW1wIHRhcmdldCDigJxwdXRfbm9kZeKAnSBzbyB0 aGF0IGEgYml0IG9mIGNvbW1vbiBleGNlcHRpb24KPiA+ID4gPiA+IGhhbmRsaW5nIGNvZGUgY2Fu IGJlIGJldHRlciByZXVzZWQgYXQgdGhlIGVuZCBvZiB0aGlzIGZ1bmN0aW9uIGltcGxlbWVudGF0 aW9uLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBSZWdhcmRzLAo+ID4gPiA+ID4gTWFya3VzCj4gPiA+ ID4gCj4gPiA+ID4gWW91IGNhbiBzYWZlbHkgaWdub3JlIGFueSByZXZpZXcgY29tbWVudHMgZnJv bSBNYXJrdXMhCj4gPiA+ID4gCj4gPiA+ID4gSG93ZXZlciwgdGhpcyBwYXRjaCBkb2Vzbid0IGFw cGVhciB0byBiZSBpbiBteSBpbmJveC4KPiA+ID4gPiAKPiA+ID4gPiBBbnkgaWRlYXMgYXMgdG8g d2h5Pwo+ID4gPiA+IAo+ID4gPiAKPiA+ID4gVGhhbmsgeW91IGZvciB5b3VyIGFkdmljZS4gTXkg b3V0Ym94IHNob3dzIHRoYXQgdGhpcyBwYXRjaAo+ID4gPiBoYXMgcmVhY2hlZCB5b3VyIGVtYWls IHNlcnZlciBzdWNjZXNzZnVsbHkuIE1heWJlIHRoaXMKPiA+ID4gZW5kZWQgdXAgaW4geW91ciBq dW5rIG1haWwgZmlsZT8KPiA+IAo+ID4gVGhpcyBoYXMgaGFwcGVuZWQgcmVjZW50bHksIHNvIEkg d2FzIHN1cmUgdG8gY2hlY2suCj4gPiAKPiA+IE5vdCB0aGVyZSBlaXRoZXIgdW5mb3J0dW5hdGVs eS4KPiA+IAo+ID4gV291bGQgeW91IGJlIGtpbmQgZW5vdWdoIHRvIGJvdW5jZS9yZXNlbmQgcGxl YXNlPwo+IAo+IFN1cmUuCgpMb29rcyBsaWtlIHlvdSBzZW50IGl0ICpvbmx5KiB0byBtZS4gIFBs ZWFzZSBrZWVwIGV2ZXJ5b25lIGVsc2UgaW4gQ2MKd2hlbiBkb2luZyB0aGF0LCBvciBJIGNhbid0 IHJlc3BvbmQgdG8gZXZlcnlvbmUuCgpBbnl3YXksIGJlc2lkZXMgdGhlIHN1YmplY3QgbGluZSAo d2hpY2ggSSBjYW4gZml4IGVhc2lseSksIHRoZSBwYXRjaApsb29rcyBnb29kIHRvIG1lLCBidXQg RGFuaWVsIFQgbXVzdCByZXZpZXcuCgpSZXZpZXdlZC1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNA bGluYXJvLm9yZz4KCi0tCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExl YWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdh cmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 323D6C433E1 for ; Thu, 20 Aug 2020 07:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DE532076E for ; Thu, 20 Aug 2020 07:49:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XlaONjDn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgHTHt3 (ORCPT ); Thu, 20 Aug 2020 03:49:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgHTHtZ (ORCPT ); Thu, 20 Aug 2020 03:49:25 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABFF7C061384 for ; Thu, 20 Aug 2020 00:49:24 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id y3so1059793wrl.4 for ; Thu, 20 Aug 2020 00:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XgD7oAraMYDOqNsfZffx0IqUVAmFZfcgzGRKvwI8mIc=; b=XlaONjDnEdsYg/6xqFFyWyTH0yWrgNaxkmvE+JWcDVZbLe+f/V7HKdjYROy7dyRpgD 0dP7O6uThUl2ocYIR33bisbTsV7PY13WDhwdzpoG+1juP2BKSoKiEUd4Vt3PTFRroRgA CKWIaTIqQLz/3rnEaEMJlfnH2LOTDEFgtejdx0YcZnIibXmUIW8mrTOAvdg1MlPqsu01 n4D3DHqkiUh/PUQcvUhn/MDFi/qLIJr1VljuscrpP3WooR3pcPufopgFHfsC1aJqsMPG YS204VOVM7RsVE5k9miArRNcssfkXrf1ORtWY/QTAhKAThyjJpNspv/DCPSgCLSS8wMB aMUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XgD7oAraMYDOqNsfZffx0IqUVAmFZfcgzGRKvwI8mIc=; b=B5x9U1GvVYQ3DrCztIHQeUiqPy0QS9cbunBxqDrx32XkBDVd7B0X3bIMrzH8hgub8d jOoFlrNTSxMlr6ezJCpoWhylVtrLP5SQmC8Wu+zg7O3l/rNTvy4+xWfH4OYU2aQ9gr6x ApxMXu2tkeI7AXAFDcVZ96JnwJ6XU/yeEFRX4k3khPg16CCZ59TDT/H3v1Zm/nq1VCQ+ jP3+R+IQ5M0A/0uW1XpatEprnnCKKkogss9OpHYvZhmqUgcJDQ73ETfT+sLCPMYt69i7 7021MR2TY/XQy5HoAqNyKkXix6Av51IYWMmpgwMUMaLyxXCORBtAMD/uz+LLub9f1Jg8 lUKQ== X-Gm-Message-State: AOAM531PrywwQS5ZcbTMV35IRrzhcZEL/bnSAUTb8nDLsvQyYu8NOpXN tbezKuRsvcLYEmNAmcKwFnOhBg== X-Google-Smtp-Source: ABdhPJyboEGZAaF6RXm5GpaE/mKR6TYvk3Fye/goK+ikDC5z1N0gxsGJDDrfdepMKqxed6kq885b0w== X-Received: by 2002:a5d:60cb:: with SMTP id x11mr1737733wrt.281.1597909761789; Thu, 20 Aug 2020 00:49:21 -0700 (PDT) Received: from dell ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id s2sm2438068wrr.55.2020.08.20.00.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 00:49:21 -0700 (PDT) Date: Thu, 20 Aug 2020 08:49:16 +0100 From: Lee Jones To: dinghao.liu@zju.edu.cn Cc: Markus Elfring , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bartlomiej Zolnierkiewicz , Bryan Wu , Daniel Thompson , Gyungoh Yoo , Jingoo Han , Kangjie Lu Subject: Re: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-ID: <20200820074916.GE3248864@dell> References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> <20200820062301.GD3248864@dell> <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > > > > > When of_property_read_u32_array() returns an error code, > > > > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > > > > > > > Can another imperative wording be helpful for the change description? > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151 > > > > > > > > > > Would an other commit message be a bit nicer? > > > > > > > > > > > > > > > … > > > > > > +++ b/drivers/video/backlight/sky81452-backlight.c > > > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > > > > > > num_entry); > > > > > > if (ret < 0) { > > > > > > dev_err(dev, "led-sources node is invalid.\n"); > > > > > > + of_node_put(np); > > > > > > return ERR_PTR(-EINVAL); > > > > > > } > > > > > > > > > > I propose to add the jump target “put_node” so that a bit of common exception > > > > > handling code can be better reused at the end of this function implementation. > > > > > > > > > > Regards, > > > > > Markus > > > > > > > > You can safely ignore any review comments from Markus! > > > > > > > > However, this patch doesn't appear to be in my inbox. > > > > > > > > Any ideas as to why? > > > > > > > > > > Thank you for your advice. My outbox shows that this patch > > > has reached your email server successfully. Maybe this > > > ended up in your junk mail file? > > > > This has happened recently, so I was sure to check. > > > > Not there either unfortunately. > > > > Would you be kind enough to bounce/resend please? > > Sure. Looks like you sent it *only* to me. Please keep everyone else in Cc when doing that, or I can't respond to everyone. Anyway, besides the subject line (which I can fix easily), the patch looks good to me, but Daniel T must review. Reviewed-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog