From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Thu, 20 Aug 2020 07:49:32 +0000 Subject: Re: [PATCH RESEND] lib/fonts: add font 6x8 for oled display Message-Id: <20200820074932.GA3834397@kroah.com> List-Id: References: <20200820074214.30214-1-s.hauer@pengutronix.de> In-Reply-To: <20200820074214.30214-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sascha Hauer Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, kernel@pengutronix.de, Bartlomiej Zolnierkiewicz , Sven Schneider On Thu, Aug 20, 2020 at 09:42:14AM +0200, Sascha Hauer wrote: > From: Sven Schneider > > This font is derived from lib/fonts/font_6x10.c and is useful for small OLED > displays. > --- > No signed-off-by: line? :( Always use scripts/checkpatch.pl on your patch to find stuff like this, and other errors that this patch has. > Hi All, > > I am not sure any new fonts are desired in the kernel. If yes, please consider > for inclusion, otherwise some "go away, there are enough fonts in the kernel > already" would be nice as well so I can stop trying getting it in :) > > Sascha > > include/linux/font.h | 4 +- > lib/fonts/Kconfig | 7 + > lib/fonts/Makefile | 1 + > lib/fonts/font_6x8.c | 2575 ++++++++++++++++++++++++++++++++++++++++++ > lib/fonts/fonts.c | 3 + > 5 files changed, 2589 insertions(+), 1 deletion(-) > mode change 100644 => 100755 include/linux/font.h You changed a .h file to be executable??? > diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c > index e7258d8c252b2..760f2e6893bdb 100644 > --- a/lib/fonts/fonts.c > +++ b/lib/fonts/fonts.c > @@ -57,6 +57,9 @@ static const struct font_desc *fonts[] = { > #ifdef CONFIG_FONT_TER16x32 > &font_ter_16x32, > #endif > +#ifdef CONFIG_FONT_6x8 > + &font_6x8, Tabs please. As for "do we take new fonts?", sure, why not? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3C0C433DF for ; Thu, 20 Aug 2020 07:49:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B937208A9 for ; Thu, 20 Aug 2020 07:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597909754; bh=VINLwS3DBjghohvueceeLnHG2G40JRtPDdK6W1zz2MU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oe5qJUkDKjUOnYAzXbFj9iOY2Om5HSrNf9NTYM/L4wxDsIytqYfaNzjn3/Hwi2WKh v6TBA2Qh/WNzSQbkHhis/B5/tCx8n5w4eqIuS1UAmut9vAFTNii3I8WcjlhDGoVF49 BxVRPMuF79qdX4AIpmYOI3MCfdQ6/QQMfuNwkBgU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbgHTHtN (ORCPT ); Thu, 20 Aug 2020 03:49:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:59436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgHTHtM (ORCPT ); Thu, 20 Aug 2020 03:49:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD8062076E; Thu, 20 Aug 2020 07:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597909752; bh=VINLwS3DBjghohvueceeLnHG2G40JRtPDdK6W1zz2MU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HvHATzEchtfziuqRwibKGmT2Pe3qxv2LBDdYEhnfFaUe31O+UlnlTUzKQXX1XCWe/ /XO9uk1XnOE8+hvmilJoLLvMedmH/mzJ3avUmH/KYhCn4u0PTc9Me7lg2GPH7gV0a2 5sllFoN/fTZJFF2MS0DgS5AY43cjoTtJj10+cgGw= Date: Thu, 20 Aug 2020 09:49:32 +0200 From: Greg Kroah-Hartman To: Sascha Hauer Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, kernel@pengutronix.de, Bartlomiej Zolnierkiewicz , Sven Schneider Subject: Re: [PATCH RESEND] lib/fonts: add font 6x8 for oled display Message-ID: <20200820074932.GA3834397@kroah.com> References: <20200820074214.30214-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200820074214.30214-1-s.hauer@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2020 at 09:42:14AM +0200, Sascha Hauer wrote: > From: Sven Schneider > > This font is derived from lib/fonts/font_6x10.c and is useful for small OLED > displays. > --- > No signed-off-by: line? :( Always use scripts/checkpatch.pl on your patch to find stuff like this, and other errors that this patch has. > Hi All, > > I am not sure any new fonts are desired in the kernel. If yes, please consider > for inclusion, otherwise some "go away, there are enough fonts in the kernel > already" would be nice as well so I can stop trying getting it in :) > > Sascha > > include/linux/font.h | 4 +- > lib/fonts/Kconfig | 7 + > lib/fonts/Makefile | 1 + > lib/fonts/font_6x8.c | 2575 ++++++++++++++++++++++++++++++++++++++++++ > lib/fonts/fonts.c | 3 + > 5 files changed, 2589 insertions(+), 1 deletion(-) > mode change 100644 => 100755 include/linux/font.h You changed a .h file to be executable??? > diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c > index e7258d8c252b2..760f2e6893bdb 100644 > --- a/lib/fonts/fonts.c > +++ b/lib/fonts/fonts.c > @@ -57,6 +57,9 @@ static const struct font_desc *fonts[] = { > #ifdef CONFIG_FONT_TER16x32 > &font_ter_16x32, > #endif > +#ifdef CONFIG_FONT_6x8 > + &font_6x8, Tabs please. As for "do we take new fonts?", sure, why not? thanks, greg k-h