From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFDDCC433DF for ; Thu, 20 Aug 2020 10:28:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6CC020658 for ; Thu, 20 Aug 2020 10:28:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597919284; bh=EswYEP1MjfhPI3zy/KtXIpFzZ0T4117tNDO/MqZBlGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tcGGyPOjuG7q/xyKkyBVOjO2nOj8jc7a/lVlqh7CPmtV7bXTZiQpDEeIZBl2Sac36 vr6TFT4IF6D4anOIJyP9Fs7K6AlQx3V0g3HAflA9MSfqA07m/iOP+jXI/ifu5+YrvY xHsM0P+fV7VzLOWozh6d+fp8bRJAdIjBjxH4VU0M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731680AbgHTK2B (ORCPT ); Thu, 20 Aug 2020 06:28:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:50258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731460AbgHTKWZ (ORCPT ); Thu, 20 Aug 2020 06:22:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 602C82072D; Thu, 20 Aug 2020 10:22:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918944; bh=EswYEP1MjfhPI3zy/KtXIpFzZ0T4117tNDO/MqZBlGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QfLMz2hksIWiELwTFjez9tSnOZjP265jy03jPGWKSNDeEIk3MI0VzIcBNGp0Yuijq rW3VF6IyK+05pqkIDmcI8PkFVZsbyRRoVWCoXYdYkEnyhYq+UnyMXDPJAOxC6Je/Hz XcypFOnA3xZffBjXhJ+pynEfZNLmyJ5PVsV1bhgI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan McDowell , "David S. Miller" Subject: [PATCH 4.4 124/149] net: ethernet: stmmac: Disable hardware multicast filter Date: Thu, 20 Aug 2020 11:23:21 +0200 Message-Id: <20200820092131.711815907@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820092125.688850368@linuxfoundation.org> References: <20200820092125.688850368@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan McDowell commit df43dd526e6609769ae513a81443c7aa727c8ca3 upstream. The IPQ806x does not appear to have a functional multicast ethernet address filter. This was observed as a failure to correctly receive IPv6 packets on a LAN to the all stations address. Checking the vendor driver shows that it does not attempt to enable the multicast filter and instead falls back to receiving all multicast packets, internally setting ALLMULTI. Use the new fallback support in the dwmac1000 driver to correctly achieve the same with the mainline IPQ806x driver. Confirmed to fix IPv6 functionality on an RB3011 router. Cc: stable@vger.kernel.org Signed-off-by: Jonathan McDowell Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c @@ -360,6 +360,7 @@ static int ipq806x_gmac_probe(struct pla plat_dat->has_gmac = true; plat_dat->bsp_priv = gmac; plat_dat->fix_mac_speed = ipq806x_gmac_fix_mac_speed; + plat_dat->multicast_filter_bins = 0; return stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); }