From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A657C433DF for ; Thu, 20 Aug 2020 11:37:53 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0213207BB for ; Thu, 20 Aug 2020 11:37:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="USgWkIUa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0213207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7BC911353296D; Thu, 20 Aug 2020 04:37:52 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=216.71.145.142; helo=esa1.hc3370-68.iphmx.com; envelope-from=roger.pau@citrix.com; receiver= Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C3EE31353296A for ; Thu, 20 Aug 2020 04:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597923470; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ZAirrqoSKLQOVqqJWBpKueJlrlW7WlH8PvguimBoqcg=; b=USgWkIUa7F4+BEqsBiUuWl8Ky2/SRO+RkRMBNd1B8xwhlWeo/jjUm5Sa Up9mPHwu33dnpjz09eKVzNIMJ7yeylSn9iXidQINTH+00MIEsHTZzmPY3 pgCKphBTBN1Ypod3YZs8whiOY7hEPzofDUMprdyLMskMp9jRxXMQRRTaE 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 4nBaFLnRpBD3ly5eX58Un7Lg/gZ5xsv5/Atyb5KJyqp4Du0CE2K9eo3l0sHk6/iSuj0LcBplRs py/XsJnWH7CdQGPSyE9v0yfz1MTNlSBZRIqxId7A4BgJJP378Gr9g+yK8exusIK58eq7+ig1yE VMXT2qTxtvv93zngpqJ42vMERlxiMlDzOz7+ksKh5LNya7cBceZYtkNHTRCz2Wl8K1LVGTgB08 DLgsy5wuMhnM/QCgRFDIz9M8mSd0hyZIKVqkd/EUnPb0uRZumstAnrPk+F9aHn+BCzwywOcY8+ faw= X-SBRS: 2.7 X-MesageID: 25271840 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,332,1592884800"; d="scan'208";a="25271840" Date: Thu, 20 Aug 2020 13:37:41 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Dan Williams Subject: Re: [PATCH v4 1/2] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC Message-ID: <20200820113741.GV828@Air-de-Roger> References: <20200811094447.31208-1-roger.pau@citrix.com> <20200811094447.31208-2-roger.pau@citrix.com> <96e34f77-8f55-d8a2-4d1f-4f4b667b0472@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <96e34f77-8f55-d8a2-4d1f-4f4b667b0472@redhat.com> X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) Message-ID-Hash: LVZDD3HDCVTBRSKXBZ3WTKQPL6DKXN4O X-Message-ID-Hash: LVZDD3HDCVTBRSKXBZ3WTKQPL6DKXN4O X-MailFrom: roger.pau@citrix.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jason Gunthorpe , "Aneesh Kumar K.V" , "Logan Gunthorpe , ," , linux-mm@kvack.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: base64 T24gVHVlLCBBdWcgMTEsIDIwMjAgYXQgMTE6MDc6MzZQTSArMDIwMCwgRGF2aWQgSGlsZGVuYnJh bmQgd3JvdGU6DQo+IE9uIDExLjA4LjIwIDExOjQ0LCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6DQo+ ID4gVGhpcyBpcyBpbiBwcmVwYXJhdGlvbiBmb3IgdGhlIGxvZ2ljIGJlaGluZCBNRU1PUllfREVW SUNFX0RFVkRBWCBhbHNvDQo+ID4gYmVpbmcgdXNlZCBieSBub24gREFYIGRldmljZXMuDQo+ID4g DQo+ID4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UgaW50ZW5kZWQuDQo+ID4gDQo+ID4gU2lnbmVkLW9m Zi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+ID4gLS0tDQo+ ID4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPg0KPiA+IENjOiBW aXNoYWwgVmVybWEgPHZpc2hhbC5sLnZlcm1hQGludGVsLmNvbT4NCj4gPiBDYzogRGF2ZSBKaWFu ZyA8ZGF2ZS5qaWFuZ0BpbnRlbC5jb20+DQo+ID4gQ2M6IEFuZHJldyBNb3J0b24gPGFrcG1AbGlu dXgtZm91bmRhdGlvbi5vcmc+DQo+ID4gQ2M6IEphc29uIEd1bnRob3JwZSA8amdnQHppZXBlLmNh Pg0KPiA+IENjOiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+DQo+ID4gQ2M6ICJBbmVl c2ggS3VtYXIgSy5WIiA8YW5lZXNoLmt1bWFyQGxpbnV4LmlibS5jb20+DQo+ID4gQ2M6IEpvaGFu bmVzIFRodW1zaGlybiA8anRodW1zaGlybkBzdXNlLmRlPg0KPiA+IENjOiBMb2dhbiBHdW50aG9y cGUgPGxvZ2FuZ0BkZWx0YXRlZS5jb20+DQo+ID4gQ2M6IGxpbnV4LW52ZGltbUBsaXN0cy4wMS5v cmcNCj4gPiBDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+ID4gQ2M6IGxpbnV4 LW1tQGt2YWNrLm9yZw0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL2RheC9kZXZpY2UuYyAgICAgfCAy ICstDQo+ID4gIGluY2x1ZGUvbGludXgvbWVtcmVtYXAuaCB8IDkgKysrKy0tLS0tDQo+ID4gIG1t L21lbXJlbWFwLmMgICAgICAgICAgICB8IDIgKy0NCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCA2IGlu c2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZGF4L2RldmljZS5jIGIvZHJpdmVycy9kYXgvZGV2aWNlLmMNCj4gPiBpbmRleCA0YzBhZjJl YjdlMTkuLjFlODk1MTNmM2M1OSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2RheC9kZXZpY2Uu Yw0KPiA+ICsrKyBiL2RyaXZlcnMvZGF4L2RldmljZS5jDQo+ID4gQEAgLTQyOSw3ICs0MjksNyBA QCBpbnQgZGV2X2RheF9wcm9iZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+ID4gIAkJcmV0dXJuIC1F QlVTWTsNCj4gPiAgCX0NCj4gPiAgDQo+ID4gLQlkZXZfZGF4LT5wZ21hcC50eXBlID0gTUVNT1JZ X0RFVklDRV9ERVZEQVg7DQo+ID4gKwlkZXZfZGF4LT5wZ21hcC50eXBlID0gTUVNT1JZX0RFVklD RV9HRU5FUklDOw0KPiA+ICAJYWRkciA9IGRldm1fbWVtcmVtYXBfcGFnZXMoZGV2LCAmZGV2X2Rh eC0+cGdtYXApOw0KPiA+ICAJaWYgKElTX0VSUihhZGRyKSkNCj4gPiAgCQlyZXR1cm4gUFRSX0VS UihhZGRyKTsNCj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9tZW1yZW1hcC5oIGIvaW5j bHVkZS9saW51eC9tZW1yZW1hcC5oDQo+ID4gaW5kZXggNWY1YjJkZjA2ZTYxLi5lNTg2Mjc0Njc1 MWIgMTAwNjQ0DQo+ID4gLS0tIGEvaW5jbHVkZS9saW51eC9tZW1yZW1hcC5oDQo+ID4gKysrIGIv aW5jbHVkZS9saW51eC9tZW1yZW1hcC5oDQo+ID4gQEAgLTQ2LDExICs0NiwxMCBAQCBzdHJ1Y3Qg dm1lbV9hbHRtYXAgew0KPiA+ICAgKiB3YWtldXAgaXMgdXNlZCB0byBjb29yZGluYXRlIHBoeXNp Y2FsIGFkZHJlc3Mgc3BhY2UgbWFuYWdlbWVudCAoZXg6DQo+ID4gICAqIGZzIHRydW5jYXRlL2hv bGUgcHVuY2gpIHZzIHBpbm5lZCBwYWdlcyAoZXg6IGRldmljZSBkbWEpLg0KPiA+ICAgKg0KPiA+ IC0gKiBNRU1PUllfREVWSUNFX0RFVkRBWDoNCj4gPiArICogTUVNT1JZX0RFVklDRV9HRU5FUklD Og0KPiA+ICAgKiBIb3N0IG1lbW9yeSB0aGF0IGhhcyBzaW1pbGFyIGFjY2VzcyBzZW1hbnRpY3Mg YXMgU3lzdGVtIFJBTSBpLmUuIERNQQ0KPiA+IC0gKiBjb2hlcmVudCBhbmQgc3VwcG9ydHMgcGFn ZSBwaW5uaW5nLiBJbiBjb250cmFzdCB0bw0KPiA+IC0gKiBNRU1PUllfREVWSUNFX0ZTX0RBWCwg dGhpcyBtZW1vcnkgaXMgYWNjZXNzIHZpYSBhIGRldmljZS1kYXgNCj4gPiAtICogY2hhcmFjdGVy IGRldmljZS4NCj4gPiArICogY29oZXJlbnQgYW5kIHN1cHBvcnRzIHBhZ2UgcGlubmluZy4gVGhp cyBpcyBmb3IgZXhhbXBsZSB1c2VkIGJ5IERBWCBkZXZpY2VzDQo+ID4gKyAqIHRoYXQgZXhwb3Nl IG1lbW9yeSB1c2luZyBhIGNoYXJhY3RlciBkZXZpY2UuDQo+ID4gICAqDQo+ID4gICAqIE1FTU9S WV9ERVZJQ0VfUENJX1AyUERNQToNCj4gPiAgICogRGV2aWNlIG1lbW9yeSByZXNpZGluZyBpbiBh IFBDSSBCQVIgaW50ZW5kZWQgZm9yIHVzZSB3aXRoIFBlZXItdG8tUGVlcg0KPiA+IEBAIC02MCw3 ICs1OSw3IEBAIGVudW0gbWVtb3J5X3R5cGUgew0KPiA+ICAJLyogMCBpcyByZXNlcnZlZCB0byBj YXRjaCB1bmluaXRpYWxpemVkIHR5cGUgZmllbGRzICovDQo+ID4gIAlNRU1PUllfREVWSUNFX1BS SVZBVEUgPSAxLA0KPiA+ICAJTUVNT1JZX0RFVklDRV9GU19EQVgsDQo+ID4gLQlNRU1PUllfREVW SUNFX0RFVkRBWCwNCj4gPiArCU1FTU9SWV9ERVZJQ0VfR0VORVJJQywNCj4gPiAgCU1FTU9SWV9E RVZJQ0VfUENJX1AyUERNQSwNCj4gPiAgfTsNCj4gPiAgDQo+ID4gZGlmZiAtLWdpdCBhL21tL21l bXJlbWFwLmMgYi9tbS9tZW1yZW1hcC5jDQo+ID4gaW5kZXggMDNlMzhiN2EzOGYxLi4wMDZkYWNl NjBiMWEgMTAwNjQ0DQo+ID4gLS0tIGEvbW0vbWVtcmVtYXAuYw0KPiA+ICsrKyBiL21tL21lbXJl bWFwLmMNCj4gPiBAQCAtMjE2LDcgKzIxNiw3IEBAIHZvaWQgKm1lbXJlbWFwX3BhZ2VzKHN0cnVj dCBkZXZfcGFnZW1hcCAqcGdtYXAsIGludCBuaWQpDQo+ID4gIAkJCXJldHVybiBFUlJfUFRSKC1F SU5WQUwpOw0KPiA+ICAJCX0NCj4gPiAgCQlicmVhazsNCj4gPiAtCWNhc2UgTUVNT1JZX0RFVklD RV9ERVZEQVg6DQo+ID4gKwljYXNlIE1FTU9SWV9ERVZJQ0VfR0VORVJJQzoNCj4gPiAgCQluZWVk X2Rldm1hcF9tYW5hZ2VkID0gZmFsc2U7DQo+ID4gIAkJYnJlYWs7DQo+ID4gIAljYXNlIE1FTU9S WV9ERVZJQ0VfUENJX1AyUERNQToNCj4gPiANCj4gDQo+IE5vIHN0cm9uZyBvcGluaW9uIChARGFu PyksIEkgZG8gd29uZGVyIGlmIGEgc2VwYXJhdGUgdHlwZSB3b3VsZCBtYWtlIHNlbnNlLg0KDQpH ZW50bGUgcGluZy4NCg0KVGhhbmtzLCBSb2dlci4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdCAtLSBsaW51eC1u dmRpbW1AbGlzdHMuMDEub3JnClRvIHVuc3Vic2NyaWJlIHNlbmQgYW4gZW1haWwgdG8gbGludXgt bnZkaW1tLWxlYXZlQGxpc3RzLjAxLm9yZwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 595EDC433E1 for ; Thu, 20 Aug 2020 11:38:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AC87204EA for ; Thu, 20 Aug 2020 11:38:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="USgWkIUa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AC87204EA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k8itE-0002B9-Cx; Thu, 20 Aug 2020 11:37:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k8itD-0002B4-Gw for xen-devel@lists.xenproject.org; Thu, 20 Aug 2020 11:37:51 +0000 X-Inumbo-ID: d0df7adf-1f1a-4a3a-b116-d3aba8c6fae4 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d0df7adf-1f1a-4a3a-b116-d3aba8c6fae4; Thu, 20 Aug 2020 11:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597923470; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ZAirrqoSKLQOVqqJWBpKueJlrlW7WlH8PvguimBoqcg=; b=USgWkIUa7F4+BEqsBiUuWl8Ky2/SRO+RkRMBNd1B8xwhlWeo/jjUm5Sa Up9mPHwu33dnpjz09eKVzNIMJ7yeylSn9iXidQINTH+00MIEsHTZzmPY3 pgCKphBTBN1Ypod3YZs8whiOY7hEPzofDUMprdyLMskMp9jRxXMQRRTaE 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 4nBaFLnRpBD3ly5eX58Un7Lg/gZ5xsv5/Atyb5KJyqp4Du0CE2K9eo3l0sHk6/iSuj0LcBplRs py/XsJnWH7CdQGPSyE9v0yfz1MTNlSBZRIqxId7A4BgJJP378Gr9g+yK8exusIK58eq7+ig1yE VMXT2qTxtvv93zngpqJ42vMERlxiMlDzOz7+ksKh5LNya7cBceZYtkNHTRCz2Wl8K1LVGTgB08 DLgsy5wuMhnM/QCgRFDIz9M8mSd0hyZIKVqkd/EUnPb0uRZumstAnrPk+F9aHn+BCzwywOcY8+ faw= X-SBRS: 2.7 X-MesageID: 25271840 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,332,1592884800"; d="scan'208";a="25271840" Date: Thu, 20 Aug 2020 13:37:41 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Dan Williams CC: , David Hildenbrand , Vishal Verma , Dave Jiang , Andrew Morton , Jason Gunthorpe , Ira Weiny , Aneesh Kumar K.V , Johannes Thumshirn , "Logan Gunthorpe" , , , Subject: Re: [PATCH v4 1/2] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC Message-ID: <20200820113741.GV828@Air-de-Roger> References: <20200811094447.31208-1-roger.pau@citrix.com> <20200811094447.31208-2-roger.pau@citrix.com> <96e34f77-8f55-d8a2-4d1f-4f4b667b0472@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <96e34f77-8f55-d8a2-4d1f-4f4b667b0472@redhat.com> X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Aug 11, 2020 at 11:07:36PM +0200, David Hildenbrand wrote: > On 11.08.20 11:44, Roger Pau Monne wrote: > > This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also > > being used by non DAX devices. > > > > No functional change intended. > > > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Dan Williams > > Cc: Vishal Verma > > Cc: Dave Jiang > > Cc: Andrew Morton > > Cc: Jason Gunthorpe > > Cc: Ira Weiny > > Cc: "Aneesh Kumar K.V" > > Cc: Johannes Thumshirn > > Cc: Logan Gunthorpe > > Cc: linux-nvdimm@lists.01.org > > Cc: xen-devel@lists.xenproject.org > > Cc: linux-mm@kvack.org > > --- > > drivers/dax/device.c | 2 +- > > include/linux/memremap.h | 9 ++++----- > > mm/memremap.c | 2 +- > > 3 files changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/dax/device.c b/drivers/dax/device.c > > index 4c0af2eb7e19..1e89513f3c59 100644 > > --- a/drivers/dax/device.c > > +++ b/drivers/dax/device.c > > @@ -429,7 +429,7 @@ int dev_dax_probe(struct device *dev) > > return -EBUSY; > > } > > > > - dev_dax->pgmap.type = MEMORY_DEVICE_DEVDAX; > > + dev_dax->pgmap.type = MEMORY_DEVICE_GENERIC; > > addr = devm_memremap_pages(dev, &dev_dax->pgmap); > > if (IS_ERR(addr)) > > return PTR_ERR(addr); > > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > > index 5f5b2df06e61..e5862746751b 100644 > > --- a/include/linux/memremap.h > > +++ b/include/linux/memremap.h > > @@ -46,11 +46,10 @@ struct vmem_altmap { > > * wakeup is used to coordinate physical address space management (ex: > > * fs truncate/hole punch) vs pinned pages (ex: device dma). > > * > > - * MEMORY_DEVICE_DEVDAX: > > + * MEMORY_DEVICE_GENERIC: > > * Host memory that has similar access semantics as System RAM i.e. DMA > > - * coherent and supports page pinning. In contrast to > > - * MEMORY_DEVICE_FS_DAX, this memory is access via a device-dax > > - * character device. > > + * coherent and supports page pinning. This is for example used by DAX devices > > + * that expose memory using a character device. > > * > > * MEMORY_DEVICE_PCI_P2PDMA: > > * Device memory residing in a PCI BAR intended for use with Peer-to-Peer > > @@ -60,7 +59,7 @@ enum memory_type { > > /* 0 is reserved to catch uninitialized type fields */ > > MEMORY_DEVICE_PRIVATE = 1, > > MEMORY_DEVICE_FS_DAX, > > - MEMORY_DEVICE_DEVDAX, > > + MEMORY_DEVICE_GENERIC, > > MEMORY_DEVICE_PCI_P2PDMA, > > }; > > > > diff --git a/mm/memremap.c b/mm/memremap.c > > index 03e38b7a38f1..006dace60b1a 100644 > > --- a/mm/memremap.c > > +++ b/mm/memremap.c > > @@ -216,7 +216,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) > > return ERR_PTR(-EINVAL); > > } > > break; > > - case MEMORY_DEVICE_DEVDAX: > > + case MEMORY_DEVICE_GENERIC: > > need_devmap_managed = false; > > break; > > case MEMORY_DEVICE_PCI_P2PDMA: > > > > No strong opinion (@Dan?), I do wonder if a separate type would make sense. Gentle ping. Thanks, Roger.