From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf v2] netfilter: conntrack: allow sctp hearbeat after connection re-use
Date: Thu, 20 Aug 2020 14:14:08 +0200 [thread overview]
Message-ID: <20200820121408.GA25211@salvia> (raw)
In-Reply-To: <20200818141558.24232-1-fw@strlen.de>
On Tue, Aug 18, 2020 at 04:15:58PM +0200, Florian Westphal wrote:
> If an sctp connection gets re-used, heartbeats are flagged as invalid
> because their vtag doesn't match.
>
> Handle this in a similar way as TCP conntrack when it suspects that the
> endpoints and conntrack are out-of-sync.
>
> When a HEARTBEAT request fails its vtag validation, flag this in the
> conntrack state and accept the packet.
>
> When a HEARTBEAT_ACK is received with an invalid vtag in the reverse
> direction after we allowed such a HEARTBEAT through, assume we are
> out-of-sync and re-set the vtag info.
>
> v2: remove left-over snippet from an older incarnation that moved
> new_state/old_state assignments, thats not needed so keep that
> as-is.
Applied, thanks.
prev parent reply other threads:[~2020-08-20 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 14:15 [PATCH nf v2] netfilter: conntrack: allow sctp hearbeat after connection re-use Florian Westphal
2020-08-20 12:14 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820121408.GA25211@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.