From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE19C433DF for ; Thu, 20 Aug 2020 15:53:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E4C522D2C for ; Thu, 20 Aug 2020 15:53:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E4C522D2C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 519386E398; Thu, 20 Aug 2020 15:53:07 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 895D06E398 for ; Thu, 20 Aug 2020 15:53:06 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 410C580503; Thu, 20 Aug 2020 17:53:03 +0200 (CEST) Date: Thu, 20 Aug 2020 17:53:02 +0200 From: Sam Ravnborg To: Paul Cercueil Subject: Re: [PATCH v2 1/2] drm/panel: novatek, nt39016: Reorder calls in probe Message-ID: <20200820155302.GA194134@ravnborg.org> References: <20200820121256.32037-1-paul@crapouillou.net> <20200820121256.32037-2-paul@crapouillou.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200820121256.32037-2-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=LjHVGngA6e6DaZ_9Yd0A:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thierry Reding , od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Aug 20, 2020 at 02:12:55PM +0200, Paul Cercueil wrote: > The drm_panel_of_backlight() function must be called after > drm_panel_init(), according to the function's documentation; otherwise > the backlight won't be properly initialized. > > v2: New patch > > Signed-off-by: Paul Cercueil Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-novatek-nt39016.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/panel-novatek-nt39016.c > index 39f7be679da5..daa583030246 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c > @@ -285,6 +285,9 @@ static int nt39016_probe(struct spi_device *spi) > return PTR_ERR(panel->map); > } > > + drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs, > + DRM_MODE_CONNECTOR_DPI); > + > err = drm_panel_of_backlight(&panel->drm_panel); > if (err) { > if (err != -EPROBE_DEFER) > @@ -292,9 +295,6 @@ static int nt39016_probe(struct spi_device *spi) > return err; > } > > - drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs, > - DRM_MODE_CONNECTOR_DPI); > - > drm_panel_add(&panel->drm_panel); > > return 0; > -- > 2.28.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA29C433DF for ; Thu, 20 Aug 2020 15:53:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7C7322D2C for ; Thu, 20 Aug 2020 15:53:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729465AbgHTPxI (ORCPT ); Thu, 20 Aug 2020 11:53:08 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:48410 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728549AbgHTPxH (ORCPT ); Thu, 20 Aug 2020 11:53:07 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 410C580503; Thu, 20 Aug 2020 17:53:03 +0200 (CEST) Date: Thu, 20 Aug 2020 17:53:02 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: Thierry Reding , od@zcrc.me, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] drm/panel: novatek,nt39016: Reorder calls in probe Message-ID: <20200820155302.GA194134@ravnborg.org> References: <20200820121256.32037-1-paul@crapouillou.net> <20200820121256.32037-2-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200820121256.32037-2-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=LjHVGngA6e6DaZ_9Yd0A:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2020 at 02:12:55PM +0200, Paul Cercueil wrote: > The drm_panel_of_backlight() function must be called after > drm_panel_init(), according to the function's documentation; otherwise > the backlight won't be properly initialized. > > v2: New patch > > Signed-off-by: Paul Cercueil Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-novatek-nt39016.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/panel-novatek-nt39016.c > index 39f7be679da5..daa583030246 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c > @@ -285,6 +285,9 @@ static int nt39016_probe(struct spi_device *spi) > return PTR_ERR(panel->map); > } > > + drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs, > + DRM_MODE_CONNECTOR_DPI); > + > err = drm_panel_of_backlight(&panel->drm_panel); > if (err) { > if (err != -EPROBE_DEFER) > @@ -292,9 +295,6 @@ static int nt39016_probe(struct spi_device *spi) > return err; > } > > - drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs, > - DRM_MODE_CONNECTOR_DPI); > - > drm_panel_add(&panel->drm_panel); > > return 0; > -- > 2.28.0