From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFB3C433E1 for ; Thu, 20 Aug 2020 16:32:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F1D1207DE for ; Thu, 20 Aug 2020 16:32:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="iM9wJddg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F1D1207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7D3F58D0038; Thu, 20 Aug 2020 12:32:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 784F68D0001; Thu, 20 Aug 2020 12:32:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C2028D0038; Thu, 20 Aug 2020 12:32:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 55D6F8D0001 for ; Thu, 20 Aug 2020 12:32:07 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 062BA181AC9C6 for ; Thu, 20 Aug 2020 16:32:07 +0000 (UTC) X-FDA: 77171489094.25.fork74_0b03aa627032 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id A1EA91804EA7C for ; Thu, 20 Aug 2020 16:31:46 +0000 (UTC) X-HE-Tag: fork74_0b03aa627032 X-Filterd-Recvd-Size: 2479 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 16:31:46 +0000 (UTC) Received: from kernel.org (unknown [87.70.91.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 457A92054F; Thu, 20 Aug 2020 16:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597941105; bh=zKshuG67u0neBiV2f+UNp4wq9lueh8JEmIh5e3uPpXo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iM9wJddgOPrLRRmD/eR++hu7vPazQ/1YJpjRnS4NABOuSoe0wTRuArf02stQhI7ef fBz57nVzuOb7xjge1sr3YTEYgkdFx98PEJoZs3+NC2yXYlWL312t2BJxEhkxQGTXBg yEyFgtpGOalfZE41VHDVKXV6TkMxSyTnCm9XxlWg= Date: Thu, 20 Aug 2020 19:31:38 +0300 From: Mike Rapoport To: ira.weiny@intel.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/highmem: Clean up endif comments Message-ID: <20200820163138.GC752365@kernel.org> References: <20200819184635.112579-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819184635.112579-1-ira.weiny@intel.com> X-Rspamd-Queue-Id: A1EA91804EA7C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000346, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 19, 2020 at 11:46:35AM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The #endif at the end of the file matches up with the '#if > defined(HASHED_PAGE_VIRTUAL)' on line 374. Not the CONFIG_HIGHMEM #if > earlier. > > Fix comments on both of the #endif's to indicate the correct end of > blocks for each. > > Signed-off-by: Ira Weiny Reviewed-by: Mike Rapoport > --- > mm/highmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/highmem.c b/mm/highmem.c > index 64d8dea47dd1..1352a27951e3 100644 > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -369,7 +369,7 @@ void kunmap_high(struct page *page) > } > > EXPORT_SYMBOL(kunmap_high); > -#endif > +#endif /* CONFIG_HIGHMEM */ > > #if defined(HASHED_PAGE_VIRTUAL) > > @@ -481,4 +481,4 @@ void __init page_address_init(void) > } > } > > -#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */ > +#endif /* defined(HASHED_PAGE_VIRTUAL) */ > -- > 2.25.1 > > -- Sincerely yours, Mike.