From: Mark Brown <broonie@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, joel@jms.id.au,
bradleyb@fuzziesquirrel.com, robh+dt@kernel.org, arnd@arndb.de
Subject: Re: [PATCH 5/7] spi: fsi: Implement restricted size for certain controllers
Date: Thu, 20 Aug 2020 18:19:03 +0100 [thread overview]
Message-ID: <20200820171903.GI5854@sirena.org.uk> (raw)
In-Reply-To: <20200820170228.42053-6-eajames@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
On Thu, Aug 20, 2020 at 12:02:26PM -0500, Eddie James wrote:
> Some of the FSI-attached SPI controllers cannot use the loop command in
> programming the sequencer due to security requirements. Add a boolean
> devicetree property that describes this condition and restrict the
> size for these controllers. Also, add more transfers directly in the
> sequence up to the length of the sequence register.
If there is one difference between implementations of the controller
there are likely to be more - why have a property here rather than use
compatible strings for the different hardware variants? Compatible
strings mean that as more differences are discovered existing DTs
continue to work.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-20 17:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 17:02 [PATCH 0/7] spi: Fix FSI-attached controller and AT25 drivers Eddie James
2020-08-20 17:02 ` [PATCH 1/7] spi: fsi: Handle 9 to 15 byte transfers lengths Eddie James
2020-08-20 17:02 ` [PATCH 2/7] spi: fsi: Fix clock running too fast Eddie James
2020-08-20 17:12 ` Mark Brown
2020-08-20 21:06 ` Eddie James
2020-08-25 7:10 ` Joel Stanley
2020-08-20 17:02 ` [PATCH 3/7] spi: fsi: Fix use of the bneq+ sequencer instruction Eddie James
2020-08-20 17:02 ` [PATCH 4/7] dt-bindings: fsi: fsi2spi: Document new restricted property Eddie James
2020-08-20 17:14 ` Mark Brown
2020-08-20 21:07 ` Eddie James
2020-08-21 12:03 ` Mark Brown
2020-09-08 20:44 ` Rob Herring
2020-08-20 17:02 ` [PATCH 5/7] spi: fsi: Implement restricted size for certain controllers Eddie James
2020-08-20 17:19 ` Mark Brown [this message]
2020-08-20 17:02 ` [PATCH 6/7] spi: fsi: Check mux status before transfers Eddie James
2020-08-20 17:02 ` [PATCH 7/7] eeprom: at25: Split reads into chunks and cap write size Eddie James
2020-08-20 17:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820171903.GI5854@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=bradleyb@fuzziesquirrel.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.