From: Antony Antony <antony.antony@secunet.com>
To: Steffen Klassert <steffen.klassert@secunet.com>,
<netdev@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Antony Antony <antony@phenome.org>,
Antony Antony <antony.antony@secunet.com>
Subject: [PATCH 3/3] xfrm: clone XFRMA_SEC_CTX during xfrm_do_migrate
Date: Thu, 20 Aug 2020 20:16:08 +0200 [thread overview]
Message-ID: <20200820181608.GA19772@moon.secunet.de> (raw)
In-Reply-To: 20200820181158.GA19658@moon.secunet.de
XFRMA_SEC_CTX was not cloned from the old to the new.
Migrate this attribute during XFRMA_MSG_MIGRATE
Signed-off-by: Antony Antony <antony.antony@secunet.com>
---
net/xfrm/xfrm_state.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 20a12c67a931..dbcb71b800b8 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -1441,6 +1441,30 @@ int xfrm_state_add(struct xfrm_state *x)
EXPORT_SYMBOL(xfrm_state_add);
#ifdef CONFIG_XFRM_MIGRATE
+static inline bool clone_security(struct xfrm_state *x, struct xfrm_sec_ctx *security)
+{
+ struct xfrm_user_sec_ctx *uctx;
+ int size = sizeof(*uctx) + security->ctx_len;
+ int err;
+
+ uctx = kmalloc(size, GFP_KERNEL);
+ if (!uctx)
+ return true;
+
+ uctx->exttype = XFRMA_SEC_CTX;
+ uctx->len = size;
+ uctx->ctx_doi = security->ctx_doi;
+ uctx->ctx_alg = security->ctx_alg;
+ uctx->ctx_len = security->ctx_len;
+ memcpy(uctx + 1, security->ctx_str, security->ctx_len);
+ err = security_xfrm_state_alloc(x, uctx);
+ kfree(uctx);
+ if (err)
+ return true;
+
+ return false;
+}
+
static struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig,
struct xfrm_encap_tmpl *encap)
{
@@ -1497,6 +1521,10 @@ static struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig,
goto error;
}
+ if (orig->security)
+ if (clone_security(x, orig->security))
+ goto error;
+
if (orig->coaddr) {
x->coaddr = kmemdup(orig->coaddr, sizeof(*x->coaddr),
GFP_KERNEL);
--
2.20.1
next prev parent reply other threads:[~2020-08-20 18:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 18:11 [PATCH 1/3] xfrm: clone XFRMA_SET_MARK during xfrm_do_migrate Antony Antony
2020-08-20 18:14 ` [PATCH 2/3] xfrm: clone XFRMA_REPLAY_ESN_VAL in xfrm_do_migrate Antony Antony
2020-08-24 8:43 ` Steffen Klassert
2020-08-20 18:16 ` Antony Antony [this message]
2020-08-24 8:46 ` [PATCH 3/3] xfrm: clone XFRMA_SEC_CTX during xfrm_do_migrate Steffen Klassert
2020-08-24 8:39 ` [PATCH 1/3] xfrm: clone XFRMA_SET_MARK " Steffen Klassert
2020-08-26 19:39 ` [PATCH v2 1/4] xfrm: clone XFRMA_SET_MARK in xfrm_do_migrate Antony Antony
2020-08-26 19:39 ` [PATCH v2 2/4] xfrm: clone XFRMA_REPLAY_ESN_VAL " Antony Antony
2020-08-26 19:40 ` [PATCH v2 3/4] xfrm: clone XFRMA_SEC_CTX " Antony Antony
2020-08-28 5:18 ` Steffen Klassert
2020-08-26 19:40 ` [PATCH v2 4/4] xfrm: clone whole liftime_cur structure " Antony Antony
2020-08-28 5:20 ` Steffen Klassert
2020-09-04 6:49 ` [PATCH v3 1/4] xfrm: clone XFRMA_SET_MARK " Antony Antony
2020-09-09 5:54 ` Steffen Klassert
2020-09-04 6:49 ` [PATCH v3 2/4] xfrm: clone XFRMA_REPLAY_ESN_VAL " Antony Antony
2020-09-04 6:50 ` [PATCH v3 3/4] xfrm: clone XFRMA_SEC_CTX " Antony Antony
2020-09-04 6:50 ` [PATCH v3 4/4] xfrm: clone whole liftime_cur structure " Antony Antony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820181608.GA19772@moon.secunet.de \
--to=antony.antony@secunet.com \
--cc=antony@phenome.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.