From: Peter Chen <peter.chen@nxp.com>
To: balbi@kernel.org
Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
Peter Chen <peter.chen@nxp.com>
Subject: [PATCH v4 6/6] Revert "usb: udc: allow adding and removing the same gadget device"
Date: Fri, 21 Aug 2020 10:55:49 +0800 [thread overview]
Message-ID: <20200821025549.4591-7-peter.chen@nxp.com> (raw)
In-Reply-To: <20200821025549.4591-1-peter.chen@nxp.com>
We have already allocated gadget structure dynamically at UDC (dwc3)
driver, so commit fac323471df6 ("usb: udc: allow adding and removing
the same gadget device")could be reverted.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/gadget/udc/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index 2b6770d9fb3f..bf1b0efcfaac 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -1389,7 +1389,6 @@ void usb_del_gadget_udc(struct usb_gadget *gadget)
{
usb_del_gadget(gadget);
usb_put_gadget(gadget);
- memset(&gadget->dev, 0x00, sizeof(gadget->dev));
}
EXPORT_SYMBOL_GPL(usb_del_gadget_udc);
--
2.17.1
prev parent reply other threads:[~2020-08-21 2:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 2:55 [PATCH v4 0/6] USB: UDC: Fix memory leaks by expanding the API Peter Chen
2020-08-21 2:55 ` [PATCH v4 1/6] USB: UDC: Expand device model API interface Peter Chen
2020-08-21 2:55 ` [PATCH v4 2/6] USB: UDC: net2280: Fix memory leaks Peter Chen
2020-08-21 2:55 ` [PATCH v4 3/6] USB: UDC: net2272: " Peter Chen
2020-08-21 2:55 ` [PATCH v4 4/6] usb: cdns3: gadget: fix possible memory leak Peter Chen
2020-08-21 2:55 ` [PATCH v4 5/6] usb: dwc3: allocate gadget structure dynamically Peter Chen
2020-08-21 2:55 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821025549.4591-7-peter.chen@nxp.com \
--to=peter.chen@nxp.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.