From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A8EC433DF for ; Fri, 21 Aug 2020 07:10:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF0762078D for ; Fri, 21 Aug 2020 07:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597993840; bh=kP6S+GTnzj2U5cE2GuEwtUgvwvAkwdWUZC7g45JD9As=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fd0ODMSobZmNR2dyWNv1YmSxwPbe1S+pRJ3Nyud2w46ZLYp5b18CkysQ+mK07vBlY GolcIxRCXmgn2ZIk9pApDECFQ/jLbw8C0eUZUeSHKsRY1NJ8+csSCaTS/I3MhGqSo9 fdgYyrxXHcRxmhJO3nb+Uw98GmThLod1jpJqzT6A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726548AbgHUHKg convert rfc822-to-8bit (ORCPT ); Fri, 21 Aug 2020 03:10:36 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42623 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726138AbgHUHKg (ORCPT ); Fri, 21 Aug 2020 03:10:36 -0400 Received: by mail-wr1-f67.google.com with SMTP id d16so974961wrq.9; Fri, 21 Aug 2020 00:10:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jz5YmMUMv7fyLq3wiwjcdiqT8QN6h8dN46ufIK0XqjU=; b=TdXL19WXJzmGbMno2fWq0ObyowvQMLoy6ue8pWYEE9NobwO0y+K3rnXYXWl3nH2hcE uGbGjwcgzeKecfFRIbHqrkFz2VB7t7OQ4wqj74lUte9JJQQ7utM5kWOU9pbI04JhQHZ/ czkQC5RX8g2pI4TDbOaAHHFWeNHM0JToleeO+AFxDWDGz/EIMwlIYSfVQK7NweGfsxIf EClw4b0HntwHCQ+FTIT45a5RGYPP5SYia1WlYKFD0n3iskKhLVlruJwdYLCG7ZA0JzBk ZIZkjqupfaIz00vnq4r9x9lwMCFqdlyQ5r05pBfHsp4PoQBpgPg6PRgMdQlTq/RkZZVX lPcg== X-Gm-Message-State: AOAM530xBl/7cm+j4TYeXXru2CAxnsJa4c/eKQJRptTRs/qQb+04MRSj X8qUDKHlEfGzga7hjmTSV28= X-Google-Smtp-Source: ABdhPJwZdIK9j+sztRpjPkTystFIOkQ+5HeSyiTpAe/3quHWZDea6vpzykvVTCUJA8QZl8Gvd3OPmg== X-Received: by 2002:adf:9501:: with SMTP id 1mr1370184wrs.413.1597993833286; Fri, 21 Aug 2020 00:10:33 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id p15sm2487017wrj.61.2020.08.21.00.10.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Aug 2020 00:10:32 -0700 (PDT) Date: Fri, 21 Aug 2020 09:10:30 +0200 From: Krzysztof Kozlowski To: Lukasz Stelmach Cc: Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout Message-ID: <20200821071030.GA8585@kozik-lap> References: <20200819124940.GG18122@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Aug 19, 2020 at 03:39:56PM +0200, Lukasz Stelmach wrote: > It was <2020-08-19 śro 14:49>, when Krzysztof Kozlowski wrote: > > On Wed, Aug 19, 2020 at 02:32:07PM +0200, Łukasz Stelmach wrote: > >> Signed-off-by: Łukasz Stelmach > > > > Why? Everything works fine and suddenly minimum timeout is 100 ms? > > Actually I am not 100% sure the max() call is required, maybe +30 is > enough. Definitely some minimum value is required because for small > tranfers (100s of bytes) ms is 0 after the first assignment. Sure, just please describe it all in commit msg. All these questions "why?" came because of lack of explanation in commit msg. I guess minimum timeout 100 ms for each transfer is quite high, so maybe just bump the tolerance to 30 which also would be a minimum timeout. Best regards, Krzysztof > > >> --- > >> drivers/spi/spi-s3c64xx.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > >> index 27d77600a820..27db1e0f6f32 100644 > >> --- a/drivers/spi/spi-s3c64xx.c > >> +++ b/drivers/spi/spi-s3c64xx.c > >> @@ -464,7 +464,8 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, > >> > >> /* millisecs to xfer 'len' bytes @ 'cur_speed' */ > >> ms = xfer->len * 8 * 1000 / sdd->cur_speed; > >> - ms += 10; /* some tolerance */ > >> + ms = (ms * 10) + 30; /* some tolerance */ > >> + ms = max(ms, 100); /* minimum timeout */ > >> > >> val = msecs_to_jiffies(ms) + 10; > >> val = wait_for_completion_timeout(&sdd->xfer_completion, val); > >> -- > >> 2.26.2 > >> > > > > > > -- > Łukasz Stelmach > Samsung R&D Institute Poland > Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C208C433E1 for ; Fri, 21 Aug 2020 07:12:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD9FA214F1 for ; Fri, 21 Aug 2020 07:12:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IJxhOs/8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD9FA214F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6+IvnLzWydyaKNjckXp+kE8askaeC16ELdZkqEBVVvo=; b=IJxhOs/8lPb/BaZrVsoxtQFNk 0kWKSVXVK85Zc7psoSkXWpnfv+I5Cfer3bpu0bOwm6CPTVrRVWV2h5uenUtEca+AF88dc8kwOjRre 9ZVKtIPPJv5cOGAvhgpm4IuNEFJrD5w3qz9DUXQ9cr97InKLE20yDUWu76PYhbgGvvuBpIvVOuQgE OfCk6LZ02dYH1RtFCVYyrtiv4EhinP2Ba66y8QaeOgGeVA38exF0GRsEPX6e0+T2oufbDOK5X5PjT aHh0nN3D9pZkoKeJ4NNAuHb6RIfp8AaN39D0du+3CStnys+kv4bZvYTRVdXGvdvH7yj8SbZRlbWA6 SqOONg9kA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k91C8-0003h7-T9; Fri, 21 Aug 2020 07:10:36 +0000 Received: from mail-wr1-f66.google.com ([209.85.221.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k91C6-0003gb-P4 for linux-arm-kernel@lists.infradead.org; Fri, 21 Aug 2020 07:10:35 +0000 Received: by mail-wr1-f66.google.com with SMTP id z18so961884wrm.12 for ; Fri, 21 Aug 2020 00:10:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jz5YmMUMv7fyLq3wiwjcdiqT8QN6h8dN46ufIK0XqjU=; b=mE8JSdQhMap6Pb/SUtQLQl9ApIUGioBzfwbE8r1fvwSJoBopBzROJrWshFQrL8rovC qTs/vO4Hs6TYFHKHACwuhBhsdqgOmLfVgTjtrVrfSlONW0ethwH5MEnFK5qOsvaEokj6 koKHDh/YG7MCmlqYfhX2J6qGf2p25GXAlXnqQrJPTjWRuPq3dvgQDykKzHP/bb5D03JM TF08yUrI0452kryHIsN2uZ3q0q62bMzgmWq5EmXIo4ayXjFrBRoc31W2Z4SaksZBZZjF N5DU5cgZIgsrDBvZ2sHRysTf31KYWdBnfFAOf4Ji2UBb4BfFjyOk7ABGtbUWIaQiIOWq /Cdg== X-Gm-Message-State: AOAM533gXmOvgxehKB3G+GgKWDwkTWrKUqnrnQRH0ff8abJtLryX4/dr vhm93RdsT1bx8fcAhsYdSXo= X-Google-Smtp-Source: ABdhPJwZdIK9j+sztRpjPkTystFIOkQ+5HeSyiTpAe/3quHWZDea6vpzykvVTCUJA8QZl8Gvd3OPmg== X-Received: by 2002:adf:9501:: with SMTP id 1mr1370184wrs.413.1597993833286; Fri, 21 Aug 2020 00:10:33 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id p15sm2487017wrj.61.2020.08.21.00.10.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Aug 2020 00:10:32 -0700 (PDT) Date: Fri, 21 Aug 2020 09:10:30 +0200 From: Krzysztof Kozlowski To: Lukasz Stelmach Subject: Re: [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout Message-ID: <20200821071030.GA8585@kozik-lap> References: <20200819124940.GG18122@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200821_031034_832964_5B5109D4 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBdWcgMTksIDIwMjAgYXQgMDM6Mzk6NTZQTSArMDIwMCwgTHVrYXN6IFN0ZWxtYWNo IHdyb3RlOgo+IEl0IHdhcyA8MjAyMC0wOC0xOSDFm3JvIDE0OjQ5Piwgd2hlbiBLcnp5c3p0b2Yg S296bG93c2tpIHdyb3RlOgo+ID4gT24gV2VkLCBBdWcgMTksIDIwMjAgYXQgMDI6MzI6MDdQTSAr MDIwMCwgxYF1a2FzeiBTdGVsbWFjaCB3cm90ZToKPiA+PiBTaWduZWQtb2ZmLWJ5OiDFgXVrYXN6 IFN0ZWxtYWNoIDxsLnN0ZWxtYWNoQHNhbXN1bmcuY29tPgo+ID4KPiA+IFdoeT8gRXZlcnl0aGlu ZyB3b3JrcyBmaW5lIGFuZCBzdWRkZW5seSBtaW5pbXVtIHRpbWVvdXQgaXMgMTAwIG1zPwo+IAo+ IEFjdHVhbGx5IEkgYW0gbm90IDEwMCUgc3VyZSB0aGUgbWF4KCkgY2FsbCBpcyByZXF1aXJlZCwg bWF5YmUgKzMwIGlzCj4gZW5vdWdoLiBEZWZpbml0ZWx5IHNvbWUgbWluaW11bSB2YWx1ZSBpcyBy ZXF1aXJlZCBiZWNhdXNlIGZvciBzbWFsbAo+IHRyYW5mZXJzICgxMDBzIG9mIGJ5dGVzKSBtcyBp cyAwIGFmdGVyIHRoZSBmaXJzdCBhc3NpZ25tZW50LgoKU3VyZSwganVzdCBwbGVhc2UgZGVzY3Jp YmUgaXQgYWxsIGluIGNvbW1pdCBtc2cuIEFsbCB0aGVzZSBxdWVzdGlvbnMKIndoeT8iIGNhbWUg YmVjYXVzZSBvZiBsYWNrIG9mIGV4cGxhbmF0aW9uIGluIGNvbW1pdCBtc2cuCgpJIGd1ZXNzIG1p bmltdW0gdGltZW91dCAxMDAgbXMgZm9yIGVhY2ggdHJhbnNmZXIgaXMgcXVpdGUgaGlnaCwgc28g bWF5YmUKanVzdCBidW1wIHRoZSB0b2xlcmFuY2UgdG8gMzAgd2hpY2ggYWxzbyB3b3VsZCBiZSBh IG1pbmltdW0gdGltZW91dC4KCkJlc3QgcmVnYXJkcywKS3J6eXN6dG9mCgoKPiAKPiA+PiAtLS0K PiA+PiAgZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYyB8IDMgKystCj4gPj4gIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+PiAKPiA+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYyBiL2RyaXZlcnMvc3BpL3NwaS1zM2M2NHh4LmMK PiA+PiBpbmRleCAyN2Q3NzYwMGE4MjAuLjI3ZGIxZTBmNmYzMiAxMDA2NDQKPiA+PiAtLS0gYS9k cml2ZXJzL3NwaS9zcGktczNjNjR4eC5jCj4gPj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLXMzYzY0 eHguYwo+ID4+IEBAIC00NjQsNyArNDY0LDggQEAgc3RhdGljIGludCBzM2M2NHh4X3dhaXRfZm9y X2RtYShzdHJ1Y3QgczNjNjR4eF9zcGlfZHJpdmVyX2RhdGEgKnNkZCwKPiA+PiAgCj4gPj4gIAkv KiBtaWxsaXNlY3MgdG8geGZlciAnbGVuJyBieXRlcyBAICdjdXJfc3BlZWQnICovCj4gPj4gIAlt cyA9IHhmZXItPmxlbiAqIDggKiAxMDAwIC8gc2RkLT5jdXJfc3BlZWQ7Cj4gPj4gLQltcyArPSAx MDsgLyogc29tZSB0b2xlcmFuY2UgKi8KPiA+PiArCW1zID0gKG1zICogMTApICsgMzA7ICAgIC8q IHNvbWUgdG9sZXJhbmNlICovCj4gPj4gKwltcyA9IG1heChtcywgMTAwKTsgICAgICAvKiBtaW5p bXVtIHRpbWVvdXQgKi8KPiA+PiAgCj4gPj4gIAl2YWwgPSBtc2Vjc190b19qaWZmaWVzKG1zKSAr IDEwOwo+ID4+ICAJdmFsID0gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0KCZzZGQtPnhmZXJf Y29tcGxldGlvbiwgdmFsKTsKPiA+PiAtLSAKPiA+PiAyLjI2LjIKPiA+PiAKPiA+Cj4gPgo+IAo+ IC0tIAo+IMWBdWthc3ogU3RlbG1hY2gKPiBTYW1zdW5nIFImRCBJbnN0aXR1dGUgUG9sYW5kCj4g U2Ftc3VuZyBFbGVjdHJvbmljcwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==