From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: zhe.he@windriver.com
Cc: rric@kernel.org, oprofile-list@lists.sf.net,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips/oprofile: Fix fallthrough placement
Date: Fri, 21 Aug 2020 09:48:21 +0200 [thread overview]
Message-ID: <20200821074821.GD8336@alpha.franken.de> (raw)
In-Reply-To: <20200820125440.350184-1-zhe.he@windriver.com>
On Thu, Aug 20, 2020 at 08:54:40PM +0800, zhe.he@windriver.com wrote:
> From: He Zhe <zhe.he@windriver.com>
>
> We want neither
> "
> include/linux/compiler_attributes.h:201:41: warning: statement will never
> be executed [-Wswitch-unreachable]
> 201 | # define fallthrough __attribute__((__fallthrough__))
> | ^~~~~~~~~~~~~
> "
> nor
> "
> include/linux/compiler_attributes.h:201:41: warning: attribute
> 'fallthrough' not preceding a case label or default label
> 201 | # define fallthrough __attribute__((__fallthrough__))
> | ^~~~~~~~~~~~~
> "
>
> It's not worth adding one more macro. Let's simply place the fallthrough
> in between the expansions.
>
> Signed-off-by: He Zhe <zhe.he@windriver.com>
there is already another patch for the problem, which I've applied
to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2020-08-21 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 12:54 [PATCH] mips/oprofile: Fix fallthrough placement zhe.he
2020-08-21 7:48 ` Thomas Bogendoerfer [this message]
2020-08-21 8:46 ` He Zhe
2020-08-21 9:23 ` Gustavo A. R. Silva
2020-08-21 14:07 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821074821.GD8336@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=oprofile-list@lists.sf.net \
--cc=rric@kernel.org \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.