From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<grygorii.strashko@ti.com>, <nsekhar@ti.com>,
<linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port
Date: Fri, 21 Aug 2020 13:00:02 -0700 [thread overview]
Message-ID: <20200821130002.00002367@intel.com> (raw)
In-Reply-To: <20200821134912.30008-2-m-karicheri2@ti.com>
Murali Karicheri wrote:
> To flush the vid + mc entries from ALE, which is required when a VLAN
> interface is removed, driver needs to call cpsw_ale_flush_multicast()
> with ALE_PORT_HOST for port mask as these entries are added only for
> host port. Without this, these entries remain in the ALE table even
> after removing the VLAN interface. cpsw_ale_flush_multicast() calls
> cpsw_ale_flush_mcast which expects a port mask to do the job.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Patch looks good but please resend with a Fixes: tag.
next prev parent reply other threads:[~2020-08-21 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 13:49 [net v2 PATCH 1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port Murali Karicheri
2020-08-21 13:49 ` [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: " Murali Karicheri
2020-08-21 20:00 ` Jesse Brandeburg [this message]
2020-08-24 11:09 ` Murali Karicheri
2020-08-21 19:59 ` [net v2 PATCH 1/2] net: ethernet: ti: cpsw: " Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821130002.00002367@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.