From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9167DC433E1 for ; Fri, 21 Aug 2020 20:32:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66D4320724 for ; Fri, 21 Aug 2020 20:32:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725948AbgHUUcu (ORCPT ); Fri, 21 Aug 2020 16:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbgHUUcu (ORCPT ); Fri, 21 Aug 2020 16:32:50 -0400 Received: from tartarus.angband.pl (tartarus.angband.pl [IPv6:2001:41d0:602:dbe::8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 616B1C061573; Fri, 21 Aug 2020 13:32:50 -0700 (PDT) Received: from kilobyte by tartarus.angband.pl with local (Exim 4.92) (envelope-from ) id 1k9DiC-0000s1-NO; Fri, 21 Aug 2020 22:32:32 +0200 Date: Fri, 21 Aug 2020 22:32:32 +0200 From: Adam Borowski To: Thomas Gleixner Cc: Bjorn Helgaas , Ingo Molnar , Borislav Petkov , x86@kernel.org, linux-pci@vger.kernel.org, LKML , "Rafael J. Wysocki" , Len Brown Subject: Re: [PATCH] x86/pci: don't set acpi stuff if !CONFIG_ACPI Message-ID: <20200821203232.GA2187@angband.pl> References: <20200820125320.9967-1-kilobyte@angband.pl> <87y2m7rc4a.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87y2m7rc4a.fsf@nanos.tec.linutronix.de> X-Junkbait: aaron@angband.pl, zzyx@angband.pl User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: kilobyte@angband.pl X-SA-Exim-Scanned: No (on tartarus.angband.pl); SAEximRunCond expanded to false Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Aug 21, 2020 at 10:13:25PM +0200, Thomas Gleixner wrote: > On Thu, Aug 20 2020 at 14:53, Adam Borowski wrote: > > Found by randconfig builds. > > > > arch/x86/pci/intel_mid_pci.c | 2 ++ > > arch/x86/pci/xen.c | 2 ++ > > --- a/arch/x86/pci/intel_mid_pci.c > > +++ b/arch/x86/pci/intel_mid_pci.c > > @@ -299,8 +299,10 @@ int __init intel_mid_pci_init(void) > > +#ifdef CONFIG_ACPI > > /* Continue with standard init */ > > acpi_noirq_set(); > > +#endif > If CONFIG_ACPI=n then acpi_noirq_set() is an empty stub inline. So I'm > not sure what you are trying to solve here. > > Ah, I see with CONFIG_ACPI=n linux/acpi.h does not include asm/acpi.h so > the stubs are unreachable. So that needs to be fixed and not papered > over with #ifdeffery If I understand Randy Dunlap correctly, he already sent a pair of patches that do what you want. Meow. -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋⠀ It's time to migrate your Imaginary Protocol from version 4i to 6i. ⠈⠳⣄⠀⠀⠀⠀