From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA8AC433E1 for ; Sat, 22 Aug 2020 12:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 797472086A for ; Sat, 22 Aug 2020 12:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598099861; bh=y+uYYhtLEOfbvNnfBiysXjxm+oiH9s3TiclB+UrIng8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eem7WPGKKFgYnDcLHp+zoZ0KbKflO6b7li9IlX26NvEcS0jFineD+qZR6oXLBAwIG G4ByrqaNm0HC+rxPdhTLCqoQjhxtaht1TCUy87xWMJs+uRVsVxXwA7bWrAutqFHk7Z tOlWlvh5Sxgbq5+BO3HMV5C20J/r+nOhs52BzE2U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbgHVMhl convert rfc822-to-8bit (ORCPT ); Sat, 22 Aug 2020 08:37:41 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:42647 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728020AbgHVMhk (ORCPT ); Sat, 22 Aug 2020 08:37:40 -0400 Received: by mail-wr1-f65.google.com with SMTP id d16so4301104wrq.9; Sat, 22 Aug 2020 05:37:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Zsjdj30vPVAczb2I1jVNJYKyxUg3Yx5VcTWg2Jlo+tA=; b=Vx1LklBS0TeKPVb267O/2XxB2ZDPeeLVibAs0k1/aA4XcXzHmNQqoJCkL3DnAnG8k3 EpZLz3zBza0/XZXJDitpXxchLetSgXGPslql55HwTL7lS615X/jKcxZ/sk+SVE27ZFh6 fnDwRUnr4nDzX9053buvrEpWfE8NiZNV8Co5om/Vs/VY3JZoCHbd4Ze4pTl/0D76Yth1 g3Y4sSfh0aCjGK10zzGH1HI0T69smWMGwvHQmw1IoKM5hZY2vwU6ObgzJrKDuIlW24/j mcUDPDiM51lkEUw37qtGakblQZCwI0rp1N8+jV8NvEchCo3qOqb9qlNOQ8asBXu1s1ms EA1Q== X-Gm-Message-State: AOAM533093hfpnHcq8+t6hPmpLlk7WnYvzCZ1IxgfICiyHq4sCyUZGX9 FnggEP49863N7ECre+pmTLs= X-Google-Smtp-Source: ABdhPJwo5o2OAD47RHyw+Dj9k7IKZPp5XYf8G1qZV84pX0QS5b6avXYEWnIUugbLv5moZpspzH1B8A== X-Received: by 2002:adf:fc52:: with SMTP id e18mr2269869wrs.185.1598099858314; Sat, 22 Aug 2020 05:37:38 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id g70sm13284254wmg.24.2020.08.22.05.37.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 05:37:37 -0700 (PDT) Date: Sat, 22 Aug 2020 14:37:35 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values Message-ID: <20200822123735.GE20423@kozik-lap> References: <20200821161401.11307-1-l.stelmach@samsung.com> <20200821161401.11307-7-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200821161401.11307-7-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Fri, Aug 21, 2020 at 06:13:58PM +0200, Łukasz Stelmach wrote: > Check return values in prepare_dma() and s3c64xx_spi_config() and > propagate errors upwards. > > Signed-off-by: Łukasz Stelmach > --- > drivers/spi/spi-s3c64xx.c | 47 ++++++++++++++++++++++++++++++++------- > 1 file changed, 39 insertions(+), 8 deletions(-) This should be a third patch - backportable fixes should go at beginning. Fixes: 788437273fa8 ("spi: s3c64xx: move to generic dmaengine API") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC778C433DF for ; Sat, 22 Aug 2020 12:38:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B64562080D for ; Sat, 22 Aug 2020 12:38:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JaDfhYDV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B64562080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1OT/Y8TYQuOHX3mgU76qNaCQ45NRR3wD5I3Tp7XNkGM=; b=JaDfhYDVTb+PEilcJ8bpuKzxX Qp045o+EH3x0240mL2XJ/Komt7J7CQ77e3ayfqCmi9IIeDBy2Dz+jREWvvmfAoaIswE422eABoN1B aHQQ9qA73qtkgREpRt+Clm1LgIFEO/EsggH3Q8NryPj8mzwCQIsqlMYt4l0a8xVvGoEvdrwy5ddRX fRxAppiA5+XRt15TpL45BWJJUMQUeF2HiE0rxY11hKoMhWGX5JlZHe9Q1mNqOGgb3yN/FJPYpWrn+ Z1Ru7i+uKh/CUEyTu343HGvEdGFoFHRxTCQ//6NVX9VeEeWdP+GI7p7nQQWg2aFNCkCEtjV8XWi4b 1DDWZEH4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9SmD-0004hA-F8; Sat, 22 Aug 2020 12:37:41 +0000 Received: from mail-wr1-f66.google.com ([209.85.221.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9SmB-0004gj-9O for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2020 12:37:39 +0000 Received: by mail-wr1-f66.google.com with SMTP id a15so4296750wrh.10 for ; Sat, 22 Aug 2020 05:37:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Zsjdj30vPVAczb2I1jVNJYKyxUg3Yx5VcTWg2Jlo+tA=; b=VMTYQLcjP5rGndehr9KZw80uqVlakh8UnG2kmKNqoMcNVTBi5uWIrS9zh/oQZvbLLI kZSSankJsLgkGkFrsfDcx9Bl/ViRuyXBl4CGU/vvKS5b/91CanixbN/kvMbYSHZhwdz/ KOZLmPmdY6rJQATVkVpWOpY7yevrhnS811fhFABgmxceosJQXGjgqzKXhFT1VkTN/LUv 09kStqWn2JSZ4ESKwzEVfMylexTbJkwQ+FQdbn+J13SDJBcE/q+tPFzaI/vSxZwiNrOU vmkKsM/mIyxOkcLejjSqGlNRGKoQ2AgdtxReV3KJkcpNC7ICU/EyW/oK+/y5ox5PPj2Y jK8A== X-Gm-Message-State: AOAM533Lw/z952bmCXLfeLYz6VP6MoQzbpA8JpjzsxlhOP9fejGCnAXB wrtdRTcZn6mUPbln8Rx+ylI= X-Google-Smtp-Source: ABdhPJwo5o2OAD47RHyw+Dj9k7IKZPp5XYf8G1qZV84pX0QS5b6avXYEWnIUugbLv5moZpspzH1B8A== X-Received: by 2002:adf:fc52:: with SMTP id e18mr2269869wrs.185.1598099858314; Sat, 22 Aug 2020 05:37:38 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id g70sm13284254wmg.24.2020.08.22.05.37.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 05:37:37 -0700 (PDT) Date: Sat, 22 Aug 2020 14:37:35 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values Message-ID: <20200822123735.GE20423@kozik-lap> References: <20200821161401.11307-1-l.stelmach@samsung.com> <20200821161401.11307-7-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821161401.11307-7-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_083739_339634_607C2BE5 X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBdWcgMjEsIDIwMjAgYXQgMDY6MTM6NThQTSArMDIwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBDaGVjayByZXR1cm4gdmFsdWVzIGluIHByZXBhcmVfZG1hKCkgYW5kIHMzYzY0 eHhfc3BpX2NvbmZpZygpIGFuZAo+IHByb3BhZ2F0ZSBlcnJvcnMgdXB3YXJkcy4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiDFgXVrYXN6IFN0ZWxtYWNoIDxsLnN0ZWxtYWNoQHNhbXN1bmcuY29tPgo+IC0t LQo+ICBkcml2ZXJzL3NwaS9zcGktczNjNjR4eC5jIHwgNDcgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCA4 IGRlbGV0aW9ucygtKQoKVGhpcyBzaG91bGQgYmUgYSB0aGlyZCBwYXRjaCAtIGJhY2twb3J0YWJs ZSBmaXhlcyBzaG91bGQgZ28gYXQKYmVnaW5uaW5nLgoKRml4ZXM6IDc4ODQzNzI3M2ZhOCAoInNw aTogczNjNjR4eDogbW92ZSB0byBnZW5lcmljIGRtYWVuZ2luZSBBUEkiKQpSZXZpZXdlZC1ieTog S3J6eXN6dG9mIEtvemxvd3NraSA8a3J6a0BrZXJuZWwub3JnPgoKQmVzdCByZWdhcmRzLApLcnp5 c3p0b2YKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK