From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E0DC433DF for ; Sat, 22 Aug 2020 12:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A16192080D for ; Sat, 22 Aug 2020 12:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598100211; bh=RYd+GVqUEfT5JPQYe4AT1kahmjElEZxFWRZSc5UU2wI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WAszrL1zeUG92e5wkv4flDp9cxWnujETs/GxKubMyX4wa1WW9D12T/LxEAZuW/yKt IKGXUjPQNMzWVgotjh6opDLuFlAc0q2E4UuEgwcgjINmvqXGwmL1LtsPgT5tn4tqC/ BYSqN2kN7KTTS2PrYQLMNkJKESaVIb96xS5S4L60= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727900AbgHVMnb convert rfc822-to-8bit (ORCPT ); Sat, 22 Aug 2020 08:43:31 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46249 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727827AbgHVMna (ORCPT ); Sat, 22 Aug 2020 08:43:30 -0400 Received: by mail-wr1-f68.google.com with SMTP id r15so4284381wrp.13; Sat, 22 Aug 2020 05:43:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=WBNSRxvyAb/qQZAkHTrrLM5INeMErpw4ZMaPgiAVFYc=; b=NPGRsV3lU9KQ/PJOVDEAWuy9khYOyotMACJOnIMgyIGDcqFHtU3xwev68NCn61pLV4 KkOw/+kpzX3i6DDmpfZPXTkCgazlYZmOPCT9kzdGis6E82u8IGg2qDrPSV71W9uqD4Tm BudUSdiy2eSkuLYKJb9Jkrd96H+q//e95A/4oaM6gBAob5D53XV/gSjz7mQvgaRP/t2F J+4nh+a2dqvX+03WpoNlluqYPc5IaQ01v3rPUKLzUVr+GwYVbfie6fkf9m5q8Gg+1IL2 4JUJZXM1LY80m3I0gSlHlAGPTYO3E4LUMA5ReELM3phWeHhVhVc4qQ0M7SwxVgjG3x4N TCrw== X-Gm-Message-State: AOAM530mZoGY5tVy84yjNtQdoubpRTOM7gB7/PKxLoBQG/XJBWou08dC nIkq2uXwqm2eZsRVjVoOUS8= X-Google-Smtp-Source: ABdhPJwdJA/5sEK6TGoZ7ND8qtNuotIocdqMiW4JOZohKvT3Lpi0KdwHGvSd1Cm5w504EjRKD/ptuQ== X-Received: by 2002:adf:c64d:: with SMTP id u13mr7206988wrg.114.1598100208370; Sat, 22 Aug 2020 05:43:28 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id d14sm11074673wre.44.2020.08.22.05.43.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 05:43:27 -0700 (PDT) Date: Sat, 22 Aug 2020 14:43:25 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com, Tomasz Figa Subject: Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value Message-ID: <20200822124325.GF20423@kozik-lap> References: <20200821161401.11307-1-l.stelmach@samsung.com> <20200821161401.11307-8-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200821161401.11307-8-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Fri, Aug 21, 2020 at 06:13:59PM +0200, Łukasz Stelmach wrote: > cur_speed is used to calculate transfer timeout and needs to be > set to the actual value of (half) the clock speed for precise > calculations. If you need this only for timeout calculation just divide it in s3c64xx_wait_for_dma(). Otherwise why only if (cmu) case is updated? You are also affecting here not only timeout but s3c64xx_enable_datapath() which is not mentioned in commit log. In other words, this looks wrong. Best regards, Krzysztof > > Cc: Tomasz Figa > Signed-off-by: Łukasz Stelmach > --- > drivers/spi/spi-s3c64xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 02de734b8ab1..89c162efe355 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -626,6 +626,7 @@ static int s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd) > ret = clk_set_rate(sdd->src_clk, sdd->cur_speed * 2); > if (ret) > return ret; > + sdd->cur_speed = clk_get_rate(sdd->src_clk) / 2; > } else { > /* Configure Clock */ > val = readl(regs + S3C64XX_SPI_CLK_CFG); > -- > 2.26.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96B5C433DF for ; Sat, 22 Aug 2020 12:44:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B821820720 for ; Sat, 22 Aug 2020 12:44:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PADJkpYy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B821820720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OIymQUtlgCr06VanHp4Nixusy60z/b5bYckWH0QItj4=; b=PADJkpYyBa5HkUtSlVE04wNdY Qni3H0Dtk7TVe9GrcksZ6YgPfpDNsGv3ZWVEWKjb//N/ty1A2fxI6lQpdRKpj7pv+pMbw5aCnqWOG CR/3WEjEMe5ikzknILVNieU/HxGmo+I/Ub6R1tMKVtPfU7XuS3+z0KnSd0Jr7yovwnp4HiDUZ7vp5 9cDWzRoHc9wTq60cgqg+IxBx0MJptMKO79uTWTBJ2TIvE+OLzYuI1PUmdIdn0TNViByZ9zPbBhHWJ ylah0nCWDLa2cY6FAD910lsWymL+f333bAhDjUSKel0bBKq/vFgIUUiqPCeDLgE4EbEbEnQLucgbX TVEiP7MjA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9Srs-0005Pl-Hd; Sat, 22 Aug 2020 12:43:32 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9Srp-0005PA-GX for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2020 12:43:30 +0000 Received: by mail-wr1-f67.google.com with SMTP id d16so4309241wrq.9 for ; Sat, 22 Aug 2020 05:43:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=WBNSRxvyAb/qQZAkHTrrLM5INeMErpw4ZMaPgiAVFYc=; b=XLvhdKFEiJN7RTc7QeVr14I2AMAZe35C+YLRT5vuM7Inq73ccDrH8cUfWRNJtYXtU2 RobmokxuzXd3fnH45Hxy2BSGS7IdeD21aWEBKWL4aduuuLmlx8IGgr1fzjzruD4vLR6X d4ulvapR+yKa9b6Qo7sKTiHJorytWmUD95ruUgLNN9qaymCPGwciOUNDqw/Nj9q47nHz 2Jg/DnIkz8ZfE0aAr4rystKFuzvTpBVPPVq9uNzcRHycC+1qTug6wRK1iVTkYUSkovf6 HtsYTe170vl7RHmdS31eYPIl1NAYQ6MAZCptGrfIhr1ldTJ/33kFAPSgtyvtGUQtZb7c DG1g== X-Gm-Message-State: AOAM530yy9bEczjUsrDBgOVyBIJOqrjWcNiXfoesQGIV4d4S9WvjA4Ty CfA9ck0hG+PShsrg8z6JI18= X-Google-Smtp-Source: ABdhPJwdJA/5sEK6TGoZ7ND8qtNuotIocdqMiW4JOZohKvT3Lpi0KdwHGvSd1Cm5w504EjRKD/ptuQ== X-Received: by 2002:adf:c64d:: with SMTP id u13mr7206988wrg.114.1598100208370; Sat, 22 Aug 2020 05:43:28 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id d14sm11074673wre.44.2020.08.22.05.43.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 05:43:27 -0700 (PDT) Date: Sat, 22 Aug 2020 14:43:25 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value Message-ID: <20200822124325.GF20423@kozik-lap> References: <20200821161401.11307-1-l.stelmach@samsung.com> <20200821161401.11307-8-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821161401.11307-8-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_084329_569451_16CE9A82 X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , Tomasz Figa , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBdWcgMjEsIDIwMjAgYXQgMDY6MTM6NTlQTSArMDIwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBjdXJfc3BlZWQgaXMgdXNlZCB0byBjYWxjdWxhdGUgdHJhbnNmZXIgdGltZW91 dCBhbmQgbmVlZHMgdG8gYmUKPiBzZXQgdG8gdGhlIGFjdHVhbCB2YWx1ZSBvZiAoaGFsZikgdGhl IGNsb2NrIHNwZWVkIGZvciBwcmVjaXNlCj4gY2FsY3VsYXRpb25zLgoKSWYgeW91IG5lZWQgdGhp cyBvbmx5IGZvciB0aW1lb3V0IGNhbGN1bGF0aW9uIGp1c3QgZGl2aWRlIGl0IGluCnMzYzY0eHhf d2FpdF9mb3JfZG1hKCkuIE90aGVyd2lzZSB3aHkgb25seSBpZiAoY211KSBjYXNlIGlzIHVwZGF0 ZWQ/CgpZb3UgYXJlIGFsc28gYWZmZWN0aW5nIGhlcmUgbm90IG9ubHkgdGltZW91dCBidXQKczNj NjR4eF9lbmFibGVfZGF0YXBhdGgoKSB3aGljaCBpcyBub3QgbWVudGlvbmVkIGluIGNvbW1pdCBs b2cuIEluIG90aGVyCndvcmRzLCB0aGlzIGxvb2tzIHdyb25nLgoKQmVzdCByZWdhcmRzLApLcnp5 c3p0b2YKCj4gCj4gQ2M6IFRvbWFzeiBGaWdhIDx0ZmlnYUBjaHJvbWl1bS5vcmc+Cj4gU2lnbmVk LW9mZi1ieTogxYF1a2FzeiBTdGVsbWFjaCA8bC5zdGVsbWFjaEBzYW1zdW5nLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYyB8IDEgKwo+ICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYyBi L2RyaXZlcnMvc3BpL3NwaS1zM2M2NHh4LmMKPiBpbmRleCAwMmRlNzM0YjhhYjEuLjg5YzE2MmVm ZTM1NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3NwaS9zcGktczNjNjR4eC5jCj4gKysrIGIvZHJp dmVycy9zcGkvc3BpLXMzYzY0eHguYwo+IEBAIC02MjYsNiArNjI2LDcgQEAgc3RhdGljIGludCBz M2M2NHh4X3NwaV9jb25maWcoc3RydWN0IHMzYzY0eHhfc3BpX2RyaXZlcl9kYXRhICpzZGQpCj4g IAkJcmV0ID0gY2xrX3NldF9yYXRlKHNkZC0+c3JjX2Nsaywgc2RkLT5jdXJfc3BlZWQgKiAyKTsK PiAgCQlpZiAocmV0KQo+ICAJCQlyZXR1cm4gcmV0Owo+ICsJCXNkZC0+Y3VyX3NwZWVkID0gY2xr X2dldF9yYXRlKHNkZC0+c3JjX2NsaykgLyAyOwo+ICAJfSBlbHNlIHsKPiAgCQkvKiBDb25maWd1 cmUgQ2xvY2sgKi8KPiAgCQl2YWwgPSByZWFkbChyZWdzICsgUzNDNjRYWF9TUElfQ0xLX0NGRyk7 Cj4gLS0gCj4gMi4yNi4yCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==