From: Philip Li <philip.li@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel test robot <lkp@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Chinwen Chang <chinwen.chang@mediatek.com>
Subject: Re: [linux-next:master] BUILD REGRESSION 605cbf3d5f20470ec303b79feda3202935f4a142
Date: Sun, 23 Aug 2020 11:41:05 +0800 [thread overview]
Message-ID: <20200823034105.GA2953@intel.com> (raw)
In-Reply-To: <20200820134305.baa5ac2c1300a6b412a0c7c9@linux-foundation.org>
On Thu, Aug 20, 2020 at 01:43:05PM -0700, Andrew Morton wrote:
> On Fri, 21 Aug 2020 04:26:12 +0800 kernel test robot <lkp@intel.com> wrote:
>
> > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > branch HEAD: 605cbf3d5f20470ec303b79feda3202935f4a142 Add linux-next specific files for 20200820
> >
> > Error/Warning in current branch:
>
> > ...
> >
> >
> > fs/proc/task_mmu.c:947 show_smaps_rollup() error: double unlocked 'mm->mmap_lock' (orig line 879)
>
> This is code added by "mm: proc: smaps_rollup: do not stall write
> attempts on mmap_lock"
> (http://lkml.kernel.org/r/1597715898-3854-4-git-send-email-chinwen.chang@mediatek.com).
>
> I don't get it.
Sorry Andrew, this is a false positive. We wrongly send out a few false reports
related to "double unlocked" due to bot issue. Sorry for the inconvenience caused.
>
> : if (mmap_lock_is_contended(mm)) {
> : mmap_read_unlock(mm);
> : ret = mmap_read_lock_killable(mm);
> : if (ret) {
> : release_task_mempolicy(priv);
> : goto out_put_mm;
> : }
>
> Here the mmap_lock is again taken for read
>
> : ...
> :
> : }
> : /* Case 2 above */
> : vma = vma->vm_next;
> : }
> :
> : ...
> :
> : mmap_read_unlock(mm);
>
> and here it's unlocked. I don't see a possibility for double-unlock?
>
prev parent reply other threads:[~2020-08-23 3:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 20:26 [linux-next:master] BUILD REGRESSION 605cbf3d5f20470ec303b79feda3202935f4a142 kernel test robot
2020-08-20 20:40 ` Andrew Morton
2020-08-20 21:03 ` Amir Goldstein
2020-08-20 20:43 ` Andrew Morton
2020-08-23 3:41 ` Philip Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823034105.GA2953@intel.com \
--to=philip.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chinwen.chang@mediatek.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.