From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59EB5C433E1 for ; Sun, 23 Aug 2020 09:47:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9D8F2074D for ; Sun, 23 Aug 2020 09:47:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9D8F2074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k9mb2-0000Xc-VE; Sun, 23 Aug 2020 09:47:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k9mb1-0000WW-PF for xen-devel@lists.xenproject.org; Sun, 23 Aug 2020 09:47:27 +0000 X-Inumbo-ID: 9b459455-d53e-463c-8e22-5211ba4fbcbd Received: from hera.aquilenet.fr (unknown [185.233.100.1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9b459455-d53e-463c-8e22-5211ba4fbcbd; Sun, 23 Aug 2020 09:47:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 4A8CA4C17; Sun, 23 Aug 2020 11:47:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4e8iaxit9eQA; Sun, 23 Aug 2020 11:47:24 +0200 (CEST) Received: from function (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr [86.234.239.11]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 550324BFF; Sun, 23 Aug 2020 11:47:24 +0200 (CEST) Received: from samy by function with local (Exim 4.94) (envelope-from ) id 1k9maw-00CJ7W-U1; Sun, 23 Aug 2020 11:47:22 +0200 Date: Sun, 23 Aug 2020 11:47:22 +0200 From: Samuel Thibault To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Subject: Re: [PATCH v3 07/38] stubdom: add correct dependencies for Xen libraries Message-ID: <20200823094722.o2o63bi2tb4vukqu@function> Mail-Followup-To: Samuel Thibault , Juergen Gross , xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu References: <20200823093519.18386-1-jgross@suse.com> <20200823093519.18386-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200823093519.18386-8-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Juergen Gross, le dim. 23 août 2020 11:34:48 +0200, a ecrit: > The stubdom Makefile is missing several dependencies between Xen > libraries. Add them. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault In case another round of review is needed, perhaps you can just factorize: > @@ -387,6 +394,7 @@ $(TARGETS_MINIOS): mini-os-%: > > .PHONY: libxentoolcore > libxentoolcore: libs-$(XEN_TARGET_ARCH)/toolcore/libxentoolcore.a > +libs-$(XEN_TARGET_ARCH)/toolcore/libxentoolcore.a: $(LIBDEPS_toolcore) > libs-$(XEN_TARGET_ARCH)/toolcore/libxentoolcore.a: mk-headers-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) > CPPFLAGS="$(TARGET_CPPFLAGS)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C libs-$(XEN_TARGET_ARCH)/toolcore > > @@ -396,6 +404,7 @@ libs-$(XEN_TARGET_ARCH)/toolcore/libxentoolcore.a: mk-headers-$(XEN_TARGET_ARCH) > > .PHONY: libxentoollog > libxentoollog: libs-$(XEN_TARGET_ARCH)/toollog/libxentoollog.a > +libs-$(XEN_TARGET_ARCH)/toollog/libxentoollog.a: $(LIBDEPS_toollog) > libs-$(XEN_TARGET_ARCH)/toollog/libxentoollog.a: mk-headers-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) > CPPFLAGS="$(TARGET_CPPFLAGS)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C libs-$(XEN_TARGET_ARCH)/toollog etc. by iterating over LIBS_LIBS? That'll make the maintenance easier. Samuel