From: Rustam Kovhaev <rkovhaev@gmail.com>
To: Anton Altaparmakov <anton@tuxera.com>
Cc: "linux-ntfs-dev@lists.sourceforge.net"
<linux-ntfs-dev@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] ntfs: add check for mft record size in superblock
Date: Sun, 23 Aug 2020 19:01:46 -0700 [thread overview]
Message-ID: <20200824020146.GA209078@thinkpad> (raw)
In-Reply-To: <F206DE99-102C-475D-9129-5B9ACBAED8E6@tuxera.com>
On Mon, Aug 24, 2020 at 01:44:06AM +0000, Anton Altaparmakov wrote:
> Hi Rustam,
>
> Thank you for the patch but it introduces an endianness bug - you have to us le32_to_cpu(m->bytes_allocated) both when doing the comparison and then printing the message.
>
> Also, please drop the square brackets. Wherever the driver prints such things it never uses brackets around the numbers and it would be better to have this consistent throughout.
>
> Can you please resend with the above issues addressed? You can then also add to the commit message:
>
> Acked-by: Anton Altaparmakov <anton@tuxera.com>
>
> Thanks!
>
> Best regards,
>
> Anton
>
hi Anton,
thank you for the review, my bad, i'll get it fixed and i'll resend the patch
next prev parent reply other threads:[~2020-08-24 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 15:21 [PATCH] ntfs: add check for mft record size in superblock Rustam Kovhaev
2020-08-24 1:44 ` Anton Altaparmakov
2020-08-24 2:01 ` Rustam Kovhaev [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-24 2:28 Rustam Kovhaev
2020-08-24 2:46 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824020146.GA209078@thinkpad \
--to=rkovhaev@gmail.com \
--cc=anton@tuxera.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.