From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846EBC433DF for ; Mon, 24 Aug 2020 06:49:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 646B1206BE for ; Mon, 24 Aug 2020 06:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598251783; bh=MoR5l415tOqXO7qDvbGK3qkYCXTWIk9BbyxnSBH+NOA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=AO6e2wM9XcFLea1pqSHIpWt7vI7M4Q+eCQKSXl0eDliz0ZTKx/1Om8s3U3EGCNJYm Zp9P2yHZS5m/1bEl127oNCfVKJJg5Qyzl9+HdymOfCUGg4N8Pep4zkAaNvraadMPwr I2jLOCEeBitgSOHpMxLpFM9Dz1WOeAK/nL7S3xFY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725946AbgHXGtm (ORCPT ); Mon, 24 Aug 2020 02:49:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:40096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgHXGtm (ORCPT ); Mon, 24 Aug 2020 02:49:42 -0400 Received: from coco.lan (unknown [95.90.213.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB28A2067C; Mon, 24 Aug 2020 06:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598251781; bh=MoR5l415tOqXO7qDvbGK3qkYCXTWIk9BbyxnSBH+NOA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d8Fa9jnF4RxQAHQUfTQiJnd1/Cv3peOrzUsQ+uvrMSfO9dxpXk5FFmL8qQR+62r2d /5Z+CzrXnWZx+hAETh664fBPlISrF9QHDL0J3KIvyrE+0W2sam4bZO9CkasBh6uuiy Lifm+3q0OlCTMYdbS1UXGwLbhr7/E/XclY5RLP1s= Date: Mon, 24 Aug 2020 08:49:30 +0200 From: Mauro Carvalho Chehab To: John Stultz Cc: Greg Kroah-Hartman , linuxarm@huawei.com, mauro.chehab@huawei.com, Manivannan Sadhasivam , Daniel Vetter , dri-devel , Bogdan Togorean , Liwei Cai , linux-arm-kernel , Daniel Borkmann , Rob Herring , "David S. Miller" , Xinliang Liu , Neil Armstrong , Wanchun Zheng , driverdevel , BPF Mailing List , linux-media , Tomi Valkeinen , Jesper Dangaard Brouer , Laurent Pinchart , Xinwei Kong , Alexei Starovoitov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Clark , Laurentiu Palcu , Andrzej Hajda , John Fastabend , Liuyao An , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Wei Xu , Rongrong Zou , Philipp Zabel , Sam Ravnborg , Network Development , Sumit Semwal , lkml , Jakub Kicinski , David Airlie , Chen Feng Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200824084853.10560ed1@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi John, Em Wed, 19 Aug 2020 20:28:44 -0700 John Stultz escreveu: > That said even with the patches I've got on top of your series, I > still see a few issues: > 1) I'm seeing red-blue swap with your driver. I need to dig a bit to > see what the difference is, I know gralloc has a config option for > this, and maybe the version of the driver I'm carrying has it wrong? Maybe it is due to this: drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c: hal_fmt = HISI_FB_PIXEL_FORMAT_BGRA_8888;/* dss_get_format(fb->pixel_format); */ It sounds to me that someone added a hack hardcoding BGRA_8888 over there. Btw, I removed the hack, with: diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c b/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c index a68db1a27bbf..ba64aae371e4 100644 --- a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c @@ -857,7 +857,7 @@ void hisi_fb_pan_display(struct drm_plane *plane) rect.right = src_w - 1; rect.top = 0; rect.bottom = src_h - 1; - hal_fmt = HISI_FB_PIXEL_FORMAT_BGRA_8888;/* dss_get_format(fb->pixel_format); */ + hal_fmt = dss_get_format(fb->format->format); DRM_DEBUG_DRIVER("channel%d: src:(%d,%d, %dx%d) crtc:(%d,%d, %dx%d), rect(%d,%d,%d,%d),fb:%dx%d, pixel_format=%d, stride=%d, paddr=0x%x, bpp=%d.\n", chn_idx, src_x, src_y, src_w, src_h, And now red and blue are swapped on my HDMI screen too. I'll compare this part with your version, but I guess the bug is on this logic. Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A76C433E1 for ; Mon, 24 Aug 2020 06:51:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BE232067C for ; Mon, 24 Aug 2020 06:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nhrnn+WE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="d8Fa9jnF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BE232067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H1iS8qwhwNlsPJCCLd1YId7XnrcPLn3FGjtI+wURDOk=; b=nhrnn+WEfYF6UWF6GmTMUyRtN iWrOS5JdjKNOvinIMsjCH/UmNgyZayx3GOH2RduGRZ9WxSqVw2OI+ZUf5l30aVzp3p7p8oXvQQ7Om kb48VmA+wy3dTaYZhIlfMtTvqYvfecWc0q4eVornpnRKNUTOi1Co540FkFmrZWTjWi8T1+ssl8Zlx AlHkyuL8mOicD6SzKxd3a2rYuhCou4ZTe0d53USkgW42P/Lmh5tml6YusxDFjKi3CMrNb8bq1sqZP JKYaM/mhw6xpqlP6rj/06cO9WyL26vqjLEJQKHrv+SgPR63j81IEUoWCIQlbmVTlBFzpVI2aIL6/S 0H/8hRzTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA6Ic-0000bx-4v; Mon, 24 Aug 2020 06:49:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA6IZ-0000bE-0d for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 06:49:44 +0000 Received: from coco.lan (unknown [95.90.213.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB28A2067C; Mon, 24 Aug 2020 06:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598251781; bh=MoR5l415tOqXO7qDvbGK3qkYCXTWIk9BbyxnSBH+NOA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d8Fa9jnF4RxQAHQUfTQiJnd1/Cv3peOrzUsQ+uvrMSfO9dxpXk5FFmL8qQR+62r2d /5Z+CzrXnWZx+hAETh664fBPlISrF9QHDL0J3KIvyrE+0W2sam4bZO9CkasBh6uuiy Lifm+3q0OlCTMYdbS1UXGwLbhr7/E/XclY5RLP1s= Date: Mon, 24 Aug 2020 08:49:30 +0200 From: Mauro Carvalho Chehab To: John Stultz Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200824084853.10560ed1@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_024943_309657_F8724AE9 X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , Sam Ravnborg , Sumit Semwal , driverdevel , Daniel Borkmann , John Fastabend , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Philipp Zabel , Laurentiu Palcu , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Rob Herring , Jakub Kicinski , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel , Greg Kroah-Hartman , lkml , Liuyao An , Daniel Vetter , Network Development , Rongrong Zou , BPF Mailing List , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi John, Em Wed, 19 Aug 2020 20:28:44 -0700 John Stultz escreveu: > That said even with the patches I've got on top of your series, I > still see a few issues: > 1) I'm seeing red-blue swap with your driver. I need to dig a bit to > see what the difference is, I know gralloc has a config option for > this, and maybe the version of the driver I'm carrying has it wrong? Maybe it is due to this: drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c: hal_fmt = HISI_FB_PIXEL_FORMAT_BGRA_8888;/* dss_get_format(fb->pixel_format); */ It sounds to me that someone added a hack hardcoding BGRA_8888 over there. Btw, I removed the hack, with: diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c b/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c index a68db1a27bbf..ba64aae371e4 100644 --- a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c @@ -857,7 +857,7 @@ void hisi_fb_pan_display(struct drm_plane *plane) rect.right = src_w - 1; rect.top = 0; rect.bottom = src_h - 1; - hal_fmt = HISI_FB_PIXEL_FORMAT_BGRA_8888;/* dss_get_format(fb->pixel_format); */ + hal_fmt = dss_get_format(fb->format->format); DRM_DEBUG_DRIVER("channel%d: src:(%d,%d, %dx%d) crtc:(%d,%d, %dx%d), rect(%d,%d,%d,%d),fb:%dx%d, pixel_format=%d, stride=%d, paddr=0x%x, bpp=%d.\n", chn_idx, src_x, src_y, src_w, src_h, And now red and blue are swapped on my HDMI screen too. I'll compare this part with your version, but I guess the bug is on this logic. Thanks, Mauro _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF57C433E1 for ; Mon, 24 Aug 2020 06:49:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEB2B20720 for ; Mon, 24 Aug 2020 06:49:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="d8Fa9jnF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEB2B20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 16B4D6EC61; Mon, 24 Aug 2020 06:49:42 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E3C76EC61 for ; Mon, 24 Aug 2020 06:49:41 +0000 (UTC) Received: from coco.lan (unknown [95.90.213.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB28A2067C; Mon, 24 Aug 2020 06:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598251781; bh=MoR5l415tOqXO7qDvbGK3qkYCXTWIk9BbyxnSBH+NOA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d8Fa9jnF4RxQAHQUfTQiJnd1/Cv3peOrzUsQ+uvrMSfO9dxpXk5FFmL8qQR+62r2d /5Z+CzrXnWZx+hAETh664fBPlISrF9QHDL0J3KIvyrE+0W2sam4bZO9CkasBh6uuiy Lifm+3q0OlCTMYdbS1UXGwLbhr7/E/XclY5RLP1s= Date: Mon, 24 Aug 2020 08:49:30 +0200 From: Mauro Carvalho Chehab To: John Stultz Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200824084853.10560ed1@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , Sam Ravnborg , driverdevel , Daniel Borkmann , John Fastabend , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Laurentiu Palcu , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Rob Herring , Jakub Kicinski , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel , Greg Kroah-Hartman , lkml , Liuyao An , Network Development , Rongrong Zou , BPF Mailing List , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi John, Em Wed, 19 Aug 2020 20:28:44 -0700 John Stultz escreveu: > That said even with the patches I've got on top of your series, I > still see a few issues: > 1) I'm seeing red-blue swap with your driver. I need to dig a bit to > see what the difference is, I know gralloc has a config option for > this, and maybe the version of the driver I'm carrying has it wrong? Maybe it is due to this: drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c: hal_fmt = HISI_FB_PIXEL_FORMAT_BGRA_8888;/* dss_get_format(fb->pixel_format); */ It sounds to me that someone added a hack hardcoding BGRA_8888 over there. Btw, I removed the hack, with: diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c b/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c index a68db1a27bbf..ba64aae371e4 100644 --- a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c @@ -857,7 +857,7 @@ void hisi_fb_pan_display(struct drm_plane *plane) rect.right = src_w - 1; rect.top = 0; rect.bottom = src_h - 1; - hal_fmt = HISI_FB_PIXEL_FORMAT_BGRA_8888;/* dss_get_format(fb->pixel_format); */ + hal_fmt = dss_get_format(fb->format->format); DRM_DEBUG_DRIVER("channel%d: src:(%d,%d, %dx%d) crtc:(%d,%d, %dx%d), rect(%d,%d,%d,%d),fb:%dx%d, pixel_format=%d, stride=%d, paddr=0x%x, bpp=%d.\n", chn_idx, src_x, src_y, src_w, src_h, And now red and blue are swapped on my HDMI screen too. I'll compare this part with your version, but I guess the bug is on this logic. Thanks, Mauro _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel