From: Johan Hovold <johan@kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Sheng Long Wang <china_shenglong@163.com>,
Wang Sheng Long <shenglong.wang.ext@siemens.com>,
johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software flow control
Date: Mon, 24 Aug 2020 11:09:48 +0200 [thread overview]
Message-ID: <20200824090948.GC21288@localhost> (raw)
In-Reply-To: <97836b78-740b-cf70-4803-27305b6e0a4d@siemens.com>
On Fri, Aug 21, 2020 at 07:32:58AM +0200, Jan Kiszka wrote:
> On 20.08.20 09:52, Sheng Long Wang wrote:
> > From: Wang Sheng Long <shenglong.wang.ext@siemens.com>
> >
> > When data is transmitted between two serial ports,
> > the phenomenon of data loss often occurs. The two kinds
> > of flow control commonly used in serial communication
> > are hardware flow control and software flow control.
> >
> > In serial communication, If you only use RX/TX/GND Pins, you
> > can't do hardware flow. So we often used software flow control
> > and prevent data loss. The user sets the software flow control
> > through the application program, and the application program
> > sets the software flow control mode for the serial port
> > chip through the driver.
> >
> > For the cp210 serial port chip, its driver lacks the
> > software flow control setting code, so the user cannot set
> > the software flow control function through the application
> > program. This adds the missing software flow control.
> >
> > Signed-off-by: Wang Sheng Long <shenglong.wang.ext@siemens.com>
> >
> > Changes in v3:
> > -fixed code style, It mainly adjusts the code style acccording
> > to kernel specification.
>
> Patch does not apply. You forgot to rebase over latest tty/tty-next or
> linux master.
That should be the usb-next branch of the usb-serial tree:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/
or linux-next (or, currently, Linus's master branch).
You can use "scripts/get_maintainer.sh --scm" to determine which tree to
base your work against.
Johan
next prev parent reply other threads:[~2020-08-24 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 7:52 [PATCH v3] usb-serial:cp210x: add support to software flow control Sheng Long Wang
2020-08-21 5:32 ` Jan Kiszka
2020-08-24 9:09 ` Johan Hovold [this message]
2020-08-24 9:28 ` Wang, Sheng Long
2020-08-24 9:36 ` Jan Kiszka
2020-08-24 9:43 ` Johan Hovold
2020-08-24 10:16 ` Wang, Sheng Long
2020-08-24 11:16 ` Johan Hovold
2020-08-24 9:38 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824090948.GC21288@localhost \
--to=johan@kernel.org \
--cc=china_shenglong@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shenglong.wang.ext@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.