From: Mark Brown <broonie@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Qiang Zhao <qiang.zhao@nxp.com>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
Varun Sethi <V.Sethi@nxp.com>,
Tanveer Alam <tanveer.alam@puresoftware.com>
Subject: Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support
Date: Mon, 24 Aug 2020 12:25:05 +0100 [thread overview]
Message-ID: <20200824112505.GD4676@sirena.org.uk> (raw)
In-Reply-To: <20200822152118.rlwbcgfk4abjldtg@skbuf>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On Sat, Aug 22, 2020 at 06:21:18PM +0300, Vladimir Oltean wrote:
> On Sat, Aug 22, 2020 at 07:37:25PM +0530, Kuldip Dwivedi wrote:
> > > The whole point with the device property API is that it works with
> > > both DT and ACPI without needing separate parsing, though in this
> > > case I'm wondering why we'd need to specify this in an ACPI system
> > > at all?
> > Understood. Will take care in v2 PATCH
> IMO there is zero reason for the existence of the "spi-num-chipselects"
> property even for DT. We should deprecate it (start ignoring it in
> existing device tree deployments) and populate struct
> fsl_dspi_devtype_data with that info based on SoC compatible string.
Yes, it's a legacy from bad board file conversions and shouldn't be used
at all.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-24 11:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 13:10 [PATCH] spi: spi-fsl-dspi: Add ACPI support kuldip dwivedi
2020-08-21 14:07 ` Mark Brown
2020-08-22 14:07 ` Kuldip Dwivedi
2020-08-22 15:21 ` Vladimir Oltean
2020-08-24 11:25 ` Mark Brown [this message]
2020-08-26 8:19 ` Qiang Zhao
2020-08-26 10:19 ` Mark Brown
2020-08-26 11:10 ` Qiang Zhao
2020-08-26 11:47 ` Vladimir Oltean
2020-08-26 14:23 ` Mark Brown
2020-08-26 14:47 ` Vladimir Oltean
2020-08-26 15:13 ` Kuldip Dwivedi
2020-08-26 16:09 ` Vladimir Oltean
2020-08-26 17:02 ` Mark Brown
2020-08-26 18:30 ` Vladimir Oltean
2020-08-26 18:36 ` Mark Brown
2020-08-26 16:55 ` Mark Brown
2020-08-26 18:33 ` Vladimir Oltean
2020-08-26 18:42 ` Mark Brown
2020-08-21 16:49 ` kernel test robot
2020-08-21 16:49 ` kernel test robot
2020-08-22 18:33 ` Vladimir Oltean
2020-08-26 19:34 ` Andy Shevchenko
2020-08-26 19:36 ` Andy Shevchenko
2020-08-26 19:56 ` Vladimir Oltean
2020-08-26 20:41 ` Mark Brown
2020-08-26 20:41 ` Vladimir Oltean
2020-08-26 20:45 ` Mark Brown
2020-08-26 21:06 ` Vladimir Oltean
2020-08-27 11:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824112505.GD4676@sirena.org.uk \
--to=broonie@kernel.org \
--cc=V.Sethi@nxp.com \
--cc=kuldip.dwivedi@puresoftware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pankaj.bansal@nxp.com \
--cc=qiang.zhao@nxp.com \
--cc=tanveer.alam@puresoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.