All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>,
	Daniel Borkmann <borkmann@iogearbox.net>,
	Yonghong Song <yhs@fb.com>,
	brouer@redhat.com
Subject: Re: [PATCH bpf] selftests/bpf: Fix test_progs-flavor run getting number of tests
Date: Mon, 24 Aug 2020 13:57:04 +0200	[thread overview]
Message-ID: <20200824135704.2b86fc83@carbon> (raw)
In-Reply-To: <CAADnVQLA4UNsooPg7Cwk3hQU8dih6uATrOi+-V-a8b0Nb_ndWw@mail.gmail.com>

On Fri, 21 Aug 2020 12:45:08 -0700
Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:

> > diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
> > index b1e4dadacd9b..d858e883bd75 100644
> > --- a/tools/testing/selftests/bpf/test_progs.c
> > +++ b/tools/testing/selftests/bpf/test_progs.c
> > @@ -618,7 +618,7 @@ int cd_flavor_subdir(const char *exec_name)
> >         if (!flavor)
> >                 return 0;
> >         flavor++;
> > -       fprintf(stdout, "Switching to flavor '%s' subdirectory...\n", flavor);
> > +       fprintf(stderr, "Switching to flavor '%s' subdirectory...\n", flavor);  
> 
> Hmm. May be move it under -v flag instead?
> The person or script that runs test_progs-no_alu32 knows what's happening.
> That message either to stdout or stderr will be fine under extra verbose flag.

Sounds good to me with a -v flag, sending V2

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


      reply	other threads:[~2020-08-24 11:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21 15:08 [PATCH bpf] selftests/bpf: Fix test_progs-flavor run getting number of tests Jesper Dangaard Brouer
2020-08-21 19:18 ` Andrii Nakryiko
2020-08-21 19:45 ` Alexei Starovoitov
2020-08-24 11:57   ` Jesper Dangaard Brouer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824135704.2b86fc83@carbon \
    --to=brouer@redhat.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=borkmann@iogearbox.net \
    --cc=bpf@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.