All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig
Date: Tue, 25 Aug 2020 09:28:09 +0200	[thread overview]
Message-ID: <20200825092809.2d826758@endymion> (raw)
In-Reply-To: <20200820080525.2767120-1-jarkko.nikula@linux.intel.com>

On Thu, 20 Aug 2020 11:05:25 +0300, Jarkko Nikula wrote:
> The default value for a config option defaults to 'n' so it doesn't need
> to be set here.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
>  drivers/i2c/busses/Kconfig | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 085ca9b009ed..9731121ec561 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -840,7 +840,6 @@ config I2C_PASEMI
>  config I2C_PCA_PLATFORM
>  	tristate "PCA9564/PCA9665 as platform device"
>  	select I2C_ALGOPCA
> -	default n
>  	help
>  	  This driver supports a memory mapped Philips PCA9564/PCA9665
>  	  parallel bus to I2C bus controller.
> @@ -1251,7 +1250,6 @@ config I2C_TAOS_EVM
>  	depends on TTY
>  	select SERIO
>  	select SERIO_SERPORT
> -	default n
>  	help
>  	  This supports TAOS evaluation modules on serial port. In order to
>  	  use this driver, you will need the inputattach tool, which is part
> @@ -1335,7 +1333,6 @@ config I2C_PCA_ISA
>  	tristate "PCA9564/PCA9665 on an ISA bus"
>  	depends on ISA
>  	select I2C_ALGOPCA
> -	default n
>  	help
>  	  This driver supports ISA boards using the Philips PCA9564/PCA9665
>  	  parallel bus to I2C bus controller.

Definitely a good move, this was on my informal to-do list for some
time already...

Option I2C_STUB suffers from the same but uses a different syntax,
which may explain why you missed it.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support

  parent reply	other threads:[~2020-08-25  7:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  8:05 [PATCH] i2c: Remove 'default n' from busses/Kconfig Jarkko Nikula
2020-08-25  7:08 ` Wolfram Sang
2020-08-25  7:28 ` Jean Delvare [this message]
2020-08-25  7:51   ` Wolfram Sang
2020-08-25  7:58     ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825092809.2d826758@endymion \
    --to=jdelvare@suse.de \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.