From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/python-pycups: new package
Date: Tue, 25 Aug 2020 10:08:21 +0200 [thread overview]
Message-ID: <20200825100821.49937320@windsurf.home> (raw)
In-Reply-To: <CALFsTFUuBM9uJKo9Gz4jx2PV3TwwuJs5gcKySrTJih21ZHyt7Q@mail.gmail.com>
Hello Asaf,
Thanks for reviewing!
On Tue, 25 Aug 2020 09:41:28 +0300
Asaf Kahlon <asafka7@gmail.com> wrote:
> > + bool "python-pycups"
> > + depends on BR2_PACKAGE_CUPS
> Since this package wraps the CUPS API and uses the cups package, you
> should select BR2_PACKAGE_CUPS instead of depending on it (and add the
> additional "depends on" sections from cups).
I perhaps wouldn't be so strict on this. When a dependency is
"obvious", it is quite OK to have a "depends on". In this case, I
believe the user who wants python-pycups will realize that CUPS is
needed in the system, so I find a "depends on" dependency to be quite
OK in this case. Using "depends on" has the advantage that we don't
have to replicate the "depends on" from BR2_PACKAGE_CUPS.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-08-25 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 21:48 [Buildroot] [PATCH 1/1] package/python-pycups: new package Joseph Kogut
2020-08-25 6:41 ` Asaf Kahlon
2020-08-25 8:08 ` Thomas Petazzoni [this message]
2020-08-25 10:55 ` Asaf Kahlon
2020-08-25 11:07 ` Thomas Petazzoni
2020-08-25 11:29 ` Asaf Kahlon
2020-08-25 23:14 ` Joseph Kogut
2020-12-05 21:32 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825100821.49937320@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.