Re: [bug report] mm,hwpoison: refactor soft_offline_huge_page and __soft_offline_page

[Oscar Salvador <osalvador@suse.de>]

On Tue, Aug 25, 2020 at 12:35:17PM +0200, Oscar Salvador wrote:
> > mm/memory-failure.c
> >   1749  static bool isolate_page(struct page *page, struct list_head *pagelist)
> >   1750  {
> >   1751          bool isolated = false;
> >   1752          bool lru = PageLRU(page);
> >   1753  
> >   1754          if (PageHuge(page)) {
> >   1755                  isolated = isolate_huge_page(page, pagelist);
> >   1756          } else {
> >   1757                  if (lru)
> >   1758                          isolated = !isolate_lru_page(page);
> >   1759                  else
> >   1760                          isolated = !isolate_movable_page(page, ISOLATE_UNEVICTABLE);
> >   1761  
> >   1762                  if (isolated)
> >   1763                          list_add(&page->lru, pagelist);
> >   1764  
> >   1765                  return -EBUSY;
> > 
> > return false;?
> 
> No, I this is a mistake, I guess it popped there when Naoya rebased.
> 
> That return -EBUSY should be go.
> I'll let Andrew know, thanks.

Unless I'm blind, it seems it wasn't Naoya's mistake either [1]

@Andrew, any idea what happened here? That "return -EBUSY" should not be there.

[1] https://patchwork.kernel.org/patch/11704101/

-- 
Oscar Salvador
SUSE L3