From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:4841:0:0:0:0:0 with SMTP id 1csp3333535lfy; Tue, 25 Aug 2020 04:09:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1mRrgS4KBhydKQPJidJF8scj4Casl3iGIJGdT55HwFf8CJOwS6TOV2Mx0dq531zymZyHT X-Received: by 2002:a5b:602:: with SMTP id d2mr13971239ybq.451.1598353745676; Tue, 25 Aug 2020 04:09:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598353745; cv=none; d=google.com; s=arc-20160816; b=Y137og1BByBJrWNkRwAOpb2tKIsg5c+JPILjx2qkHDBCFJ9TL+Hr08mnUv/LmOE5Bq QbBXx/V+6+U6OThsnwLNIMT1c0Lqc0tHU3+E1FWBAiBEUw3KQSvI/ojxCOoqY764u0I6 1A5EImLIE0Mqg33h8cgj9mHjlkqg5WjHpl8o2TArihHOklLr8ZRo0gwv+0Srhx/RamJ4 TIJaK2VzBFcoT6CHvT2Sl4Fbt9vxmxrUe7gvcqW78SanFcTSrp1doI0wM1XiS6WzOONP CdcRG+wL5WwztqJPUZFeBeism2uzI4AsBFjc7Ip1ocFouXL54CILDs2I7QHJC2SbOkSR rWgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:content-transfer-encoding:user-agent :in-reply-to:mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=lLvrkff4jEO5m823rODYTpT4QRQkMv5vytNspHTCsMQ=; b=YUuB7+CfP3TZNdZ6lu26+jcdgTyGmGxl6j5kIU6lqSMcRp2lxa9Sp8zN5Dw4PF2bPp G1jmsk7PlxFMNzLM80KILgzOICxt7L/WzBmMaR46R/2H/J33k27UqeRiImnWuntOBJ1x roSrNIYquKRyMsrQzh/jz7zpkB4iLcjQjTwqf/VBMT9Fxfvf8tOMpQNyk3AEa2D7DyFh bgt6mEZosdfTgS661DvZVwsKVHNBPmKWXpHE2YZ9bnNMrokEHF/3Fn9Sn8oNn8FKZwOp 5187XkQGFCCh791dq/DxWgvSu0VPuJyEBq2mCzRc5lEFROD1Ve6lkktAp/7xOgIi+Kj0 iTGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="L//DcZt5"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 206si14297864ybb.62.2020.08.25.04.09.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Aug 2020 04:09:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="L//DcZt5"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:43288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAWp7-0004zs-3b for alex.bennee@linaro.org; Tue, 25 Aug 2020 07:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAWoz-0004yQ-S9 for qemu-arm@nongnu.org; Tue, 25 Aug 2020 07:08:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kAWoy-0003ho-9G for qemu-arm@nongnu.org; Tue, 25 Aug 2020 07:08:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598353735; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLvrkff4jEO5m823rODYTpT4QRQkMv5vytNspHTCsMQ=; b=L//DcZt5WsYzkn0CFo/pK8sLme+FlqXJtDf5mMwLVjstmjsmUrnfvLRqYuTUUjbV8YL1va pYBiTAjTYuB8M4LfGi9H+mV6rY5mLwbsZSRTCCtBlgnDKPNfdR2vQfy5ZQ2TKriJIASm1i cSADrxQbSWoTlFSJbRqSqajVTXQXqMk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-iOiKp1kRNw-wQpGVjslkjg-1; Tue, 25 Aug 2020 07:08:51 -0400 X-MC-Unique: iOiKp1kRNw-wQpGVjslkjg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B61DA189E600; Tue, 25 Aug 2020 11:08:49 +0000 (UTC) Received: from redhat.com (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8AB0808AA; Tue, 25 Aug 2020 11:08:46 +0000 (UTC) Date: Tue, 25 Aug 2020 12:08:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eduardo Habkost Subject: Re: [PATCH v2 06/58] aspeed_soc: Rename memmap/irqmap enum constants Message-ID: <20200825110844.GN107278@redhat.com> References: <20200820001236.1284548-1-ehabkost@redhat.com> <20200820001236.1284548-7-ehabkost@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200820001236.1284548-7-ehabkost@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/25 02:03:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.958, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Andrew Jeffery , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Joel Stanley , Paolo Bonzini , =?utf-8?Q?C=C3=A9dric?= Le Goater Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: uElOpEmWhzkT On Wed, Aug 19, 2020 at 08:11:44PM -0400, Eduardo Habkost wrote: > Some of the enum constant names conflict with the QOM type check > macros: > > ASPEED_GPIO > ASPEED_I2C > ASPEED_RTC > ASPEED_SCU > ASPEED_SDHCI > ASPEED_SDMC > ASPEED_VIC > ASPEED_WDT > ASPEED_XDMA > > This needs to be addressed to allow us to transform the QOM type > check macros into functions generated by OBJECT_DECLARE_TYPE(). > > Rename all the constants to ASPEED_DEV_*, to avoid conflicts. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Added more details to commit message > > --- > Cc: "Cédric Le Goater" > Cc: Peter Maydell > Cc: Andrew Jeffery > Cc: Joel Stanley > Cc: qemu-arm@nongnu.org > Cc: qemu-devel@nongnu.org > --- > include/hw/arm/aspeed_soc.h | 92 +++++++-------- > hw/arm/aspeed.c | 4 +- > hw/arm/aspeed_ast2600.c | 208 ++++++++++++++++---------------- > hw/arm/aspeed_soc.c | 228 ++++++++++++++++++------------------ > 4 files changed, 266 insertions(+), 266 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|