From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E12C433DF for ; Tue, 25 Aug 2020 09:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2A572075B for ; Tue, 25 Aug 2020 09:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728377AbgHYJxy convert rfc822-to-8bit (ORCPT ); Tue, 25 Aug 2020 05:53:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:50584 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbgHYJxx (ORCPT ); Tue, 25 Aug 2020 05:53:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CC3FDAD1B; Tue, 25 Aug 2020 09:54:22 +0000 (UTC) Date: Tue, 25 Aug 2020 11:53:42 +0200 From: Jean Delvare To: Bjorn Helgaas Cc: Vaibhav Gupta , Bjorn Helgaas , Vaibhav Gupta , Tomoya MORINAGA , Tomoya MORINAGA , Linus Walleij , Ben Dooks , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan , Jean Delvare Subject: Re: [PATCH v2 2/2] i2c: eg20t: use generic power management Message-ID: <20200825115342.16ab9004@endymion> In-Reply-To: <20200807202321.GA753887@bjorn-Precision-5520> References: <20200805193616.384313-3-vaibhavgupta40@gmail.com> <20200807202321.GA753887@bjorn-Precision-5520> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Bjorn, Vaibhav, On Fri, 07 Aug 2020 15:23:21 -0500, Bjorn Helgaas wrote: > Also, i801_suspend() looks suspicious because it writes SMBHSTCFG, but > I don't see anything corresponding in i801_resume(). You're right, it's buggy. Volker Rümelin's patch at: https://patchwork.ozlabs.org/project/linux-i2c/patch/a2fc5a6d-a3bf-eaf0-bb75-1521be346333@googlemail.com/ should fix it. I was supposed to review it but did not, shame on me. I'll do it today. -- Jean Delvare SUSE L3 Support From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E2FC433E1 for ; Tue, 25 Aug 2020 09:54:00 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6A8A2071E for ; Tue, 25 Aug 2020 09:54:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6A8A2071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 78384865C1; Tue, 25 Aug 2020 09:54:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZhKtfmFEW9lo; Tue, 25 Aug 2020 09:53:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 98E6286637; Tue, 25 Aug 2020 09:53:56 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 804B2C016F; Tue, 25 Aug 2020 09:53:56 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7075CC0051 for ; Tue, 25 Aug 2020 09:53:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5F64688236 for ; Tue, 25 Aug 2020 09:53:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iPtT+LtdPjva for ; Tue, 25 Aug 2020 09:53:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2C9458820F for ; Tue, 25 Aug 2020 09:53:54 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CC3FDAD1B; Tue, 25 Aug 2020 09:54:22 +0000 (UTC) Date: Tue, 25 Aug 2020 11:53:42 +0200 From: Jean Delvare To: Bjorn Helgaas Message-ID: <20200825115342.16ab9004@endymion> In-Reply-To: <20200807202321.GA753887@bjorn-Precision-5520> References: <20200805193616.384313-3-vaibhavgupta40@gmail.com> <20200807202321.GA753887@bjorn-Precision-5520> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Cc: Jean Delvare , Vaibhav Gupta , Linus Walleij , Tomoya MORINAGA , linux-kernel@vger.kernel.org, Tomoya MORINAGA , Ben Dooks , linux-i2c@vger.kernel.org, Bjorn Helgaas , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH v2 2/2] i2c: eg20t: use generic power management X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" SGkgQmpvcm4sIFZhaWJoYXYsCgpPbiBGcmksIDA3IEF1ZyAyMDIwIDE1OjIzOjIxIC0wNTAwLCBC am9ybiBIZWxnYWFzIHdyb3RlOgo+IEFsc28sIGk4MDFfc3VzcGVuZCgpIGxvb2tzIHN1c3BpY2lv dXMgYmVjYXVzZSBpdCB3cml0ZXMgU01CSFNUQ0ZHLCBidXQKPiBJIGRvbid0IHNlZSBhbnl0aGlu ZyBjb3JyZXNwb25kaW5nIGluIGk4MDFfcmVzdW1lKCkuCgpZb3UncmUgcmlnaHQsIGl0J3MgYnVn Z3kuIFZvbGtlciBSw7xtZWxpbidzIHBhdGNoIGF0OgoKaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJz Lm9yZy9wcm9qZWN0L2xpbnV4LWkyYy9wYXRjaC9hMmZjNWE2ZC1hM2JmLWVhZjAtYmI3NS0xNTIx YmUzNDYzMzNAZ29vZ2xlbWFpbC5jb20vCgpzaG91bGQgZml4IGl0LiBJIHdhcyBzdXBwb3NlZCB0 byByZXZpZXcgaXQgYnV0IGRpZCBub3QsIHNoYW1lIG9uIG1lLgpJJ2xsIGRvIGl0IHRvZGF5LgoK LS0gCkplYW4gRGVsdmFyZQpTVVNFIEwzIFN1cHBvcnQKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXgta2VybmVsLW1lbnRlZXMgbWFpbGluZyBsaXN0 CkxpbnV4LWtlcm5lbC1tZW50ZWVzQGxpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9s aXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgta2VybmVsLW1l bnRlZXMK