From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, yebin <yebin10@huawei.com>,
Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH RFC 2/2] block: Do not discard buffers under a mounted filesystem
Date: Tue, 25 Aug 2020 13:16:16 +0100 [thread overview]
Message-ID: <20200825121616.GA10294@infradead.org> (raw)
In-Reply-To: <20200825120554.13070-3-jack@suse.cz>
On Tue, Aug 25, 2020 at 02:05:54PM +0200, Jan Kara wrote:
> Discarding blocks and buffers under a mounted filesystem is hardly
> anything admin wants to do. Usually it will confuse the filesystem and
> sometimes the loss of buffer_head state (including b_private field) can
> even cause crashes like:
Doesn't work if the file system uses multiple devices. I think we
just really need to split the fs buffer_head address space from the
block device one. Everything else is just going to cause a huge mess.
next prev parent reply other threads:[~2020-08-25 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 12:05 [PATCH RFC 0/2] Block and buffer invalidation under a filesystem Jan Kara
2020-08-25 12:05 ` [PATCH RFC 1/2] fs: Don't invalidate page buffers in block_write_full_page() Jan Kara
2020-08-25 12:05 ` [PATCH RFC 2/2] block: Do not discard buffers under a mounted filesystem Jan Kara
2020-08-25 12:16 ` Christoph Hellwig [this message]
2020-08-25 14:10 ` Theodore Y. Ts'o
2020-08-25 15:12 ` Jan Kara
2020-08-25 18:41 ` Matthew Wilcox
2020-08-25 18:49 ` Jan Kara
2020-08-25 14:50 ` Jan Kara
2020-08-27 7:16 ` Christoph Hellwig
2020-08-27 21:39 ` Al Viro
2020-08-28 0:07 ` Dave Chinner
2020-08-28 8:10 ` Jan Kara
2020-08-28 8:21 ` Andreas Dilger
2020-08-29 6:40 ` Christoph Hellwig
2020-08-31 7:48 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825121616.GA10294@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.