From: Cornelia Huck <cohuck@redhat.com>
To: Marc Hartmayer <mhartmay@linux.ibm.com>
Cc: <kvm@vger.kernel.org>, Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Andrew Jones <drjones@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2 2/2] Use same test names in the default and the TAP13 output format
Date: Tue, 25 Aug 2020 14:13:12 +0200 [thread overview]
Message-ID: <20200825141312.07f52184.cohuck@redhat.com> (raw)
In-Reply-To: <20200825102036.17232-3-mhartmay@linux.ibm.com>
On Tue, 25 Aug 2020 12:20:36 +0200
Marc Hartmayer <mhartmay@linux.ibm.com> wrote:
> Use the same test names in the TAP13 output as in the default output
> format. This makes the output more consistent. To achieve this, we
> need to pass the test name as an argument to the function
> `process_test_output`.
>
> Before this change:
> $ ./run_tests.sh
> PASS selftest-setup (14 tests)
> ...
>
> vs.
>
> $ ./run_tests.sh -t
> TAP version 13
> ok 1 - selftest: true
> ok 2 - selftest: argc == 3
> ...
>
> After this change:
> $ ./run_tests.sh
> PASS selftest-setup (14 tests)
> ...
>
> vs.
>
> $ ./run_tests.sh -t
> TAP version 13
> ok 1 - selftest-setup: selftest: true
> ok 2 - selftest-setup: selftest: argc == 3
> ...
>
> While at it, introduce a local variable `kernel` in
> `RUNTIME_log_stdout` since this makes the function easier to read.
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> ---
> run_tests.sh | 15 +++++++++------
> scripts/runtime.bash | 6 +++---
> 2 files changed, 12 insertions(+), 9 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-08-25 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 10:20 [kvm-unit-tests PATCH v2 0/2] Use same test names in the default and the TAP13 output format Marc Hartmayer
2020-08-25 10:20 ` [kvm-unit-tests PATCH v2 1/2] runtime.bash: remove outdated comment Marc Hartmayer
2020-08-25 13:25 ` Thomas Huth
2020-08-25 10:20 ` [kvm-unit-tests PATCH v2 2/2] Use same test names in the default and the TAP13 output format Marc Hartmayer
2020-08-25 12:13 ` Cornelia Huck [this message]
2020-08-25 13:49 ` Marc Hartmayer
2020-08-25 13:32 ` Thomas Huth
2020-08-25 13:49 ` Marc Hartmayer
2020-09-15 9:38 ` [kvm-unit-tests PATCH v2 0/2] " Marc Hartmayer
2020-09-22 8:53 ` Thomas Huth
2020-09-22 9:22 ` Marc Hartmayer
2020-09-22 14:59 ` Paolo Bonzini
2020-09-22 14:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825141312.07f52184.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.