From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F07C433DF for ; Tue, 25 Aug 2020 15:17:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B758E20786 for ; Tue, 25 Aug 2020 15:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598368628; bh=3342eHQfGiqySCJ60Rokb2k+MC9TEiCx/jzHQWkDUHA=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=iPU30bmcY8YsVMn4t7d8MFB9W1n1XwJzZkV81deOa0utmNkPf1ejBV7oGaI9olkpT pWmR1LLYREIxye19+1LvLBlj7DkrcRP2dXTDTFPyCDEObXje7oZtKUaVwf7KRi3yQI V8gNoO2XDEqL3ZAbiAFsHLEBXjQD6jYKczQxzBCU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726113AbgHYPQ7 (ORCPT ); Tue, 25 Aug 2020 11:16:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:46054 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbgHYPQ5 (ORCPT ); Tue, 25 Aug 2020 11:16:57 -0400 Received: from localhost (104.sub-72-107-126.myvzw.com [72.107.126.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08B0720578; Tue, 25 Aug 2020 15:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598368617; bh=3342eHQfGiqySCJ60Rokb2k+MC9TEiCx/jzHQWkDUHA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=JMrka61eIH7XVw89wAecQ8ru9OT64OXexK91IvBcpq2DVeAmVBMHoYk5GxMeX4Ews n6xRqPYpkh9aLAucYd40fqQHSL44WIZ7XyZ0wbA6D/V1R7itkxp08qbJCrx5kdKmBl FGsC6FGD54nSxX2VYY4pFwZx/WV2PeTHGWyEKseM= Date: Tue, 25 Aug 2020 10:16:55 -0500 From: Bjorn Helgaas To: Jean Delvare Cc: Vaibhav Gupta , Bjorn Helgaas , Vaibhav Gupta , Tomoya MORINAGA , Tomoya MORINAGA , Linus Walleij , Ben Dooks , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan , Jean Delvare Subject: Re: [PATCH v2 2/2] i2c: eg20t: use generic power management Message-ID: <20200825151655.GA1913382@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200825115342.16ab9004@endymion> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Tue, Aug 25, 2020 at 11:53:42AM +0200, Jean Delvare wrote: > Hi Bjorn, Vaibhav, > > On Fri, 07 Aug 2020 15:23:21 -0500, Bjorn Helgaas wrote: > > Also, i801_suspend() looks suspicious because it writes SMBHSTCFG, but > > I don't see anything corresponding in i801_resume(). > > You're right, it's buggy. Volker Rümelin's patch at: > > https://patchwork.ozlabs.org/project/linux-i2c/patch/a2fc5a6d-a3bf-eaf0-bb75-1521be346333@googlemail.com/ > > should fix it. I was supposed to review it but did not, shame on me. > I'll do it today. Always nice when the fix is already there :) Thanks for following up on this! Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE64C433E3 for ; Tue, 25 Aug 2020 15:16:59 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B86A62075F for ; Tue, 25 Aug 2020 15:16:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JMrka61e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B86A62075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 76D0C88457; Tue, 25 Aug 2020 15:16:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25GCHyFvEwiB; Tue, 25 Aug 2020 15:16:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 1210D882AC; Tue, 25 Aug 2020 15:16:59 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F0128C07FF; Tue, 25 Aug 2020 15:16:58 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2FB54C0051 for ; Tue, 25 Aug 2020 15:16:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 07DA622721 for ; Tue, 25 Aug 2020 15:16:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kq0pO0cRfFPB for ; Tue, 25 Aug 2020 15:16:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id 77AF720104 for ; Tue, 25 Aug 2020 15:16:57 +0000 (UTC) Received: from localhost (104.sub-72-107-126.myvzw.com [72.107.126.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08B0720578; Tue, 25 Aug 2020 15:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598368617; bh=3342eHQfGiqySCJ60Rokb2k+MC9TEiCx/jzHQWkDUHA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=JMrka61eIH7XVw89wAecQ8ru9OT64OXexK91IvBcpq2DVeAmVBMHoYk5GxMeX4Ews n6xRqPYpkh9aLAucYd40fqQHSL44WIZ7XyZ0wbA6D/V1R7itkxp08qbJCrx5kdKmBl FGsC6FGD54nSxX2VYY4pFwZx/WV2PeTHGWyEKseM= Date: Tue, 25 Aug 2020 10:16:55 -0500 From: Bjorn Helgaas To: Jean Delvare Message-ID: <20200825151655.GA1913382@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200825115342.16ab9004@endymion> Cc: Jean Delvare , Vaibhav Gupta , Linus Walleij , Tomoya MORINAGA , linux-kernel@vger.kernel.org, Tomoya MORINAGA , Ben Dooks , linux-i2c@vger.kernel.org, Bjorn Helgaas , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH v2 2/2] i2c: eg20t: use generic power management X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Tue, Aug 25, 2020 at 11:53:42AM +0200, Jean Delvare wrote: > Hi Bjorn, Vaibhav, > = > On Fri, 07 Aug 2020 15:23:21 -0500, Bjorn Helgaas wrote: > > Also, i801_suspend() looks suspicious because it writes SMBHSTCFG, but > > I don't see anything corresponding in i801_resume(). > = > You're right, it's buggy. Volker R=FCmelin's patch at: > = > https://patchwork.ozlabs.org/project/linux-i2c/patch/a2fc5a6d-a3bf-eaf0-b= b75-1521be346333@googlemail.com/ > = > should fix it. I was supposed to review it but did not, shame on me. > I'll do it today. Always nice when the fix is already there :) Thanks for following up on this! Bjorn _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees