From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F59FC433E1 for ; Tue, 25 Aug 2020 15:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCEDC2067C for ; Tue, 25 Aug 2020 15:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598370350; bh=J9j8I9e1vUqi85jVzVhKCQp3T2bITZExUCsPWzEeIMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yJVyJ7V4wtJbYO11I8POpOPxhZsxaaqVHLguE/v73rM8+RkIeS8E32yxak5UlXLEt DFS/qQd8Au6VlxLQOSdoWojV38+ij62k418/d3aAcAQGE6MMb1Lzb/w62t4YvKhRqG 0j8eb4x3gW6FWgyZ/rR4nkNZTBpgzeX0S9dW7Y0o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbgHYPpt (ORCPT ); Tue, 25 Aug 2020 11:45:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:59136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbgHYPpc (ORCPT ); Tue, 25 Aug 2020 11:45:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BE0B2067C; Tue, 25 Aug 2020 15:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598370332; bh=J9j8I9e1vUqi85jVzVhKCQp3T2bITZExUCsPWzEeIMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gG9TpcopdDPeldxrfc0Zu7ErcQ5JJWy+leFqtjDc70tZWHAi5s+8DFQXXAsjz773L wERo5NQnTdjXgOQq98zX+bvyzyTHDrzvasAanvQi8RcWgkc+16TbKS44Kgava5ZhPf ZdDKV43+uH7FmJaCWC55FS1sggD3EclaIyA6Urpc= Date: Tue, 25 Aug 2020 17:45:48 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Qu Wenruo , Heikki Krogerus Subject: Re: [PATCH v2] kobject: Restore old behaviour of kobject_del(NULL) Message-ID: <20200825154548.GA1514525@kroah.com> References: <20200803082706.65347-1-andriy.shevchenko@linux.intel.com> <20200803094659.GB635660@kroah.com> <20200825144109.GN1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825144109.GN1891694@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 25, 2020 at 05:41:09PM +0300, Andy Shevchenko wrote: > On Mon, Aug 03, 2020 at 11:46:59AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Aug 03, 2020 at 11:27:06AM +0300, Andy Shevchenko wrote: > > > The commit 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in > > > kobject_cleanup()") inadvertently dropped a possibility to call kobject_del() > > > with NULL pointer. Restore the old behaviour. > > > > > > Fixes: 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in kobject_cleanup()") > > > Reported-by: Qu Wenruo > > > Cc: Heikki Krogerus > > > Signed-off-by: Andy Shevchenko > > > --- > > > v2: replaced ?: with plain conditional (Greg) > > > lib/kobject.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > Thanks, much better, will queue up after -rc1 is out. > > Shouldn't be this taken care of? Yes, will get to it soon, after -rc1 is tough, combined with Plumbers... greg k-h