All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Stefan Weil" <sw@weilnetz.de>
Subject: Re: [PATCH 5/5] meson: add NSIS building
Date: Tue, 25 Aug 2020 17:07:48 +0100	[thread overview]
Message-ID: <20200825160748.GB107278@redhat.com> (raw)
In-Reply-To: <CAFEAcA_b3aGS8TFB3V6mNwxi7xG6MGNwqtnt9=XpEve+OHQQEw@mail.gmail.com>

On Tue, Aug 25, 2020 at 05:03:41PM +0100, Peter Maydell wrote:
> On Tue, 25 Aug 2020 at 16:14, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > This is a verbose way of saying I think you should create a
> > nsis.py, not nsis.sh, to avoid the inherant portability problems of
> > shell that hit us over and over and over again.
> 
> Does it have to be a separate script, or can we just write inline
> Python in the meson file? The main reason the current code is
> written in shell is because that's what you need to write it in
> so you can write it inline in a Makefile, and because half of
> it is "invoke this other command ($(SIGNCODE), makensis, etc)",
> which is what build systems are good at.

Meson just wants to have a command path + list of arguments.

So if you want to have the python code inline you can do that by passing
it as an arg by telling meson to run "python -e <codeblob>".

I think that's only sensible for one-liner scripts though. Otherwise it
is nicer to have a separate script that you can invoke directly for
testing / debugging purposes separately from meson.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2020-08-25 16:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 15:04 [PATCH 0/5] meson: mingw installation fixes & nsis conversion marcandre.lureau
2020-08-25 15:04 ` [PATCH 1/5] meson: pass confsuffix option marcandre.lureau
2020-08-25 15:04 ` [PATCH 2/5] meson: use meson datadir instead of qemu_datadir marcandre.lureau
2020-08-25 15:04 ` [PATCH 3/5] meson: add docdir option and pass pre-prefix qemu_docdir marcandre.lureau
2020-08-25 15:04 ` [PATCH 4/5] meson: use meson mandir instead of qemu_mandir marcandre.lureau
2020-08-25 15:04 ` [PATCH 5/5] meson: add NSIS building marcandre.lureau
2020-08-25 15:11   ` Daniel P. Berrangé
2020-08-25 16:03     ` Peter Maydell
2020-08-25 16:07       ` Daniel P. Berrangé [this message]
2020-08-25 16:11   ` Peter Maydell
2020-08-25 16:38 ` [PATCH 0/5] meson: mingw installation fixes & nsis conversion Paolo Bonzini
2020-08-25 16:49   ` Marc-André Lureau
2020-08-25 18:14     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825160748.GB107278@redhat.com \
    --to=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.