From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by mx.groups.io with SMTP id smtpd.web10.264.1598373949248850996 for ; Tue, 25 Aug 2020 09:45:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ti.com header.s=ti-com-17q1 header.b=YIZM6+ju; spf=pass (domain: ti.com, ip: 198.47.19.141, mailfrom: denys@ti.com) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 07PGjmeA103917 for ; Tue, 25 Aug 2020 11:45:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1598373948; bh=LXyRjrcuuxOZNOqM1e5gvVOZ4YAJy99vqKDLEXNEjag=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=YIZM6+juBiklvYqk2NB96hw4KcEtA5mgyue4ZRdpNODEU6PYSyeG07RtTwSMwKIGS mAz7QCVEZ+W0OzHkeGlgDEiS6Bg6MOdKelJfbx+vADY+tody1CglDQbFNSVBhvrgqY 9bkSTSPaUeodUnjSFft2UGWMO9MsjnBXyUEaVrmQ= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 07PGjmkl050623 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 25 Aug 2020 11:45:48 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 25 Aug 2020 11:45:47 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 25 Aug 2020 11:45:47 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07PGjlXd030549; Tue, 25 Aug 2020 11:45:47 -0500 Date: Tue, 25 Aug 2020 12:45:47 -0400 From: "Denys Dmytriyenko" To: Suman Anna CC: Lokesh Vutla , , Sekhar Nori , , Subject: Re: [PATCH 2/3] prueth-fw: Package the firmware images from ti-linux-firmware Message-ID: <20200825164547.GA23638@beryl> References: <20200821073238.18926-1-lokeshvutla@ti.com> <20200821073238.18926-3-lokeshvutla@ti.com> <20200821185314.GK29812@beryl> <99a37ab2-9c6f-bfb9-6174-907901bdd819@ti.com> MIME-Version: 1.0 In-Reply-To: <99a37ab2-9c6f-bfb9-6174-907901bdd819@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Aug 24, 2020 at 10:29:40AM -0500, Suman Anna wrote: > Hi Denys, > > On 8/21/20 1:53 PM, Denys Dmytriyenko wrote: > > On Fri, Aug 21, 2020 at 01:02:37PM +0530, Lokesh Vutla wrote: > >> Directly take the images from ti-linux-firmware instead of using pdk > >> Aldo drop build for k2g as firmwares are not yet available. > > > > Same comment for the version/PV use. > > > > Also, are there any alternatives that need to be setup with symlinks for these > > firmware images and PRU in general? E.g. pru-icss sets symlinks am335x-pru0-fw > > and am57xx-pru1_0-fw to point to Halt vs. Echo images. Is this needed for > > prueth, pruhsr, pruprp or prusw images? Suman? > > PRU firmwares follow a mixed-style. The PRU remoteproc drivers do not support > remoteproc auto-boot and can let the PRU client drivers set the firmware name > (either through DT or coded up in the driver) before booting the corresponding > remoteprocs. PRU Ethernet follows the latter option, and chooses the right > firmware depending on the protocol it is configured for. The firmware names used > by the PRU remoteproc driver is therefore less relevant when compared to the > other remoteproc drivers. Thanks, Suman, sounds good. > regards > Suman > > > > > > >> Signed-off-by: Lokesh Vutla > >> --- > >> recipes-bsp/prueth-fw/prueth-fw_5.2.7.bb | 38 ++++++++++++++++ > >> recipes-bsp/prueth-fw/prueth-fw_git.bb | 47 -------------------- > >> recipes-kernel/linux/linux-ti-staging_5.4.bb | 1 - > >> 3 files changed, 38 insertions(+), 48 deletions(-) > >> create mode 100644 recipes-bsp/prueth-fw/prueth-fw_5.2.7.bb > >> delete mode 100644 recipes-bsp/prueth-fw/prueth-fw_git.bb > >> > >> diff --git a/recipes-bsp/prueth-fw/prueth-fw_5.2.7.bb b/recipes-bsp/prueth-fw/prueth-fw_5.2.7.bb > >> new file mode 100644 > >> index 00000000..1847c221 > >> --- /dev/null > >> +++ b/recipes-bsp/prueth-fw/prueth-fw_5.2.7.bb > >> @@ -0,0 +1,38 @@ > >> +DESCRIPTION = "PRU Ethernet firmware for AM57xx, AM437x and AM335x" > > > > Use SUMMARY instead. > > > > > >> +LICENSE = "TI-TFL" > >> +LIC_FILES_CHKSUM = "file://LICENSE.ti;md5=b5aebf0668bdf95621259288c4a46d76" > >> + > >> +PV = "5.2.7" > >> +PR = "r1" > > > > Please drop PR for the new recipe. > > > > > >> +CLEANBROKEN = "1" > >> + > >> +COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx-evm|am57xx-hs-evm" > >> + > >> +PACKAGE_ARCH = "${MACHINE_ARCH}" > >> + > >> +SRCREV = "7ba9722b74608ad4472790972917e1205eb3c049" > >> +BRANCH ?= "ti-linux-firmware" > >> + > >> +SRC_URI = "git://git.ti.com/processor-firmware/ti-linux-firmware.git;protocol=git;branch=${BRANCH}" > >> + > >> +S = "${WORKDIR}/git" > >> + > >> +TARGET = "" > >> +TARGET_ti33x = "am335x-pru0-prueth-fw.elf am335x-pru1-prueth-fw.elf" > >> +TARGET_ti43x = "am437x-pru0-prueth-fw.elf am437x-pru1-prueth-fw.elf" > >> +TARGET_am57xx-evm = "am57xx-pru0-prueth-fw.elf am57xx-pru1-prueth-fw.elf" > >> +TARGET_am57xx-hs-evm = "am57xx-pru0-prueth-fw.elf am57xx-pru1-prueth-fw.elf" > >> + > >> +do_install() { > >> + install -d ${D}${base_libdir}/firmware/ti-pruss > >> + for f in ${TARGET}; do > >> + install -m 0644 ${S}/ti-pruss/$f ${D}${base_libdir}/firmware/ti-pruss/$f > >> + done > >> +} > >> + > >> + > >> +FILES_${PN} = "${base_libdir}/firmware" > >> + > >> +INSANE_SKIP_${PN} = "arch" > >> diff --git a/recipes-bsp/prueth-fw/prueth-fw_git.bb b/recipes-bsp/prueth-fw/prueth-fw_git.bb > >> deleted file mode 100644 > >> index f7718ad2..00000000 > >> --- a/recipes-bsp/prueth-fw/prueth-fw_git.bb > >> +++ /dev/null > >> @@ -1,47 +0,0 @@ > >> -DESCRIPTION = "PRU Ethernet firmware for AM57xx, AM437x, AM335x and K2G" > >> - > >> -require recipes-ti/includes/ti-paths.inc > >> -require recipes-bsp/icss-emac-lld/icss-emac-lld.inc > >> - > >> -LICENSE = "TI-TFL" > >> -LIC_FILES_CHKSUM = "file://icss_dualemac/src/firmware_version.h;beginline=6;endline=53;md5=1f0a640a261059cdcbbcf01e6a739ff3" > >> - > >> -PR = "${INC_PR}.0" > >> - > >> -TI_PDK_COMP = "ti.drv.icss_emac.firmware" > >> - > >> -B = "${S}/icss_dualemac" > >> - > >> -COMPATIBLE_MACHINE = "am57xx-evm|am57xx-hs-evm|ti43x|ti33x|k2g" > >> - > >> -PACKAGE_ARCH = "${MACHINE_ARCH}" > >> - > >> -DEPENDS = "ti-cgt-pru-native" > >> - > >> -PRU_VERSION = "" > >> -PRU_VERSION_ti33x = "REV1" > >> -PRU_VERSION_ti43x = "REV1" > >> -PRU_VERSION_am57xx-evm = "REV2" > >> -PRU_VERSION_am57xx-hs-evm = "REV2" > >> -PRU_VERSION_k2g = "REV2" > >> - > >> -FW_PREFIX = "" > >> -FW_PREFIX_ti33x = "am335x" > >> -FW_PREFIX_ti43x = "am437x" > >> -FW_PREFIX_am57xx-evm = "am57xx" > >> -FW_PREFIX_am57xx-hs-evm = "am57xx" > >> -FW_PREFIX_k2g = "k2g" > >> - > >> -EXTRA_OEMAKE += "CL_PRU_INSTALL_PATH="${TI_CGT_PRU_INSTALL_DIR}" PRU_VERSION_LIST="${PRU_VERSION}"" > >> - > >> -do_install() { > >> - install -d ${D}${base_libdir}/firmware/ti-pruss > >> - install -m 0644 ./elf/${PRU_VERSION}/icss_dualemac_PRU0.elf \ > >> - ${D}${base_libdir}/firmware/ti-pruss/${FW_PREFIX}-pru0-prueth-fw.elf > >> - install -m 0644 ./elf/${PRU_VERSION}/icss_dualemac_PRU1.elf \ > >> - ${D}${base_libdir}/firmware/ti-pruss/${FW_PREFIX}-pru1-prueth-fw.elf > >> -} > >> - > >> -FILES_${PN} = "${base_libdir}/firmware" > >> - > >> -INSANE_SKIP_${PN} = "arch" > >> diff --git a/recipes-kernel/linux/linux-ti-staging_5.4.bb b/recipes-kernel/linux/linux-ti-staging_5.4.bb > >> index 3a4fdd86..2a35bf1d 100644 > >> --- a/recipes-kernel/linux/linux-ti-staging_5.4.bb > >> +++ b/recipes-kernel/linux/linux-ti-staging_5.4.bb > >> @@ -48,7 +48,6 @@ RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am57xx-evm = " prueth-fw prusw-fw pr > >> RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am57xx-hs-evm = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" > >> RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti43x = " prueth-fw pruhsr-fw pruprp-fw" > >> RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti33x = " prueth-fw pruhsr-fw pruprp-fw" > >> -RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2g = " prueth-fw" > >> RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am65xx = " prueth-fw-am65x" > >> RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am65xx-evm = " prueth-fw-am65x-sr2" > >> > >> -- > >> 2.23.0 > >> >