From: Pavel Machek <pavel@denx.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Qiwu Huang <yanziily@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Qiwu Huang <huangqiwu@xiaomi.com>
Subject: Re: [PATCH v8 1/4] power: supply: core: add quick charge type property
Date: Tue, 25 Aug 2020 20:19:54 +0200 [thread overview]
Message-ID: <20200825181954.GB989@bug> (raw)
In-Reply-To: <20200824085715.GB402243@kroah.com>
Hi!
> > > > If we ported the full driver, we would break the existing driver
> > > > structure because we would introduce more Qualcomm code. I think
> > > > that's an unreasonable change.
> > >
> > > That doesn't make much sense. You have a working driver for these apis,
> > > just submit it for inclusion, it should never break any existing
> > > drivers, otherwise your code wouldn't work either.
> >
> > We're an Android device, we're working on a Qualcomm based code, and
> > from the current code tree, the current code tree is missing the QTI
> > Charger code
>
> I don't know what that means, sorry. Just submit your driver, and any
> needed dependencies as well. There's no other way to evaluate this api
> addition without that, right?
Actually, there's a way to evaluate the API without the driver... if the API
is pretty obviously unacceptable.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2020-08-25 18:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 3:46 [PATCH v8 0/4] add some power supply properties about wireless/wired charging Qiwu Huang
2020-08-14 3:46 ` [PATCH v8 1/4] power: supply: core: add quick charge type property Qiwu Huang
2020-08-14 6:09 ` Greg KH
2020-08-18 1:56 ` Qiwu Huang
2020-08-18 6:07 ` Greg KH
2020-08-24 0:54 ` Qiwu Huang
2020-08-24 7:43 ` Greg KH
2020-08-24 8:42 ` Qiwu Huang
2020-08-24 8:57 ` Greg KH
2020-08-25 18:19 ` Pavel Machek [this message]
2020-08-14 3:46 ` [PATCH v8 2/4] power: supply: core: add wireless charger adapter " Qiwu Huang
2020-08-14 3:46 ` [PATCH v8 3/4] power: supply: core: add wireless signal strength property Qiwu Huang
2020-08-14 3:46 ` [PATCH v8 4/4] power: supply: core: property to control reverse charge Qiwu Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825181954.GB989@bug \
--to=pavel@denx.de \
--cc=gregkh@linuxfoundation.org \
--cc=huangqiwu@xiaomi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=yanziily@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.