From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E1AC433DF for ; Tue, 25 Aug 2020 18:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 434FD207DF for ; Tue, 25 Aug 2020 18:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598381369; bh=lITIec98eJSFfEE7jsKrx3X/MFZJs2LmC/S3QiRCqnY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=R23NfUqhQBay2m28nn2N7aPw8N/+MVIt09juW5MiCsuMXfDDvd+TMC0TEVB11yQJa r12dow85LcQIe/NRsxGhaYvyInsFsp9UMnGoQh0DdtTOnbODGMg10TWr2bem63boDh lsQJbiZrqgg71v56CN65bTH7zR+BElUjvFxSYTpA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726225AbgHYStV convert rfc822-to-8bit (ORCPT ); Tue, 25 Aug 2020 14:49:21 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52937 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbgHYStU (ORCPT ); Tue, 25 Aug 2020 14:49:20 -0400 Received: by mail-wm1-f68.google.com with SMTP id x5so3660175wmi.2; Tue, 25 Aug 2020 11:49:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lwlHflOE4Bg8GdD7kpfA2k4MUUB6oSMZ6rjs7tdlxjk=; b=GQh/5LNNwwYo3RfuGclP9MKz1aWiNI/txOSQ7ntjEyRCTM40Isw+DKTpfuEhAwfOK4 qT1cBkGfQfJsfB21vwAToXgEb+NWa/sJXJb4uy45hyYbFBf7s8+5k6ImE+VkSBXDRcml SWhqEv1FMBDXQY5LdoUCKZEDm/s778dqHxsi4AROYzkYzvjKqjvNfeh/veUwO3v467NQ wCYVx2J/+nuvxf0zq3ZIv3uv4xLHelkB9UCmPF7Tkzb5hMbJCJ+DqLq/R8WNHZD2xW2X pBDNQxIWicXuPUyFTbYEiYTCFC2CD/iZadcMUWHV5Pw92C+RdHfe/U+tWe3INTk/oDKD sb9A== X-Gm-Message-State: AOAM533nVnRU85PDgqLuCJuVsnZYw/Qy1Brtcmaa1jlrM8y/YVlqhECe 2v6Ix6hvYS58EAo3LVP6qpE9z9tYMPI= X-Google-Smtp-Source: ABdhPJy+C0eo7c2RxD1Gpi+NLpYBFVtKtj9PQvX0Zbfdy+e8F4TgRXykHdY/YRcIvDVUJ/iHHC4h3A== X-Received: by 2002:a1c:1fcb:: with SMTP id f194mr3434635wmf.28.1598381357412; Tue, 25 Aug 2020 11:49:17 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id y142sm8270483wmd.3.2020.08.25.11.49.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Aug 2020 11:49:16 -0700 (PDT) Date: Tue, 25 Aug 2020 20:49:14 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: "David S. Miller" , Jakub Kicinski , Kukjin Kim , Rob Herring , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH 2/3] ARM: dts: Add ethernet Message-ID: <20200825184914.GB2693@kozik-lap> References: <20200825170311.24886-1-l.stelmach@samsung.com> <20200825170311.24886-2-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200825170311.24886-2-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Tue, Aug 25, 2020 at 07:03:10PM +0200, Łukasz Stelmach wrote: > Add node for ax88796c ethernet chip. Subject ARM: dts: exynos: Add Ethernet to Artik 5 board > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 ++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts > index 20446a846a98..44151a2cb35d 100644 > --- a/arch/arm/boot/dts/exynos3250-artik5-eval.dts > +++ b/arch/arm/boot/dts/exynos3250-artik5-eval.dts > @@ -37,3 +37,24 @@ &mshc_2 { > &serial_2 { > status = "okay"; > }; > + > +&spi_0 { > + status = "okay"; > + cs-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>, <0>; > + > + assigned-clocks = <&cmu CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu CLK_DIV_SPI0>, <&cmu CLK_DIV_SPI0_PRE>, <&cmu CLK_SCLK_SPI0>; > + assigned-clock-parents = <&cmu CLK_FOUT_MPLL>, <&cmu CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu CLK_DIV_SPI0>, <&cmu CLK_DIV_SPI0_PRE>; > + > + ax88796c@0 { > + compatible = "asix,ax88796c"; Isn't checkpatch complaining about undocumented compatible? I didn't see a binding here. > + interrupt-parent = <&gpx2>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + spi-max-frequency = <40000000>; > + reg = <0x0>; > + reset-gpios = <&gpe0 2 GPIO_ACTIVE_LOW>; One line break. > + controller-data { > + samsung,spi-feedback-delay = <2>; > + samsung,spi-chip-select-mode; What does samsung,spi-chip-select-mode mean? git grep does not find a binding. > + }; > + }; Whatever formatting you used here, it is not Linux coding style. Please fix indentation, linewrapping. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F23C433DF for ; Tue, 25 Aug 2020 18:50:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6980C20738 for ; Tue, 25 Aug 2020 18:50:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q6jBRPYw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6980C20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FFxWyIMXRFamY20mCtiBn0KsupV7OVv0Yb2SQY0Uu1Q=; b=q6jBRPYwytct/QLfL9RD/dSDy 4g1W/mBPTfKPybgA1R9+b8PAk/kxEIlq6D3Dk3PaX3Zm9EKGhH5Bd8DOZPjv6SmI5xVxyPbCA2IID 2nJLmv6ij17QgHMRRAe/8xCgEwhx8iieqaZQpxj09Xdvk3tR+m0DBxzWIfyGFM3jjDnNjChBQKEuX NNtgI19uxAXHCehPE/d+I+HEshhFjKJ1Q8mHBq43nHmkQIm8M9yFis3dECWRGXnkiWKU/B+vKFkvR 3knIfURCBT5kcRMJPZo8gmc8wLSvWQUvPm12+dOEl5MgvlhLeIc4ebToU14cErJ1QYbuY/tvmL9ZA r/h8oJyww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAe0Y-00014d-Bb; Tue, 25 Aug 2020 18:49:22 +0000 Received: from mail-wm1-f67.google.com ([209.85.128.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAe0V-00013r-1z for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 18:49:20 +0000 Received: by mail-wm1-f67.google.com with SMTP id s20so3656716wmj.1 for ; Tue, 25 Aug 2020 11:49:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lwlHflOE4Bg8GdD7kpfA2k4MUUB6oSMZ6rjs7tdlxjk=; b=I3kcaClGiQdRwZUWESxc0+HCIEwfAfrb8sLy/Kq6eqjVaX2PYSv3BOKXDXJuHHoHDO 4BWWccTN+Ijr5PL42UsUGlA0KFeP1RpY4OzkLX66YTwUHbcUy6EbIDfcDwO9bVXAuGRb 7Da2nVMbEvWzSRJdk5c3o5D6s7WSu96NOhJe9xSZeYA8eNO0yVygjlDH+LhF/hiCUL2c Bc6xc+NnfLE1zrnpWmZAs2IegGEYTbbmkXgiIB1IDsUOOYRLI8B6vkCPYdNF6Zj4ndsW PYZlXmOM8Or9Pj7N7KaM8SJEenebI//f1DcyHkQqVY/0KeLg9NzW6XIfXd0XJzykVk+e 96lQ== X-Gm-Message-State: AOAM531KWpacjo+y4/S/NAanS7RlQnatQ2dFnaKgDiWQw5h/o/6yewnm WX1s2Zq/t3svJDRI7W4KYug= X-Google-Smtp-Source: ABdhPJy+C0eo7c2RxD1Gpi+NLpYBFVtKtj9PQvX0Zbfdy+e8F4TgRXykHdY/YRcIvDVUJ/iHHC4h3A== X-Received: by 2002:a1c:1fcb:: with SMTP id f194mr3434635wmf.28.1598381357412; Tue, 25 Aug 2020 11:49:17 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id y142sm8270483wmd.3.2020.08.25.11.49.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Aug 2020 11:49:16 -0700 (PDT) Date: Tue, 25 Aug 2020 20:49:14 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH 2/3] ARM: dts: Add ethernet Message-ID: <20200825184914.GB2693@kozik-lap> References: <20200825170311.24886-1-l.stelmach@samsung.com> <20200825170311.24886-2-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200825170311.24886-2-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_144919_402916_72FFCCF1 X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, netdev@vger.kernel.org, Russell King , Rob Herring , linux-kernel@vger.kernel.org, Kukjin Kim , Jakub Kicinski , "David S. Miller" , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBdWcgMjUsIDIwMjAgYXQgMDc6MDM6MTBQTSArMDIwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBBZGQgbm9kZSBmb3IgYXg4ODc5NmMgZXRoZXJuZXQgY2hpcC4KClN1YmplY3QK ICBBUk06IGR0czogZXh5bm9zOiBBZGQgRXRoZXJuZXQgdG8gQXJ0aWsgNSBib2FyZAoKPiAKPiBT aWduZWQtb2ZmLWJ5OiDFgXVrYXN6IFN0ZWxtYWNoIDxsLnN0ZWxtYWNoQHNhbXN1bmcuY29tPgo+ IC0tLQo+ICBhcmNoL2FybS9ib290L2R0cy9leHlub3MzMjUwLWFydGlrNS1ldmFsLmR0cyB8IDIx ICsrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCsp Cj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2V4eW5vczMyNTAtYXJ0aWs1LWV2 YWwuZHRzIGIvYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zMzI1MC1hcnRpazUtZXZhbC5kdHMKPiBp bmRleCAyMDQ0NmE4NDZhOTguLjQ0MTUxYTJjYjM1ZCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9i b290L2R0cy9leHlub3MzMjUwLWFydGlrNS1ldmFsLmR0cwo+ICsrKyBiL2FyY2gvYXJtL2Jvb3Qv ZHRzL2V4eW5vczMyNTAtYXJ0aWs1LWV2YWwuZHRzCj4gQEAgLTM3LDMgKzM3LDI0IEBAICZtc2hj XzIgewo+ICAmc2VyaWFsXzIgewo+ICAJc3RhdHVzID0gIm9rYXkiOwo+ICB9Owo+ICsKPiArJnNw aV8wIHsKPiArCQlzdGF0dXMgPSAib2theSI7Cj4gKwkJY3MtZ3Bpb3MgPSA8JmdweDMgNCBHUElP X0FDVElWRV9MT1c+LCA8MD47Cj4gKwo+ICsJCWFzc2lnbmVkLWNsb2NrcyAgICAgICAgPSA8JmNt dSBDTEtfTU9VVF9NUExMPiwgPCZjbXUgQ0xLX0RJVl9NUExMX1BSRT4sIDwmY211IENMS19NT1VU X1NQSTA+LCAgICA8JmNtdSBDTEtfRElWX1NQSTA+LCAgPCZjbXUgQ0xLX0RJVl9TUEkwX1BSRT4s IDwmY211IENMS19TQ0xLX1NQSTA+Owo+ICsJCWFzc2lnbmVkLWNsb2NrLXBhcmVudHMgPSA8JmNt dSBDTEtfRk9VVF9NUExMPiwgPCZjbXUgQ0xLX01PVVRfTVBMTD4sICAgIDwmY211IENMS19ESVZf TVBMTF9QUkU+LCA8JmNtdSBDTEtfTU9VVF9TUEkwPiwgPCZjbXUgQ0xLX0RJVl9TUEkwPiwgICAg IDwmY211IENMS19ESVZfU1BJMF9QUkU+Owo+ICsKPiArCQlheDg4Nzk2Y0AwIHsKPiArCQkJY29t cGF0aWJsZSA9ICJhc2l4LGF4ODg3OTZjIjsKCklzbid0IGNoZWNrcGF0Y2ggY29tcGxhaW5pbmcg YWJvdXQgdW5kb2N1bWVudGVkIGNvbXBhdGlibGU/IEkgZGlkbid0IHNlZQphIGJpbmRpbmcgaGVy ZS4KCj4gKwkJCWludGVycnVwdC1wYXJlbnQgPSA8JmdweDI+Owo+ICsJCQlpbnRlcnJ1cHRzID0g PDAgSVJRX1RZUEVfTEVWRUxfTE9XPjsKPiArCQkJc3BpLW1heC1mcmVxdWVuY3kgPSA8NDAwMDAw MDA+Owo+ICsJCQlyZWcgPSA8MHgwPjsKPiArCQkJcmVzZXQtZ3Bpb3MgPSA8JmdwZTAgMiBHUElP X0FDVElWRV9MT1c+OwoKT25lIGxpbmUgYnJlYWsuCgo+ICsJCQljb250cm9sbGVyLWRhdGEgewo+ ICsJCQkJc2Ftc3VuZyxzcGktZmVlZGJhY2stZGVsYXkgPSA8Mj47Cj4gKwkJCQlzYW1zdW5nLHNw aS1jaGlwLXNlbGVjdC1tb2RlOwoKV2hhdCBkb2VzIHNhbXN1bmcsc3BpLWNoaXAtc2VsZWN0LW1v ZGUgbWVhbj8gZ2l0IGdyZXAgZG9lcyBub3QgZmluZCBhIGJpbmRpbmcuCgo+ICsJCX07Cj4gKwl9 OwoKV2hhdGV2ZXIgZm9ybWF0dGluZyB5b3UgdXNlZCBoZXJlLCBpdCBpcyBub3QgTGludXggY29k aW5nIHN0eWxlLiBQbGVhc2UKZml4IGluZGVudGF0aW9uLCBsaW5ld3JhcHBpbmcuCgpCZXN0IHJl Z2FyZHMsCktyenlzenRvZgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=