From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>,
Jon Hunter <jon-hunter@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] memory: omap-gpmc: Fix a couple off by ones
Date: Wed, 26 Aug 2020 18:22:32 +0000 [thread overview]
Message-ID: <20200826182232.GA11327@kozik-lap> (raw)
In-Reply-To: <20200825104707.GB278587@mwanda>
On Tue, Aug 25, 2020 at 01:47:07PM +0300, Dan Carpenter wrote:
> These comparisons should be >= instead of > to prevent reading one
> element beyond the end of the gpmc_cs[] array.
>
> Fixes: cdd6928c589a ("ARM: OMAP2+: Add device-tree support for NOR flash")
> Fixes: f37e4580c409 ("ARM: OMAP2: Dynamic allocator for GPMC memory space")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/memory/omap-gpmc.c | 4 ++--
Thanks, applied.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>,
Jon Hunter <jon-hunter@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] memory: omap-gpmc: Fix a couple off by ones
Date: Wed, 26 Aug 2020 20:22:32 +0200 [thread overview]
Message-ID: <20200826182232.GA11327@kozik-lap> (raw)
In-Reply-To: <20200825104707.GB278587@mwanda>
On Tue, Aug 25, 2020 at 01:47:07PM +0300, Dan Carpenter wrote:
> These comparisons should be >= instead of > to prevent reading one
> element beyond the end of the gpmc_cs[] array.
>
> Fixes: cdd6928c589a ("ARM: OMAP2+: Add device-tree support for NOR flash")
> Fixes: f37e4580c409 ("ARM: OMAP2: Dynamic allocator for GPMC memory space")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/memory/omap-gpmc.c | 4 ++--
Thanks, applied.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-08-26 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 10:47 [PATCH] memory: omap-gpmc: Fix a couple off by ones Dan Carpenter
2020-08-25 10:47 ` Dan Carpenter
2020-08-26 13:05 ` Roger Quadros
2020-08-26 13:05 ` Roger Quadros
2020-08-26 18:22 ` Krzysztof Kozlowski [this message]
2020-08-26 18:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826182232.GA11327@kozik-lap \
--to=krzk@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=jon-hunter@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.