From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0769332231215003645==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Thu, 27 Aug 2020 03:51:20 +0800 Message-ID: <20200826195120.GA101653@fa7bc8d904c2> In-Reply-To: <202008270327.1SU94Wvv%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============0769332231215003645== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: Bernie Thompson CC: Bartlomiej Zolnierkiewicz CC: linux-fbdev(a)vger.kernel.org CC: dri-devel(a)lists.freedesktop.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/video/fbdev/udlfb.c:1460:62-63: WARNING opportunity for kobj_to_dev= () drivers/video/fbdev/udlfb.c:1482:62-63: WARNING opportunity for kobj_to_dev= () Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: a2fc3718bc22e85378085568ecc5765fb28cabce commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/3] coccinelle: api: add= kobj_to_dev.cocci script :::::: branch date: 5 days ago :::::: commit date: 5 days ago Please take the patch only if it's a positive warning. Thanks! udlfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -1457,7 +1457,7 @@ static ssize_t edid_show( struct file *filp, struct kobject *kobj, struct bin_attribute *a, char *buf, loff_t off, size_t count) { - struct device *fbdev =3D container_of(kobj, struct device, kobj); + struct device *fbdev =3D kobj_to_dev(kobj); struct fb_info *fb_info =3D dev_get_drvdata(fbdev); struct dlfb_data *dlfb =3D fb_info->par; = @@ -1479,7 +1479,7 @@ static ssize_t edid_store( struct file *filp, struct kobject *kobj, struct bin_attribute *a, char *src, loff_t src_off, size_t src_size) { - struct device *fbdev =3D container_of(kobj, struct device, kobj); + struct device *fbdev =3D kobj_to_dev(kobj); struct fb_info *fb_info =3D dev_get_drvdata(fbdev); struct dlfb_data *dlfb =3D fb_info->par; int ret; --===============0769332231215003645==--