From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2156753073448458331==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Thu, 27 Aug 2020 07:27:08 +0800 Message-ID: <20200826232708.GA28650@d10202f75172> In-Reply-To: <202008270751.hp4RBpOO%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============2156753073448458331== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: "James E.J. Bottomley" CC: "Martin K. Petersen" CC: Mauro Carvalho Chehab CC: linux-media(a)vger.kernel.org CC: linux-scsi(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/scsi/arcmsr/arcmsr_attr.c:164:58-59: WARNING opportunity for kobj_t= o_dev() drivers/scsi/arcmsr/arcmsr_attr.c:69:58-59: WARNING opportunity for kobj_to= _dev() drivers/scsi/arcmsr/arcmsr_attr.c:116:58-59: WARNING opportunity for kobj_t= o_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: a2fc3718bc22e85378085568ecc5765fb28cabce commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/3] coccinelle: api: add= kobj_to_dev.cocci script :::::: branch date: 5 days ago :::::: commit date: 5 days ago Please take the patch only if it's a positive warning. Thanks! arcmsr_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/scsi/arcmsr/arcmsr_attr.c +++ b/drivers/scsi/arcmsr/arcmsr_attr.c @@ -66,7 +66,7 @@ static ssize_t arcmsr_sysfs_iop_message_ char *buf, loff_t off, size_t count) { - struct device *dev =3D container_of(kobj,struct device,kobj); + struct device *dev =3D kobj_to_dev(kobj); struct Scsi_Host *host =3D class_to_shost(dev); struct AdapterControlBlock *acb =3D (struct AdapterControlBlock *) host->= hostdata; uint8_t *ptmpQbuffer; @@ -113,7 +113,7 @@ static ssize_t arcmsr_sysfs_iop_message_ char *buf, loff_t off, size_t count) { - struct device *dev =3D container_of(kobj,struct device,kobj); + struct device *dev =3D kobj_to_dev(kobj); struct Scsi_Host *host =3D class_to_shost(dev); struct AdapterControlBlock *acb =3D (struct AdapterControlBlock *) host->= hostdata; int32_t user_len, cnt2end; @@ -161,7 +161,7 @@ static ssize_t arcmsr_sysfs_iop_message_ char *buf, loff_t off, size_t count) { - struct device *dev =3D container_of(kobj,struct device,kobj); + struct device *dev =3D kobj_to_dev(kobj); struct Scsi_Host *host =3D class_to_shost(dev); struct AdapterControlBlock *acb =3D (struct AdapterControlBlock *) host->= hostdata; uint8_t *pQbuffer; --===============2156753073448458331==--