From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2344303289235939740==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Thu, 27 Aug 2020 07:27:15 +0800 Message-ID: <20200826232715.GA28998@d10202f75172> In-Reply-To: <202008270751.hp4RBpOO%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============2344303289235939740== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: "James E.J. Bottomley" CC: "Martin K. Petersen" CC: linux-scsi(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/scsi/scsi_transport_spi.c:1460:61-62: WARNING opportunity for kobj_= to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: a2fc3718bc22e85378085568ecc5765fb28cabce commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/3] coccinelle: api: add= kobj_to_dev.cocci script :::::: branch date: 5 days ago :::::: commit date: 5 days ago Please take the patch only if it's a positive warning. Thanks! scsi_transport_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/scsi_transport_spi.c +++ b/drivers/scsi/scsi_transport_spi.c @@ -1457,7 +1457,7 @@ static int spi_host_configure(struct tra static umode_t target_attribute_is_visible(struct kobject *kobj, struct attribute *attr, int i) { - struct device *cdev =3D container_of(kobj, struct device, kobj); + struct device *cdev =3D kobj_to_dev(kobj); struct scsi_target *starget =3D transport_class_to_starget(cdev); struct Scsi_Host *shost =3D transport_class_to_shost(cdev); struct spi_internal *si =3D to_spi_internal(shost->transportt); --===============2344303289235939740==--