Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4516 bytes --]

Hi Thomas,

I love your patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on v5.9-rc2 next-20200826]
[cannot apply to tip/x86/core iommu/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thomas-Gleixner/x86-PCI-XEN-genirq-Prepare-for-device-MSI/20200826-201642
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/sparc/kernel/pci.c:937:5: error: no previous prototype for 'arch_setup_msi_irq' [-Werror=missing-prototypes]
     937 | int arch_setup_msi_irq(struct pci_dev *pdev, struct msi_desc *desc)
         |     ^~~~~~~~~~~~~~~~~~
>> arch/sparc/kernel/pci.c:948:6: error: no previous prototype for 'arch_teardown_msi_irq' [-Werror=missing-prototypes]
     948 | void arch_teardown_msi_irq(unsigned int irq)
         |      ^~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

# https://github.com/0day-ci/linux/commit/82f0dd259254d59d8f59734890f7f2d3d64216fa
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thomas-Gleixner/x86-PCI-XEN-genirq-Prepare-for-device-MSI/20200826-201642
git checkout 82f0dd259254d59d8f59734890f7f2d3d64216fa
vim +/arch_setup_msi_irq +937 arch/sparc/kernel/pci.c

^1da177e4c3f41 arch/sparc64/kernel/pci.c Linus Torvalds  2005-04-16  935  
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  936  #ifdef CONFIG_PCI_MSI
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10 @937  int arch_setup_msi_irq(struct pci_dev *pdev, struct msi_desc *desc)
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  938  {
a2fb23af1c31ad arch/sparc64/kernel/pci.c David S. Miller 2007-02-28  939  	struct pci_pbm_info *pbm = pdev->dev.archdata.host_controller;
44ed3c0c479062 arch/sparc/kernel/pci.c   Sam Ravnborg    2011-01-22  940  	unsigned int irq;
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  941  
e9870c4c0aef94 arch/sparc64/kernel/pci.c David S. Miller 2007-05-07  942  	if (!pbm->setup_msi_irq)
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  943  		return -EINVAL;
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  944  
44ed3c0c479062 arch/sparc/kernel/pci.c   Sam Ravnborg    2011-01-22  945  	return pbm->setup_msi_irq(&irq, pdev, desc);
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  946  }
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  947  
44ed3c0c479062 arch/sparc/kernel/pci.c   Sam Ravnborg    2011-01-22 @948  void arch_teardown_msi_irq(unsigned int irq)
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  949  {
394d441b91c146 arch/sparc/kernel/pci.c   Thomas Gleixner 2011-03-24  950  	struct msi_desc *entry = irq_get_msi_desc(irq);
3bf15f53c963a4 arch/sparc/kernel/pci.c   Jiang Liu       2015-07-09  951  	struct pci_dev *pdev = msi_desc_to_pci_dev(entry);
a2fb23af1c31ad arch/sparc64/kernel/pci.c David S. Miller 2007-02-28  952  	struct pci_pbm_info *pbm = pdev->dev.archdata.host_controller;
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  953  
77d10d0e63dcc4 arch/sparc64/kernel/pci.c David S. Miller 2008-09-11  954  	if (pbm->teardown_msi_irq)
44ed3c0c479062 arch/sparc/kernel/pci.c   Sam Ravnborg    2011-01-22  955  		pbm->teardown_msi_irq(irq, pdev);
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  956  }
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  957  #endif /* !(CONFIG_PCI_MSI) */
35a17eb6a87c9c arch/sparc64/kernel/pci.c David S. Miller 2007-02-10  958  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 66773 bytes --]