Re: [PATCH 1/4] drm-printk: POC caller of dynamic-debug-exec-queries

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4130 bytes --]

Hi Jim,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on linux/master drm-tip/drm-tip linus/master v5.9-rc2 next-20200826]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jim-Cromie/dyndbg-POC-use-dynamic_debug_exec_queries-in-DRM/20200827-010409
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm64-randconfig-r002-20200826 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 7cfcecece0e0430937cf529ce74d3a071a4dedc6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/drm_print.c:30:
>> include/linux/dynamic_debug.h:196:3: error: implicit declaration of function 'printk' [-Werror,-Wimplicit-function-declaration]
                   printk(KERN_WARNING "dyndbg param is supported only in "
                   ^
>> include/linux/dynamic_debug.h:196:10: error: use of undeclared identifier 'KERN_WARNING'
                   printk(KERN_WARNING "dyndbg param is supported only in "
                          ^
   In file included from drivers/gpu/drm/drm_print.c:31:
   In file included from include/linux/io.h:11:
   In file included from include/linux/bug.h:5:
   In file included from arch/arm64/include/asm/bug.h:26:
   In file included from include/asm-generic/bug.h:19:
   In file included from include/linux/kernel.h:15:
   include/linux/printk.h:171:5: error: conflicting types for 'printk'
   int printk(const char *fmt, ...);
       ^
   include/linux/dynamic_debug.h:196:3: note: previous implicit declaration is here
                   printk(KERN_WARNING "dyndbg param is supported only in "
                   ^
>> drivers/gpu/drm/drm_print.c:70:11: error: implicit declaration of function 'dynamic_debug_exec_queries' [-Werror,-Wimplicit-function-declaration]
                   chgct = dynamic_debug_exec_queries("module=drm* +p", NULL);
                           ^
   4 errors generated.

# https://github.com/0day-ci/linux/commit/ad959a93dccb8fe5deb5a7da3e22049779571b9b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jim-Cromie/dyndbg-POC-use-dynamic_debug_exec_queries-in-DRM/20200827-010409
git checkout ad959a93dccb8fe5deb5a7da3e22049779571b9b
vim +/printk +196 include/linux/dynamic_debug.h

e9d376f0fa66bd6 Jason Baron 2009-02-05  190  
b48420c1d3019ce Jim Cromie  2012-04-27  191  static inline int ddebug_dyndbg_module_param_cb(char *param, char *val,
b48420c1d3019ce Jim Cromie  2012-04-27  192  						const char *modname)
b48420c1d3019ce Jim Cromie  2012-04-27  193  {
b48420c1d3019ce Jim Cromie  2012-04-27  194  	if (strstr(param, "dyndbg")) {
516cf1be07cf3ab Jim Cromie  2012-05-01  195  		/* avoid pr_warn(), which wants pr_fmt() fully defined */
516cf1be07cf3ab Jim Cromie  2012-05-01 @196  		printk(KERN_WARNING "dyndbg param is supported only in "
b48420c1d3019ce Jim Cromie  2012-04-27  197  			"CONFIG_DYNAMIC_DEBUG builds\n");
b48420c1d3019ce Jim Cromie  2012-04-27  198  		return 0; /* allow and ignore */
b48420c1d3019ce Jim Cromie  2012-04-27  199  	}
b48420c1d3019ce Jim Cromie  2012-04-27  200  	return -EINVAL;
b48420c1d3019ce Jim Cromie  2012-04-27  201  }
b48420c1d3019ce Jim Cromie  2012-04-27  202  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41381 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel