From: Kalle Valo <kvalo@codeaurora.org>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
ath11k@lists.infradead.org
Subject: Re: [PATCH] ath11k: return error if firmware request fails
Date: Thu, 27 Aug 2020 10:19:03 +0000 (UTC) [thread overview]
Message-ID: <20200827101903.69E95C433A1@smtp.codeaurora.org> (raw)
In-Reply-To: <20200825143040.233619-1-alex.dewar90@gmail.com>
Alex Dewar <alex.dewar90@gmail.com> wrote:
> In ath11k_qmi_prepare_bdf_download(), ath11k_core_firmware_request() is
> called, but the returned pointer is not checked for errors. Rather the
> variable ret (which will always be zero) is checked by mistake. Fix
> this and replace the various gotos with simple returns for clarity.
>
> While we are at it, move the call to memset, as variable bd is not used
> on all code paths.
>
> Fixes: 7b57b2ddec21 ("ath11k: create a common function to request all firmware files")
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
342b6194a75b ath11k: return error if firmware request fails
--
https://patchwork.kernel.org/patch/11735787/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2020-08-27 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 14:30 [PATCH] ath11k: return error if firmware request fails Alex Dewar
2020-08-25 14:30 ` Alex Dewar
2020-08-27 10:19 ` Kalle Valo [this message]
2020-08-27 10:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827101903.69E95C433A1@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=alex.dewar90@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.