Re: [PATCH 2/4] arm64: wrap and generalise counter read functions

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2686 bytes --]

Hi Ionela,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 3a00d3dfd4b68b208ecd5405e676d06c8ad6bb63]

url:    https://github.com/0day-ci/linux/commits/Ionela-Voinescu/arm64-cppc-add-FFH-support-using-AMUs/20200826-210641
base:    3a00d3dfd4b68b208ecd5405e676d06c8ad6bb63
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/arm64/kernel/topology.c:147:6: warning: no previous prototype for 'update_freq_counters_refs' [-Wmissing-prototypes]
     147 | void update_freq_counters_refs(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/energy_model.h:10,
                    from include/linux/device.h:16,
                    from include/linux/acpi.h:15,
                    from arch/arm64/kernel/topology.c:14:
   include/linux/sched/topology.h:40:3: warning: 'sd_flag_debug' defined but not used [-Wunused-const-variable=]
      40 | } sd_flag_debug[] = {
         |   ^~~~~~~~~~~~~
   In file included from include/linux/energy_model.h:10,
                    from include/linux/device.h:16,
                    from include/linux/acpi.h:15,
                    from arch/arm64/kernel/topology.c:14:
   include/linux/sched/topology.h:30:27: warning: 'SD_DEGENERATE_GROUPS_MASK' defined but not used [-Wunused-const-variable=]
      30 | static const unsigned int SD_DEGENERATE_GROUPS_MASK =
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~

# https://github.com/0day-ci/linux/commit/9c9847eda0177b65fe304600e007da50edd4d768
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ionela-Voinescu/arm64-cppc-add-FFH-support-using-AMUs/20200826-210641
git checkout 9c9847eda0177b65fe304600e007da50edd4d768
vim +/update_freq_counters_refs +147 arch/arm64/kernel/topology.c

   146	
 > 147	void update_freq_counters_refs(void)
   148	{
   149		this_cpu_write(arch_core_cycles_prev, read_corecnt());
   150		this_cpu_write(arch_const_cycles_prev, read_constcnt());
   151	}
   152	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74332 bytes --]