Re: [PATCH 00/25] alsa-tools: efw-downloader: add initial version of firmwre downloader for Echo Audio Fireworks devices

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH 00/25] alsa-tools: efw-downloader: add initial version of firmwre downloader for Echo Audio Fireworks devices
Date: Thu, 27 Aug 2020 21:24:42 +0900	[thread overview]
Message-ID: <20200827122442.GA394751@workstation> (raw)
In-Reply-To: <s5hy2m1skwm.wl-tiwai@suse.de>

Hi,

On Wed, Aug 26, 2020 at 01:31:53PM +0200, Takashi Iwai wrote:
> On Wed, 26 Aug 2020 11:32:58 +0200,
> Takashi Sakamoto wrote:
> > 
> > Hi,
> > 
> > Would I expect any reaction by maintainers of alsa-tools repository for
> > the patches?
> 
> I'm reviewing those patches now.

Thanks for your review.

> Since it's based on meson build, it'll be tricky to include this in
> alsa-tools whether others are all autoconf.  The tarball creation is
> done in the top directory and that assumes the execution of "make
> alsa-dist" in each subdirectory.  Without this integration, the
> directory won't be included in the release.
> 
> Could you work on it, too?

I didn't have enough care of distributing the package. Thank you for the
indication.

Although it's possible to write configure.ac/Makefile.am for
efw-downloader, I'd like to use meson.build for my convenience, especially
for the convenience of gnome module[1] in meson (Nowadays software in GNOME
project including GLib is mostly build by meson).

As long as I know, the concept of release creation in GNU Autotools is
different from the one in meson build system. GNU Autotools distributes
scripts generated from Makefile.am/configure.ac and so. On the other
hand, meson distributes files maintained by git or mercurial.

If we have a space to make enough arrangement for alsa-tools, the
top-level Makefile should be changed to have two variables for
subdirectories which includes software built by GNU Autotools and the
others, then be changed further for configure/install/alsa-dist/clean
targets.

Nevertheless, the idea to mix all of software built by several types of
build system into one repository is not so convenient itself. I'll take
more time to investigate further for better packaging of alsa-tools.
(Tools like Android repo is a bit over-engineering in the case, mmm)

I decline the patchset for now.

[1] https://mesonbuild.com/Gnome-module.html

Thanks

Takashi Sakamoto

next prev parent reply	other threads:[~2020-08-27 12:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21  7:30 [PATCH 00/25] alsa-tools: efw-downloader: add initial version of firmwre downloader for Echo Audio Fireworks devices Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 01/25] efw-downloader: start a new project to operate on-board flash memory for Fireworks board module Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 02/25] efw-downloader: efw-proto: define EfwProto as derived object of HinawaFwResp Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 03/25] efw-downloader: efw-proto: add constructor, destructor, bind, unbind functions Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 04/25] efw-downloader: efw-proto: add responded signal Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 05/25] efw-downloader: efw-proto: add class virtual method to handle " Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 06/25] efw-downloader: efw-proto: add instance private structure Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 07/25] efw-downloader: efw-proto: emit responded signal at receiving response Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 08/25] efw-downloader: efw-proto: add function to finish transaction for command frame Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 09/25] efw-downloader: efw-proto: add function to finish a pair of transactions Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 10/25] efw-downloader: add parser for sub commands Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 11/25] efw-downloader: subcmd-device: implement 'device' sub command to operate actual device Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 12/25] efw-downloader: subcmd-device: open firewire character device by HinawaFwNode Takashi Sakamoto
2020-08-21  7:30 ` [PATCH 13/25] efw-downloader: config-rom: parse config rom to detect supported device Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 14/25] efw-downloader: subcmd-device: check supported models or not Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 15/25] efw-downloader: subcmd-device: bind Fireworks protocol Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 16/25] efw-downloader: node_dispatcher: add event dispatcher utilizing GLib MainContext/MainLoop Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 17/25] efw-downloader: subcmd-device: support debug output for response of Fireworks protocol Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 18/25] efw-downloader: efw-commands: add support for a part of hardware command Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 19/25] efw-downloader: efw-commands: add support for commands in flash category Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 20/25] efw-downloader: subcmd-device: add read operation Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 21/25] efw-downloader: file-cntr: add parser for data binary shipped by Echo Digital Audio corporation Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 22/25] efw-downloader: subcmd-file: add 'file' sub command Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 23/25] efw-downloader: subcmd-file: add parse operation Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 24/25] efw-downloader: man: add online manual Takashi Sakamoto
2020-08-21  7:31 ` [PATCH 25/25] efw-downloader: add README formatted by reStructuredText Takashi Sakamoto
2020-08-26  9:32 ` [PATCH 00/25] alsa-tools: efw-downloader: add initial version of firmwre downloader for Echo Audio Fireworks devices Takashi Sakamoto
2020-08-26 11:31   ` Takashi Iwai
2020-08-27 12:24     ` Takashi Sakamoto [this message]
2020-08-27 12:57       ` Takashi Iwai
2020-08-27 16:02         ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827122442.GA394751@workstation \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.