From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCHv2] nvme: only use power of two io boundaries
Date: Thu, 27 Aug 2020 18:50:40 +0200 [thread overview]
Message-ID: <20200827165040.GA14404@lst.de> (raw)
In-Reply-To: <20200827164405.GA2810820@dhcp-10-100-145-180.wdl.wdc.com>
On Thu, Aug 27, 2020 at 09:44:05AM -0700, Keith Busch wrote:
> On Thu, Aug 27, 2020 at 06:06:44PM +0200, Christoph Hellwig wrote:
> > On Thu, Aug 27, 2020 at 08:28:24AM -0700, Keith Busch wrote:
> > > + if (is_power_of_2(iob) && !blk_queue_is_zoned(ns->queue))
> > > + blk_queue_chunk_sectors(ns->queue, iob);
> > > + else if (iob && !(disk->flags & GENHD_FL_UP))
> > > + dev_warn(ctrl->device, "namespace:%u has unused io boundary:%u\n",
> > > + ns->head->ns_id, iob);
> > > +
> >
> > Similar to the zoned stuff I just find this super hard to read.
> >
> > I wonder if we need to untangle this a little. Something like
>
> That's fine. Do you want to see a prep patch splitting chunk settings
> first then power-of-2 check second, or okay as a single patch?
I don't really care, whatever suits best.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-27 16:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 15:28 [PATCHv2] nvme: only use power of two io boundaries Keith Busch
2020-08-27 15:48 ` Martin K. Petersen
2020-08-27 15:53 ` Keith Busch
2020-08-27 16:06 ` Christoph Hellwig
2020-08-27 16:44 ` Keith Busch
2020-08-27 16:50 ` Christoph Hellwig [this message]
2020-08-28 1:03 ` Damien Le Moal
2020-08-28 4:16 ` Keith Busch
2020-08-28 4:30 ` Damien Le Moal
2020-08-28 4:44 ` Keith Busch
2020-08-28 4:56 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827165040.GA14404@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.