From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Fri, 28 Aug 2020 09:29:04 +0000 Subject: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-Id: <20200828092904.GD1826686@dell> List-Id: References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> <20200820062301.GD3248864@dell> <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> <20200820074916.GE3248864@dell> <20200820113817.742yvjvdy7a642ew@holly.lan> In-Reply-To: <20200820113817.742yvjvdy7a642ew@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Daniel Thompson Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Markus Elfring , dinghao.liu@zju.edu.cn, Jingoo Han , Kangjie Lu On Thu, 20 Aug 2020, Daniel Thompson wrote: > On Thu, Aug 20, 2020 at 08:49:16AM +0100, Lee Jones wrote: > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > > > > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > > > > > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > > > > > > > > > When of_property_read_u32_array() returns an error code, > > > > > > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > > > > > > > > > > > Can another imperative wording be helpful for the change description? > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id445bf405cb331117bc98427b1ba6f12418ad17#n151 > > > > > > > > > > > > > > Would an other commit message be a bit nicer? > > > > > > > > > > > > > > > > > > > > > … > > > > > > > > +++ b/drivers/video/backlight/sky81452-backlight.c > > > > > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > > > > > > > > num_entry); > > > > > > > > if (ret < 0) { > > > > > > > > dev_err(dev, "led-sources node is invalid.\n"); > > > > > > > > + of_node_put(np); > > > > > > > > return ERR_PTR(-EINVAL); > > > > > > > > } > > > > > > > > > > > > > > I propose to add the jump target “put_node” so that a bit of common exception > > > > > > > handling code can be better reused at the end of this function implementation. > > > > > > > > > > > > > > Regards, > > > > > > > Markus > > > > > > > > > > > > You can safely ignore any review comments from Markus! > > > > > > > > > > > > However, this patch doesn't appear to be in my inbox. > > > > > > > > > > > > Any ideas as to why? > > > > > > > > > > > > > > > > Thank you for your advice. My outbox shows that this patch > > > > > has reached your email server successfully. Maybe this > > > > > ended up in your junk mail file? > > > > > > > > This has happened recently, so I was sure to check. > > > > > > > > Not there either unfortunately. > > > > > > > > Would you be kind enough to bounce/resend please? > > > > > > Sure. > > > > Looks like you sent it *only* to me. Please keep everyone else in Cc > > when doing that, or I can't respond to everyone. > > > > Anyway, besides the subject line (which I can fix easily), the patch > > looks good to me, but Daniel T must review. > > I've already offered a Reviewed-by for this patch. Perhaps it landed in > the same place as the original patch... Patch applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D857C433E6 for ; Fri, 28 Aug 2020 09:29:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2845208CA for ; Fri, 28 Aug 2020 09:29:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EhIxwGsE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2845208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1CA96E32F; Fri, 28 Aug 2020 09:29:09 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 407396E32F for ; Fri, 28 Aug 2020 09:29:08 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id b18so638935wrs.7 for ; Fri, 28 Aug 2020 02:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4xTbc6V9CmKW0Xfag25GTFqmyB1j/7yz22pA4imxIiw=; b=EhIxwGsEYrapIc1v+zaLKLGIYcC14GvP6v+Z6CbxQZEMa/D/jJzWG5jBVvI11WHLPo 3nbqhUnLrekuaF+/5TmAc6ZtRnfsKh4Jr+fvwq/Jp+FH0oZBjMmsrJd4w2nE63zwXClW hMjUznVbCdsTmian9+uE5iwihyJv1HGcojCE+qijrQsxB+r7l5/2PPW1B6r4CpwiDoEN YUZcSvX7jukQFfuZtUH+Q+6u2Mk+KqxuSYWB6+x1KtjzB6Uz8ueSeTYY5MfPlQlxvzUR IDghGWFM91DUAtGWnxd+zn0anWrhpiwEDPlMD9q1z6XTm41DemxHQGzQiO3Ls2fj+TeU MT3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4xTbc6V9CmKW0Xfag25GTFqmyB1j/7yz22pA4imxIiw=; b=jgPTe+1H8tJKUFBIcxZnAHMPqHeZO6SCFh2Czq2FWaUPoACl2/im4AZMGaxVBoQ+li 1BEmLIo7yMR2Ut64fD4DN/OP37tNFbINw/zWZ02g8tPx/HA/Ng72YIQnuT5dW+IFYsIp 80tgyXv4QuYdxHnhyKiiHyohqtdLUayLS7fkveyYZjOEFhRarCPwQhGrK9Sol5cH9hH4 enmExenEBdHDi4YV2+SicZs34Ha1THa8W1DDXQ4V/KkMx2U3H5fUh0wLBuyMyZHg5ldd mQNiuk7PxovO2aj22aTDOr28Hy7myjLkAoj0/Iatt98vyY40cGOKelKqVnWTeNLbMdhs VtHA== X-Gm-Message-State: AOAM533lRfuLA8764PxlMCSTAv9mH5/ZesFFzR7zvl9vCqpBfzUjYoet GgGAjgtIDtjHl1eFZueSoZfaoA== X-Google-Smtp-Source: ABdhPJwKFt/IiE8F76uSnjKmApF3H699HkDMx4kQ2ZsuOSzw96rNCHbjHHh1HSyEmO6pjlBVe4DCjg== X-Received: by 2002:a05:6000:4f:: with SMTP id k15mr642732wrx.316.1598606946784; Fri, 28 Aug 2020 02:29:06 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id j7sm1254885wmj.38.2020.08.28.02.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 02:29:06 -0700 (PDT) Date: Fri, 28 Aug 2020 10:29:04 +0100 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-ID: <20200828092904.GD1826686@dell> References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> <20200820062301.GD3248864@dell> <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> <20200820074916.GE3248864@dell> <20200820113817.742yvjvdy7a642ew@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200820113817.742yvjvdy7a642ew@holly.lan> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Markus Elfring , dinghao.liu@zju.edu.cn, Jingoo Han , Kangjie Lu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAyMCBBdWcgMjAyMCwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBUaHUsIEF1 ZyAyMCwgMjAyMCBhdCAwODo0OToxNkFNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBU aHUsIDIwIEF1ZyAyMDIwLCBkaW5naGFvLmxpdUB6anUuZWR1LmNuIHdyb3RlOgo+ID4gCj4gPiA+ ID4gT24gVGh1LCAyMCBBdWcgMjAyMCwgZGluZ2hhby5saXVAemp1LmVkdS5jbiB3cm90ZToKPiA+ ID4gPiAKPiA+ID4gPiA+ID4gT24gV2VkLCAxOSBBdWcgMjAyMCwgTWFya3VzIEVsZnJpbmcgd3Jv dGU6Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gV2hlbiBvZl9wcm9wZXJ0eV9yZWFkX3Uz Ml9hcnJheSgpIHJldHVybnMgYW4gZXJyb3IgY29kZSwKPiA+ID4gPiA+ID4gPiA+IGEgcGFpcmlu ZyByZWZjb3VudCBkZWNyZW1lbnQgaXMgbmVlZGVkIHRvIGtlZXAgbnAncyByZWZjb3VudCBiYWxh bmNlZC4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBDYW4gYW5vdGhlciBpbXBlcmF0aXZl IHdvcmRpbmcgYmUgaGVscGZ1bCBmb3IgdGhlIGNoYW5nZSBkZXNjcmlwdGlvbj8KPiA+ID4gPiA+ ID4gPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2 YWxkcy9saW51eC5naXQvdHJlZS9Eb2N1bWVudGF0aW9uL3Byb2Nlc3Mvc3VibWl0dGluZy1wYXRj aGVzLnJzdD9pZD0xODQ0NWJmNDA1Y2IzMzExMTdiYzk4NDI3YjFiYTZmMTI0MThhZDE3I24xNTEK PiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBXb3VsZCBhbiBvdGhlciBjb21taXQgbWVzc2Fn ZSBiZSBhIGJpdCBuaWNlcj8KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ ID4gPiDigKYKPiA+ID4gPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3Nr eTgxNDUyLWJhY2tsaWdodC5jCj4gPiA+ID4gPiA+ID4gPiBAQCAtMjE3LDYgKzIxNyw3IEBAIHN0 YXRpYyBzdHJ1Y3Qgc2t5ODE0NTJfYmxfcGxhdGZvcm1fZGF0YSAqc2t5ODE0NTJfYmxfcGFyc2Vf ZHQoCj4gPiA+ID4gPiA+ID4gPiAgCQkJCQludW1fZW50cnkpOwo+ID4gPiA+ID4gPiA+ID4gIAkJ aWYgKHJldCA8IDApIHsKPiA+ID4gPiA+ID4gPiA+ICAJCQlkZXZfZXJyKGRldiwgImxlZC1zb3Vy Y2VzIG5vZGUgaXMgaW52YWxpZC5cbiIpOwo+ID4gPiA+ID4gPiA+ID4gKwkJCW9mX25vZGVfcHV0 KG5wKTsKPiA+ID4gPiA+ID4gPiA+ICAJCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+ID4g PiA+ID4gPiA+ICAJCX0KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBJIHByb3Bvc2UgdG8g YWRkIHRoZSBqdW1wIHRhcmdldCDigJxwdXRfbm9kZeKAnSBzbyB0aGF0IGEgYml0IG9mIGNvbW1v biBleGNlcHRpb24KPiA+ID4gPiA+ID4gPiBoYW5kbGluZyBjb2RlIGNhbiBiZSBiZXR0ZXIgcmV1 c2VkIGF0IHRoZSBlbmQgb2YgdGhpcyBmdW5jdGlvbiBpbXBsZW1lbnRhdGlvbi4KPiA+ID4gPiA+ ID4gPiAKPiA+ID4gPiA+ID4gPiBSZWdhcmRzLAo+ID4gPiA+ID4gPiA+IE1hcmt1cwo+ID4gPiA+ ID4gPiAKPiA+ID4gPiA+ID4gWW91IGNhbiBzYWZlbHkgaWdub3JlIGFueSByZXZpZXcgY29tbWVu dHMgZnJvbSBNYXJrdXMhCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBIb3dldmVyLCB0aGlzIHBh dGNoIGRvZXNuJ3QgYXBwZWFyIHRvIGJlIGluIG15IGluYm94Lgo+ID4gPiA+ID4gPiAKPiA+ID4g PiA+ID4gQW55IGlkZWFzIGFzIHRvIHdoeT8KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4g PiA+IFRoYW5rIHlvdSBmb3IgeW91ciBhZHZpY2UuIE15IG91dGJveCBzaG93cyB0aGF0IHRoaXMg cGF0Y2gKPiA+ID4gPiA+IGhhcyByZWFjaGVkIHlvdXIgZW1haWwgc2VydmVyIHN1Y2Nlc3NmdWxs eS4gTWF5YmUgdGhpcwo+ID4gPiA+ID4gZW5kZWQgdXAgaW4geW91ciBqdW5rIG1haWwgZmlsZT8K PiA+ID4gPiAKPiA+ID4gPiBUaGlzIGhhcyBoYXBwZW5lZCByZWNlbnRseSwgc28gSSB3YXMgc3Vy ZSB0byBjaGVjay4KPiA+ID4gPiAKPiA+ID4gPiBOb3QgdGhlcmUgZWl0aGVyIHVuZm9ydHVuYXRl bHkuCj4gPiA+ID4gCj4gPiA+ID4gV291bGQgeW91IGJlIGtpbmQgZW5vdWdoIHRvIGJvdW5jZS9y ZXNlbmQgcGxlYXNlPwo+ID4gPiAKPiA+ID4gU3VyZS4KPiA+IAo+ID4gTG9va3MgbGlrZSB5b3Ug c2VudCBpdCAqb25seSogdG8gbWUuICBQbGVhc2Uga2VlcCBldmVyeW9uZSBlbHNlIGluIENjCj4g PiB3aGVuIGRvaW5nIHRoYXQsIG9yIEkgY2FuJ3QgcmVzcG9uZCB0byBldmVyeW9uZS4KPiA+IAo+ ID4gQW55d2F5LCBiZXNpZGVzIHRoZSBzdWJqZWN0IGxpbmUgKHdoaWNoIEkgY2FuIGZpeCBlYXNp bHkpLCB0aGUgcGF0Y2gKPiA+IGxvb2tzIGdvb2QgdG8gbWUsIGJ1dCBEYW5pZWwgVCBtdXN0IHJl dmlldy4KPiAKPiBJJ3ZlIGFscmVhZHkgb2ZmZXJlZCBhIFJldmlld2VkLWJ5IGZvciB0aGlzIHBh dGNoLiBQZXJoYXBzIGl0IGxhbmRlZCBpbgo+IHRoZSBzYW1lIHBsYWNlIGFzIHRoZSBvcmlnaW5h bCBwYXRjaC4uLgoKUGF0Y2ggYXBwbGllZCwgdGhhbmtzLgoKLS0gCkxlZSBKb25lcyBb5p2O55C8 5pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9y ZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZh Y2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B74BCC433E2 for ; Fri, 28 Aug 2020 09:29:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F09B208CA for ; Fri, 28 Aug 2020 09:29:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EhIxwGsE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728949AbgH1J3O (ORCPT ); Fri, 28 Aug 2020 05:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728811AbgH1J3I (ORCPT ); Fri, 28 Aug 2020 05:29:08 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33CB4C061232 for ; Fri, 28 Aug 2020 02:29:08 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id y3so648635wrl.4 for ; Fri, 28 Aug 2020 02:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4xTbc6V9CmKW0Xfag25GTFqmyB1j/7yz22pA4imxIiw=; b=EhIxwGsEYrapIc1v+zaLKLGIYcC14GvP6v+Z6CbxQZEMa/D/jJzWG5jBVvI11WHLPo 3nbqhUnLrekuaF+/5TmAc6ZtRnfsKh4Jr+fvwq/Jp+FH0oZBjMmsrJd4w2nE63zwXClW hMjUznVbCdsTmian9+uE5iwihyJv1HGcojCE+qijrQsxB+r7l5/2PPW1B6r4CpwiDoEN YUZcSvX7jukQFfuZtUH+Q+6u2Mk+KqxuSYWB6+x1KtjzB6Uz8ueSeTYY5MfPlQlxvzUR IDghGWFM91DUAtGWnxd+zn0anWrhpiwEDPlMD9q1z6XTm41DemxHQGzQiO3Ls2fj+TeU MT3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4xTbc6V9CmKW0Xfag25GTFqmyB1j/7yz22pA4imxIiw=; b=X8gZMkSB0wikWLbc1laevFnDKLgzP2EgM0CuNpnYFn8ulfk8tOV1Dg8BhsUUy/DXfF OnstSya6DgkjcRJZ/08yD8LCg1PX2hTcvg/SvNjvX/9VQ30wk/mXp4EzuZwumnIy1zGh HwSDZ9iUKf89tTfH7TSGkjWghpbA+B3xT0gGW+svIGRx1vfVecAqDEHMwoXh804LaqRt SzjwRp/XFIxMOM98h4PAbl4xBcBrcqQQaFMa11DQmF7rkKvsFAM09CrU8JxFYU5y3+Cg 2Uuc8nzbDAgQl6gflhXS62Z2ZXsB2BTs68g6/fa2AymGeDDvh3T/WcoMoV9HrBhXtpo+ EQuA== X-Gm-Message-State: AOAM5323yyFk3UGdTSVLKHAqVgG5sPMJJdAhsmBWcbkrvotE1paFzaxa sW2+oRKMbbQe0XMjBgIzL+/cBQ== X-Google-Smtp-Source: ABdhPJwKFt/IiE8F76uSnjKmApF3H699HkDMx4kQ2ZsuOSzw96rNCHbjHHh1HSyEmO6pjlBVe4DCjg== X-Received: by 2002:a05:6000:4f:: with SMTP id k15mr642732wrx.316.1598606946784; Fri, 28 Aug 2020 02:29:06 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id j7sm1254885wmj.38.2020.08.28.02.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 02:29:06 -0700 (PDT) Date: Fri, 28 Aug 2020 10:29:04 +0100 From: Lee Jones To: Daniel Thompson Cc: dinghao.liu@zju.edu.cn, Markus Elfring , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bartlomiej Zolnierkiewicz , Bryan Wu , Gyungoh Yoo , Jingoo Han , Kangjie Lu Subject: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-ID: <20200828092904.GD1826686@dell> References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> <20200819165702.GC3248864@dell> <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn> <20200820062301.GD3248864@dell> <3f9fbdb1.bc96.1740a9560d5.Coremail.dinghao.liu@zju.edu.cn> <20200820074916.GE3248864@dell> <20200820113817.742yvjvdy7a642ew@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200820113817.742yvjvdy7a642ew@holly.lan> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Aug 2020, Daniel Thompson wrote: > On Thu, Aug 20, 2020 at 08:49:16AM +0100, Lee Jones wrote: > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > > > > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote: > > > > > > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > > > > > > > > > When of_property_read_u32_array() returns an error code, > > > > > > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > > > > > > > > > > > Can another imperative wording be helpful for the change description? > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151 > > > > > > > > > > > > > > Would an other commit message be a bit nicer? > > > > > > > > > > > > > > > > > > > > > … > > > > > > > > +++ b/drivers/video/backlight/sky81452-backlight.c > > > > > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > > > > > > > > num_entry); > > > > > > > > if (ret < 0) { > > > > > > > > dev_err(dev, "led-sources node is invalid.\n"); > > > > > > > > + of_node_put(np); > > > > > > > > return ERR_PTR(-EINVAL); > > > > > > > > } > > > > > > > > > > > > > > I propose to add the jump target “put_node” so that a bit of common exception > > > > > > > handling code can be better reused at the end of this function implementation. > > > > > > > > > > > > > > Regards, > > > > > > > Markus > > > > > > > > > > > > You can safely ignore any review comments from Markus! > > > > > > > > > > > > However, this patch doesn't appear to be in my inbox. > > > > > > > > > > > > Any ideas as to why? > > > > > > > > > > > > > > > > Thank you for your advice. My outbox shows that this patch > > > > > has reached your email server successfully. Maybe this > > > > > ended up in your junk mail file? > > > > > > > > This has happened recently, so I was sure to check. > > > > > > > > Not there either unfortunately. > > > > > > > > Would you be kind enough to bounce/resend please? > > > > > > Sure. > > > > Looks like you sent it *only* to me. Please keep everyone else in Cc > > when doing that, or I can't respond to everyone. > > > > Anyway, besides the subject line (which I can fix easily), the patch > > looks good to me, but Daniel T must review. > > I've already offered a Reviewed-by for this patch. Perhaps it landed in > the same place as the original patch... Patch applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog